Commit de678bc63cc659d056a5ff3a3b11866d3eb4c1a9
Committed by
Jens Axboe
Jens Axboe
1 parent
708edafa88
block: Don't disable interrupts in trigger_softirq()
trigger_softirq() is always invoked as a SMP-function call which is always invoked with disables interrupts. Don't disable interrupt in trigger_softirq() because interrupts are already disabled. Reviewed-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Showing 1 changed file with 0 additions and 4 deletions Side-by-side Diff
block/blk-softirq.c
| ... | ... | @@ -42,17 +42,13 @@ |
| 42 | 42 | static void trigger_softirq(void *data) |
| 43 | 43 | { |
| 44 | 44 | struct request *rq = data; |
| 45 | - unsigned long flags; | |
| 46 | 45 | struct list_head *list; |
| 47 | 46 | |
| 48 | - local_irq_save(flags); | |
| 49 | 47 | list = this_cpu_ptr(&blk_cpu_done); |
| 50 | 48 | list_add_tail(&rq->ipi_list, list); |
| 51 | 49 | |
| 52 | 50 | if (list->next == &rq->ipi_list) |
| 53 | 51 | raise_softirq_irqoff(BLOCK_SOFTIRQ); |
| 54 | - | |
| 55 | - local_irq_restore(flags); | |
| 56 | 52 | } |
| 57 | 53 | |
| 58 | 54 | /* |