Commit df7f54c012b92ec93d56b68547351dcdf8a163d3
Committed by
James Morris
James Morris
1 parent
dd34b5d75a
Exists in
master
and in
39 other branches
SELinux: inode_doinit_with_dentry drop no dentry printk
Drop the printk message when an inode is found without an associated dentry. This should only happen when userspace can't be accessing those inodes and those labels will get set correctly on the next d_instantiate. Thus there is no reason to send this message. Signed-off-by: Eric Paris <eparis@redhat.com> Signed-off-by: James Morris <jmorris@namei.org>
Showing 1 changed file with 9 additions and 3 deletions Side-by-side Diff
security/selinux/hooks.c
| ... | ... | @@ -1263,9 +1263,15 @@ |
| 1263 | 1263 | dentry = d_find_alias(inode); |
| 1264 | 1264 | } |
| 1265 | 1265 | if (!dentry) { |
| 1266 | - printk(KERN_WARNING "SELinux: %s: no dentry for dev=%s " | |
| 1267 | - "ino=%ld\n", __func__, inode->i_sb->s_id, | |
| 1268 | - inode->i_ino); | |
| 1266 | + /* | |
| 1267 | + * this is can be hit on boot when a file is accessed | |
| 1268 | + * before the policy is loaded. When we load policy we | |
| 1269 | + * may find inodes that have no dentry on the | |
| 1270 | + * sbsec->isec_head list. No reason to complain as these | |
| 1271 | + * will get fixed up the next time we go through | |
| 1272 | + * inode_doinit with a dentry, before these inodes could | |
| 1273 | + * be used again by userspace. | |
| 1274 | + */ | |
| 1269 | 1275 | goto out_unlock; |
| 1270 | 1276 | } |
| 1271 | 1277 |