Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit e236a166b2bc437769a9b8b5d19186a3761bde48

Authored by Andrew Morton
Committed by Linus Torvalds
1 parent c2aeacd48c
Exists in master and in 39 other branches 8mp-imx_5.4.70_2.3.0, 8qm-imx_5.4.70_2.3.0, emb_imx_lf-5.15.y, emb_lf-6.1.y, imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, imx_4.1.15_1.0.0_ga, pitx_8mp_lf-5.10.y, rt-smarc-imx_4.1.15_1.0.0_ga, rt_linux_5.15.71, smarc-8m-android-11.0.0_2.0.0, smarc-imx6_4.14.98_2.0.0_ga, smarc-imx6_4.9.88_2.0.0_ga, smarc-imx7_4.14.98_2.0.0_ga, smarc-imx7_4.9.11_1.0.0_ga, smarc-imx7_4.9.88_2.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-imx_4.1.15_1.0.0_ga, smarc-imx_4.9.11_1.0.0_ga, smarc-imx_4.9.51_imx8m_ga, smarc-imx_4.9.88_2.0.0_ga, smarc-m6.0.1_2.1.0-ga, smarc-n7.1.2_2.0.0-ga, smarc-rel_imx_4.1.15_1.2.0_ga, smarc_8m_00d0_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.14.78_1.0.0_ga, smarc_8m_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.19.35_1.1.0, smarc_8mm_imx_4.14.78_1.0.0_ga, smarc_8mm_imx_4.14.98_2.0.0_ga, smarc_8mm_imx_4.19.35_1.1.0, smarc_8mm_imx_5.4.24_2.1.0, smarc_8mp_lf-5.10.y, smarc_8mq_imx_5.4.24_2.1.0, smarc_8mq_lf-5.10.y, smarc_imx_lf-5.15.y

[PATCH] mm: dirty_exceeded speedup 

Ravikiran reports that this variable is bouncing all around nodes on NUMA
machines, causing measurable performance problems.  Fix that up by only
writing to it when it actually changed.

And put it in a new cacheline to prevent it sharing with other things (this
happened).

Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Showing 1 changed file with 4 additions and 3 deletions Side-by-side Diff

... ... @@ -46,7 +46,7 @@
46 46 static long ratelimit_pages = 32;
47 47  
48 48 static long total_pages; /* The total number of pages in the machine. */
49   -static int dirty_exceeded; /* Dirty mem may be over limit */
  49 +static int dirty_exceeded __cacheline_aligned_in_smp; /* Dirty mem may be over limit */
50 50  
51 51 /*
52 52 * When balance_dirty_pages decides that the caller needs to perform some
... ... @@ -212,7 +212,8 @@
212 212 if (nr_reclaimable + wbs.nr_writeback <= dirty_thresh)
213 213 break;
214 214  
215   - dirty_exceeded = 1;
  215 + if (!dirty_exceeded)
  216 + dirty_exceeded = 1;
216 217  
217 218 /* Note: nr_reclaimable denotes nr_dirty + nr_unstable.
218 219 * Unstable writes are a feature of certain networked
... ... @@ -234,7 +235,7 @@
234 235 blk_congestion_wait(WRITE, HZ/10);
235 236 }
236 237  
237   - if (nr_reclaimable + wbs.nr_writeback <= dirty_thresh)
  238 + if (nr_reclaimable + wbs.nr_writeback <= dirty_thresh && dirty_exceeded)
238 239 dirty_exceeded = 0;
239 240  
240 241 if (writeback_in_progress(bdi))