Eric Lee / smarc-fsl-linux-kernel

Download as
Browse Code ยป

Commit e6937ee626dee9c66ae820f5cca11efca2933845

Authored by Julia Lawall
Committed by David S. Miller
1 parent 88e87be6ba
Exists in master and in 39 other branches 8mp-imx_5.4.70_2.3.0, 8qm-imx_5.4.70_2.3.0, emb_imx_lf-5.15.y, emb_lf-6.1.y, imx_3.0.35_4.1.0, imx_3.10.17_1.0.1_ga, imx_3.10.53_1.1.0_ga, imx_3.14.28_1.0.0_ga, imx_4.1.15_1.0.0_ga, pitx_8mp_lf-5.10.y, rt-smarc-imx_4.1.15_1.0.0_ga, rt_linux_5.15.71, smarc-8m-android-11.0.0_2.0.0, smarc-imx6_4.14.98_2.0.0_ga, smarc-imx6_4.9.88_2.0.0_ga, smarc-imx7_4.14.98_2.0.0_ga, smarc-imx7_4.9.11_1.0.0_ga, smarc-imx7_4.9.88_2.0.0_ga, smarc-imx_3.10.53_1.1.0_ga, smarc-imx_3.14.28_1.0.0_ga, smarc-imx_4.1.15_1.0.0_ga, smarc-imx_4.9.11_1.0.0_ga, smarc-imx_4.9.51_imx8m_ga, smarc-imx_4.9.88_2.0.0_ga, smarc-m6.0.1_2.1.0-ga, smarc-n7.1.2_2.0.0-ga, smarc-rel_imx_4.1.15_1.2.0_ga, smarc_8m_00d0_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.14.78_1.0.0_ga, smarc_8m_imx_4.14.98_2.0.0_ga, smarc_8m_imx_4.19.35_1.1.0, smarc_8mm_imx_4.14.78_1.0.0_ga, smarc_8mm_imx_4.14.98_2.0.0_ga, smarc_8mm_imx_4.19.35_1.1.0, smarc_8mm_imx_5.4.24_2.1.0, smarc_8mp_lf-5.10.y, smarc_8mq_imx_5.4.24_2.1.0, smarc_8mq_lf-5.10.y, smarc_imx_lf-5.15.y

drivers/net/a2065.c: Convert release_resource to release_region/release_mem_region 

Request_mem_region should be used with release_mem_region, not
release_resource.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,E;
@@
*x = request_mem_region(...)
... when != release_mem_region(x)
    when != x = E
* release_resource(x);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>

Showing 1 changed file with 5 additions and 5 deletions Side-by-side Diff

... ... @@ -711,14 +711,14 @@
711 711 return -EBUSY;
712 712 r2 = request_mem_region(mem_start, A2065_RAM_SIZE, "RAM");
713 713 if (!r2) {
714   - release_resource(r1);
  714 + release_mem_region(base_addr, sizeof(struct lance_regs));
715 715 return -EBUSY;
716 716 }
717 717  
718 718 dev = alloc_etherdev(sizeof(struct lance_private));
719 719 if (dev == NULL) {
720   - release_resource(r1);
721   - release_resource(r2);
  720 + release_mem_region(base_addr, sizeof(struct lance_regs));
  721 + release_mem_region(mem_start, A2065_RAM_SIZE);
722 722 return -ENOMEM;
723 723 }
724 724  
... ... @@ -764,8 +764,8 @@
764 764  
765 765 err = register_netdev(dev);
766 766 if (err) {
767   - release_resource(r1);
768   - release_resource(r2);
  767 + release_mem_region(base_addr, sizeof(struct lance_regs));
  768 + release_mem_region(mem_start, A2065_RAM_SIZE);
769 769 free_netdev(dev);
770 770 return err;
771 771 }