Commit ebbd5ac4acdbfd8e4286a96286b057e49287133a

Authored by Greg Kroah-Hartman
1 parent 0054c0bca3

Revert "bsg-lib: don't free job in bsg_prepare_job"

This reverts commit eb4375e1969c48d454998b2a284c2e6a5dc9eb68 which was
commit f507b54dccfd8000c517d740bc45f20c74532d18 upstream.

Ben reports:
	That function doesn't exist here (it was introduced in 4.13).
	Instead, this backport has modified bsg_create_job(), creating a
	leak.  Please revert this on the 3.18, 4.4 and 4.9 stable
	branches.

So I'm dropping it from here.

Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

... ... @@ -147,6 +147,7 @@
147 147 failjob_rls_rqst_payload:
148 148 kfree(job->request_payload.sg_list);
149 149 failjob_rls_job:
  150 + kfree(job);
150 151 return -ENOMEM;
151 152 }
152 153