05 Jan, 2020

1 commit

  • Apply const prefix to the static tables for parameters.

    Just for minor optimization and no functional changes.

    Link: https://lore.kernel.org/r/20200105144823.29547-52-tiwai@suse.de
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

03 Jan, 2020

3 commits

  • Most of snd_kcontrol_new definitions are read-only and passed as-is.
    Let's declare them as const for further optimization.

    There should be no functional changes by this patch.

    Link: https://lore.kernel.org/r/20200103081714.9560-36-tiwai@suse.de
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • Most of snd_timer_hardware definitions do simply copying to another
    struct as-is. Mark them as const for further optimization.

    There should be no functional changes by this patch.

    Link: https://lore.kernel.org/r/20200103081714.9560-22-tiwai@suse.de
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • Now we may declare const for snd_device_ops definitions, so let's do
    it for optimization.

    There should be no functional changes by this patch.

    Link: https://lore.kernel.org/r/20200103081714.9560-8-tiwai@suse.de
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

11 Dec, 2019

3 commits

  • The driver invokes snd_pcm_period_elapsed() simply from the interrupt
    handler. Set card->sync_irq for enabling the missing sync_stop PCM
    operation.

    Link: https://lore.kernel.org/r/20191210063454.31603-49-tiwai@suse.de
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • PCM core deals the empty ioctl field now as default(*).
    Let's kill the redundant lines.

    (*) commit fc033cbf6fb7 ("ALSA: pcm: Allow NULL ioctl ops")

    Link: https://lore.kernel.org/r/20191210061145.24641-8-tiwai@suse.de
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • Clean up the driver with the new managed buffer allocation API.
    The hw_free callback became superfluous and got dropped.

    Link: https://lore.kernel.org/r/20191209094943.14984-17-tiwai@suse.de
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

31 May, 2019

1 commit

  • Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation either version 2 of the license or at
    your option any later version this program is distributed in the
    hope that it will be useful but without any warranty without even
    the implied warranty of merchantability or fitness for a particular
    purpose see the gnu general public license for more details you
    should have received a copy of the gnu general public license along
    with this program if not write to the free software foundation inc
    59 temple place suite 330 boston ma 02111 1307 usa

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-or-later

    has been chosen to replace the boilerplate/reference in 1334 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Reviewed-by: Richard Fontana
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190527070033.113240726@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

21 May, 2019

1 commit


02 Feb, 2019

1 commit

  • We used to pass NULL to memory allocators for ISA devices due to
    historical reasons. But we prefer rather a proper device object to be
    assigned, so let's fix it by replacing snd_dma_isa_data() call with
    card->dev reference, and kill snd_dma_isa_data() definition.

    Reviewed-by: Christoph Hellwig
    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

16 Jan, 2019

1 commit


25 Nov, 2018

1 commit


03 Aug, 2018

1 commit

  • For a sake of code simplification, remove the init and the exit
    entries that do nothing.

    Notes for readers: actually it's OK to remove *both* init and exit,
    but not OK to remove the exit entry. By removing only the exit while
    keeping init, the module becomes permanently loaded; i.e. you cannot
    unload it any longer!

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

27 Jul, 2018

1 commit

  • The PCM format type is with __bitwise, and it can't be converted from
    integer implicitly. Instead of an ugly cast, declare the function
    argument of snd_wss_get_format() with the proper snd_pcm_format_t
    type.

    This fixes the sparse warnings like:
    sound/isa/wss/wss_lib.c:551:14: warning: restricted snd_pcm_format_t degrades to integer

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

17 Aug, 2017

1 commit


13 Aug, 2017

1 commit


09 Jun, 2017

1 commit


28 Jan, 2015

1 commit


02 Jan, 2015

1 commit

  • Most callers of snd_wss_pcm(), snd_wss_timer() and snd_cs4236_pcm() pass
    NULL as the last parameter, some callers pass a pointer but never use it
    after the function has been called and only a few callers pass a pointer and
    actually use it. The later is only the case for snd_wss_pcm() for
    snd_cs4236_pcm() and it is possible to get the same PCM object by accessing
    the pcm field of the snd_wss struct that was passed as the first parameter.

    This function removes the last parameters from the functions mentioned above
    and updates the callers which used it to use chip->pcm instead. This allows
    us to slightly simplify the functions since they don't have to check and set
    the last parameter anymore which makes the code slightly shorter and
    cleaner.

    Signed-off-by: Lars-Peter Clausen
    Signed-off-by: Takashi Iwai

    Lars-Peter Clausen
     

21 Oct, 2014

1 commit


16 Jul, 2012

2 commits

  • Yamaha OPL3-SAx chips don't resume properly when playback is running -
    garbage is played after resume. Restoring the CS4231_PLAYBK_FORMAT register
    last fixes the problem.

    Signed-off-by: Ondrej Zary
    Signed-off-by: Takashi Iwai

    Ondrej Zary
     
  • By setting SNDRV_PCM_INFO_RESUME, wss_lib claims that it can restore the card
    state fully on resume. But in fact, it can't as DMA is not restored so any
    playback/capture running during suspend will fail to continue after resume.

    Remove SNDRV_PCM_INFO_RESUME flag from pcm info field to fix the problem.

    Signed-off-by: Ondrej Zary
    Signed-off-by: Takashi Iwai

    Ondrej Zary
     

01 Nov, 2011

1 commit


22 Sep, 2011

1 commit

  • Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
    We run all interrupt handlers with interrupts disabled
    and we even check and yell when an interrupt handler
    returns with interrupts enabled (see commit [b738a50a:
    genirq: Warn when handler enables interrupts]).

    So now this flag is a NOOP and can be removed.

    Signed-off-by: Yong Zhang
    Acked-by: Peter Ujfalusi
    Acked-by: Mark Brown
    Signed-off-by: Takashi Iwai

    Yong Zhang
     

31 Mar, 2011

1 commit


11 Dec, 2009

1 commit


18 Nov, 2009

1 commit

  • Update control names to be more closer to their meaning.
    Change the "Mono" name to the "Beep" as this line is usually
    used to forward the PC beeper signal to sound card's output.
    Update names for both cs423x and wss.

    Clean up cs4235 controls according to the cs4235 doc. Rename
    some of the cs4235 controls to be consistent with the cs4236's
    ones.

    Also, delete one misnamed cs4231 register define.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai

    Krzysztof Helt
     

06 Nov, 2009

1 commit

  • The cs4236 was two step detection with call to the snd_wss_free()
    between two steps. The snd_wss_free() did not free a sound device
    created in the snd_wss_create(). This caused an OOPS during module
    removal as the same sound device was released twice. The same OOPS
    happened if the cs4236 module loading failed.

    Fix this by adapting the snd_cs4236_create() to correctly work with
    chips less capable then cs4236. The snd_cs4236_create() behaves the
    same as the snd_wss_create() if the chip is less capable than the cs4236.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai

    Krzysztof Helt
     

12 Oct, 2009

1 commit


10 Oct, 2009

1 commit


24 Mar, 2009

1 commit


17 Feb, 2009

1 commit

  • cs4232 and cs4236 driver merge to solve PnP BIOS detection.

    Also, the patch adds recognition if the chip is cs4236b+
    or earlier part. This unifies drivers for both cs4232
    and cs4236+ chips. It allows to use the PnP BIOS
    detection for the cs4236+ chips. Previously, only
    the snd-cs4232 could be detected by the PnP BIOS.

    The cs4232+ cards reports two separate PnP BIOS ids.

    The patch adds search for the second id to find out
    resources assigned to a control port.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai

    Krzysztof Helt
     

05 Feb, 2009

1 commit


17 Jan, 2009

1 commit


11 Jan, 2009

1 commit


25 Aug, 2008

2 commits


13 Aug, 2008

2 commits


06 Aug, 2008

1 commit

  • Make snd_ad1848_probe() easier to follow. With an exception for only
    trying once as soon as the codec is out of init (which should be all
    that's needed) the detection logic should be unchanged.

    Signed-off-by: Rene Herman
    Acked-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Rene Herman