Eric Lee / smarc-fsl-linux-kernel

01 Jun, 2020

1 commit

  • a0a3036b8   cifs: Standardize logging output ... Browse Code »

    Use pr_fmt to standardize all logging for fs/cifs.

    Some logging output had no CIFS: specific prefix.

    Now all output has one of three prefixes:

    o CIFS:
    o CIFS: VFS:
    o Root-CIFS:

    Miscellanea:

    o Convert printks to pr_
    o Neaten macro definitions
    o Remove embedded CIFS: prefixes from formats
    o Convert "illegal" to "invalid"
    o Coalesce formats
    o Add missing '\n' format terminations
    o Consolidate multiple cifs_dbg continuations into single calls
    o More consistent use of upper case first word output logging
    o Multiline statement argument alignment and wrapping

    Signed-off-by: Joe Perches
    Signed-off-by: Steve French

    Joe Perches
     

17 Sep, 2019

2 commits

31 May, 2019

1 commit

  • 1a59d1b8e   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 ... Browse Code »

    Based on 1 normalized pattern(s):

    this program is free software you can redistribute it and or modify
    it under the terms of the gnu general public license as published by
    the free software foundation either version 2 of the license or at
    your option any later version this program is distributed in the
    hope that it will be useful but without any warranty without even
    the implied warranty of merchantability or fitness for a particular
    purpose see the gnu general public license for more details you
    should have received a copy of the gnu general public license along
    with this program if not write to the free software foundation inc
    59 temple place suite 330 boston ma 02111 1307 usa

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-or-later

    has been chosen to replace the boilerplate/reference in 1334 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Allison Randal
    Reviewed-by: Richard Fontana
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190527070033.113240726@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

24 Oct, 2018

2 commits

  • 8c1beb980   cifs: minor clarification in comments ... Browse Code »

    Clarify meaning (in comments) meaning of various
    options for debug messages in cifs.ko. Also fixed
    trivial formatting/style issue with previous patch.

    Signed-off-by: Steve French

    Steve French
     
  • 9a0efeccf   CIFS: Adds information-level logging function ... Browse Code »

    Currently, CIFS lacks a internal logging function that prints out data
    when CIFS_DEBUG=n. When CIFS_DEBUG=y, the only message level for CIFS
    events are KERN_ERR or KERN_DEBUG.

    This patch creates cifs_info(), which is useful for printing
    non-critical event messges, at either CIFS_DEBUG state.

    Signed-off-by: Rodrigo Freire
    Signed-off-by: Steve French

    Rodrigo Freire
     

28 May, 2018

1 commit

21 Apr, 2018

1 commit

12 Apr, 2018

1 commit

  • f2f176b41   CIFS: add ONCE flag for cifs_dbg type ... Browse Code »

    * Since cifs_vfs_error was just using pr_debug_ratelimited like the rest
    of cifs_dbg, move it there too
    * Add a ONCE type flag to call the pr_xxx_once() debug function instead
    of the ratelimited ones.

    To convert existing printk_once() calls to this we can run:

    perl -i -pE \
    's/printk_once\s*\(([^" \n]+)(.*)/cifs_dbg(VFS|ONCE,$2/g' \
    fs/cifs/*.c

    Signed-off-by: Aurelien Aptel
    Signed-off-by: Steve French

    Aurelien Aptel
     

18 Mar, 2016

1 commit

  • 1404297eb   lib: update single-char callers of strtobool() ... Browse Code »
    28

    Some callers of strtobool() were passing a pointer to unterminated
    strings. In preparation of adding multi-character processing to
    kstrtobool(), update the callers to not pass single-character pointers,
    and switch to using the new kstrtobool_from_user() helper where
    possible.

    Signed-off-by: Kees Cook
    Cc: Amitkumar Karwar
    Cc: Nishant Sarmukadam
    Cc: Kalle Valo
    Cc: Steve French
    Cc: Andy Shevchenko
    Cc: Daniel Borkmann
    Cc: Heiko Carstens
    Cc: Joe Perches
    Cc: Kees Cook
    Cc: Martin Schwidefsky
    Cc: Michael Ellerman
    Cc: Rasmus Villemoes
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Kees Cook
     

15 Jan, 2016

1 commit

  • ec7147a99   cifs: Ratelimit kernel log messages ... Browse Code »

    Under some conditions, CIFS can repeatedly call the cifs_dbg() logging
    wrapper. If done rapidly enough, the console framebuffer can softlockup
    or "rcu_sched self-detected stall". Apply the built-in log ratelimiters
    to prevent such hangs.

    Signed-off-by: Jamie Bainbridge
    Signed-off-by: Steve French
    CC: Stable

    Jamie Bainbridge
     

08 Dec, 2014

1 commit

05 May, 2013

1 commit

  • f96637be0   [CIFS] cifs: Rename cERROR and cFYI to cifs_dbg ... Browse Code »

    It's not obvious from reading the macro names that these macros
    are for debugging. Convert the names to a single more typical
    kernel style cifs_dbg macro.

    cERROR(1, ...) -> cifs_dbg(VFS, ...)
    cFYI(1, ...) -> cifs_dbg(FYI, ...)
    cFYI(DBG2, ...) -> cifs_dbg(NOISY, ...)

    Move the terminating format newline from the macro to the call site.

    Add CONFIG_CIFS_DEBUG function cifs_vfs_err to emit the
    "CIFS VFS: " prefix for VFS messages.

    Size is reduced ~ 1% when CONFIG_CIFS_DEBUG is set (default y)

    $ size fs/cifs/cifs.ko*
    text data bss dec hex filename
    265245 2525 132 267902 4167e fs/cifs/cifs.ko.new
    268359 2525 132 271016 422a8 fs/cifs/cifs.ko.old

    Other miscellaneous changes around these conversions:

    o Miscellaneous typo fixes
    o Add terminating \n's to almost all formats and remove them
    from the macros to be more kernel style like. A few formats
    previously had defective \n's
    o Remove unnecessary OOM messages as kmalloc() calls dump_stack
    o Coalesce formats to make grep easier,
    added missing spaces when coalescing formats
    o Use %s, __func__ instead of embedded function name
    o Removed unnecessary "cifs: " prefixes
    o Convert kzalloc with multiply to kcalloc
    o Remove unused cifswarn macro

    Signed-off-by: Joe Perches
    Signed-off-by: Jeff Layton
    Signed-off-by: Steve French

    Joe Perches
     

21 Dec, 2012

1 commit

06 Dec, 2012

3 commits

23 May, 2012

1 commit

24 Mar, 2012

2 commits

08 Oct, 2010

1 commit

21 Apr, 2010

1 commit

  • b6b38f704   [CIFS] Neaten cERROR and cFYI macros, reduce text space ... Browse Code »

    Neaten cERROR and cFYI macros, reduce text space
    ~2.5K

    Convert '__FILE__ ": " fmt' to '"%s: " fmt', __FILE__' to save text space
    Surround macros with do {} while
    Add parentheses to macros
    Make statement expression macro from macro with assign
    Remove now unnecessary parentheses from cFYI and cERROR uses

    defconfig with CIFS support old
    $ size fs/cifs/built-in.o
    text data bss dec hex filename
    156012 1760 148 157920 268e0 fs/cifs/built-in.o

    defconfig with CIFS support old
    $ size fs/cifs/built-in.o
    text data bss dec hex filename
    153508 1760 148 155416 25f18 fs/cifs/built-in.o

    allyesconfig old:
    $ size fs/cifs/built-in.o
    text data bss dec hex filename
    309138 3864 74824 387826 5eaf2 fs/cifs/built-in.o

    allyesconfig new
    $ size fs/cifs/built-in.o
    text data bss dec hex filename
    305655 3864 74824 384343 5dd57 fs/cifs/built-in.o

    Signed-off-by: Joe Perches
    Signed-off-by: Steve French

    Joe Perches
     

13 Feb, 2008

1 commit

08 Feb, 2008

1 commit

01 Jun, 2006

1 commit

12 Oct, 2005

1 commit

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds