Eric Lee / smarc-fsl-linux-kernel

24 Aug, 2020

1 commit

  • df561f668   treewide: Use fallthrough pseudo-keyword ... Browse Code »

    Replace the existing /* fall through */ comments and its variants with
    the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
    fall-through markings when it is the case.

    [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

    Signed-off-by: Gustavo A. R. Silva

    Gustavo A. R. Silva
     

03 Aug, 2020

2 commits

05 Jun, 2020

2 commits

  • 2f5896797   cifs: multichannel: try to rebind when reconnecting a channel ... Browse Code »

    first steps in trying to make channels properly reconnect.

    * add cifs_ses_find_chan() function to find the enclosing cifs_chan
    struct it belongs to
    * while we have the session lock and are redoing negprot and
    sess.setup in smb2_reconnect() redo the binding of channels.

    Signed-off-by: Aurelien Aptel
    Signed-off-by: Steve French

    Aurelien Aptel
     
  • 8eec79540   cifs: multichannel: use pointer for binding channel ... Browse Code »

    Add a cifs_chan pointer in struct cifs_ses that points to the channel
    currently being bound if ses->binding is true.

    Previously it was always the channel past the established count.

    This will make reconnecting (and rebinding) a channel easier later on.

    Signed-off-by: Aurelien Aptel
    Signed-off-by: Steve French

    Aurelien Aptel
     

02 Jun, 2020

1 commit

01 Jun, 2020

1 commit

  • a0a3036b8   cifs: Standardize logging output ... Browse Code »

    Use pr_fmt to standardize all logging for fs/cifs.

    Some logging output had no CIFS: specific prefix.

    Now all output has one of three prefixes:

    o CIFS:
    o CIFS: VFS:
    o Root-CIFS:

    Miscellanea:

    o Convert printks to pr_
    o Neaten macro definitions
    o Remove embedded CIFS: prefixes from formats
    o Convert "illegal" to "invalid"
    o Coalesce formats
    o Add missing '\n' format terminations
    o Consolidate multiple cifs_dbg continuations into single calls
    o More consistent use of upper case first word output logging
    o Multiline statement argument alignment and wrapping

    Signed-off-by: Joe Perches
    Signed-off-by: Steve French

    Joe Perches
     

06 Feb, 2020

1 commit

05 Dec, 2019

2 commits

  • 9a7d5a9e6   cifs: fix possible uninitialized access and race on iface_list ... Browse Code »

    iface[0] was accessed regardless of the count value and without
    locking.

    * check count before accessing any ifaces
    * make copy of iface list (it's a simple POD array) and use it without
    locking.

    Signed-off-by: Aurelien Aptel
    Signed-off-by: Steve French
    Reviewed-by: Paulo Alcantara (SUSE)

    Aurelien Aptel
     
  • 3345bb44b   cifs: Fix lookup of SMB connections on multichannel ... Browse Code »

    With the addition of SMB session channels, we introduced new TCP
    server pointers that have no sessions or tcons associated with them.

    In this case, when we started looking for TCP connections, we might
    end up picking session channel rather than the master connection,
    hence failing to get either a session or a tcon.

    In order to fix that, this patch introduces a new "is_channel" field
    to TCP_Server_Info structure so we can skip session channels during
    lookup of connections.

    Signed-off-by: Paulo Alcantara (SUSE)
    Reviewed-by: Aurelien Aptel
    Signed-off-by: Steve French

    Paulo Alcantara (SUSE)
     

25 Nov, 2019

3 commits

  • 65a37a341   cifs: try harder to open new channels ... Browse Code »

    Previously we would only loop over the iface list once.
    This patch tries to loop over multiple times until all channels are
    opened. It will also try to reuse RSS ifaces.

    Signed-off-by: Aurelien Aptel
    Signed-off-by: Steve French

    Aurelien Aptel
     
  • d70e9fa55   cifs: try opening channels after mounting ... Browse Code »

    After doing mount() successfully we call cifs_try_adding_channels()
    which will open as many channels as it can.

    Channels are closed when the master session is closed.

    The master connection becomes the first channel.

    ,-------------> global cifs_tcp_ses_list
    Signed-off-by: Steve French

    Aurelien Aptel
     
  • f6a6bf7c4   cifs: switch servers depending on binding state ... Browse Code »

    Currently a lot of the code to initialize a connection & session uses
    the cifs_ses as input. But depending on if we are opening a new session
    or a new channel we need to use different server pointers.

    Add a "binding" flag in cifs_ses and a helper function that returns
    the server ptr a session should use (only in the sess establishment
    code path).

    Signed-off-by: Aurelien Aptel
    Signed-off-by: Steve French

    Aurelien Aptel
     

24 Sep, 2019

1 commit

28 Aug, 2019

1 commit

  • 340625e61   cifs: replace various strncpy with strscpy and similar ... Browse Code »

    Using strscpy is cleaner, and avoids some problems with
    handling maximum length strings. Linus noticed the
    original problem and Aurelien pointed out some additional
    problems. Fortunately most of this is SMB1 code (and
    in particular the ASCII string handling older, which
    is less common).

    Reported-by: Linus Torvalds
    Reviewed-by: Aurelien Aptel
    Signed-off-by: Ronnie Sahlberg
    Signed-off-by: Steve French

    Ronnie Sahlberg
     

24 Dec, 2018

2 commits

24 Aug, 2018

1 commit

  • 126c97f4d   cifs: check kmalloc before use ... Browse Code »

    The kmalloc was not being checked - if it fails issue a warning
    and return -ENOMEM to the caller.

    Signed-off-by: Nicholas Mc Guire
    Fixes: b8da344b74c8 ("cifs: dynamic allocation of ntlmssp blob")
    Signed-off-by: Steve French
    Reviewed-by: Pavel Shilovsky
    cc: Stable `

    Nicholas Mc Guire
     

03 Mar, 2017

1 commit

  • ef65aaede   smb2: Enforce sec= mount option ... Browse Code »

    If the security type specified using a mount option is not supported,
    the SMB2 session setup code changes the security type to RawNTLMSSP. We
    should instead fail the mount and return an error.

    The patch changes the code for SMB2 to make it similar to the code used
    for SMB1. Like in SMB1, we now use the global security flags to select
    the security method to be used when no security method is specified and
    to return an error when the requested auth method is not available.

    For SMB2, we also use ntlmv2 as a synonym for nltmssp.

    Signed-off-by: Sachin Prabhu
    Acked-by: Pavel Shilovsky
    Acked-by: Jeff Layton
    Signed-off-by: Steve French

    Sachin Prabhu
     

02 Feb, 2017

2 commits

24 Jun, 2016

3 commits

  • a6b6befbb   cifs: check hash calculating succeeded ... Browse Code »

    calc_lanman_hash() could return -ENOMEM or other errors, we should check
    that everything went fine before using the calculated key.

    Signed-off-by: Luis de Bethencourt
    Signed-off-by: Steve French

    Luis de Bethencourt
     
  • b8da344b7   cifs: dynamic allocation of ntlmssp blob ... Browse Code »

    In sess_auth_rawntlmssp_authenticate(), the ntlmssp blob is allocated
    statically and its size is an "empirical" 5*sizeof(struct
    _AUTHENTICATE_MESSAGE) (320B on x86_64). I don't know where this value
    comes from or if it was ever appropriate, but it is currently
    insufficient: the user and domain name in UTF16 could take 1kB by
    themselves. Because of that, build_ntlmssp_auth_blob() might corrupt
    memory (out-of-bounds write). The size of ntlmssp_blob in
    SMB2_sess_setup() is too small too (sizeof(struct _NEGOTIATE_MESSAGE)
    + 500).

    This patch allocates the blob dynamically in
    build_ntlmssp_auth_blob().

    Signed-off-by: Jerome Marchand
    Signed-off-by: Steve French
    CC: Stable

    Jerome Marchand
     
  • 202d772ba   cifs: use CIFS_MAX_DOMAINNAME_LEN when converting the domain name ... Browse Code »

    Currently in build_ntlmssp_auth_blob(), when converting the domain
    name to UTF16, CIFS_MAX_USERNAME_LEN limit is used. It should be
    CIFS_MAX_DOMAINNAME_LEN. This patch fixes this.

    Signed-off-by: Jerome Marchand
    Signed-off-by: Steve French

    Jerome Marchand
     

18 May, 2016

4 commits

21 Oct, 2015

1 commit

  • 146aa8b14   KEYS: Merge the type-specific data with the payload data ... Browse Code »

    Merge the type-specific data with the payload data into one four-word chunk
    as it seems pointless to keep them separate.

    Use user_key_payload() for accessing the payloads of overloaded
    user-defined keys.

    Signed-off-by: David Howells
    cc: linux-cifs@vger.kernel.org
    cc: ecryptfs@vger.kernel.org
    cc: linux-ext4@vger.kernel.org
    cc: linux-f2fs-devel@lists.sourceforge.net
    cc: linux-nfs@vger.kernel.org
    cc: ceph-devel@vger.kernel.org
    cc: linux-ima-devel@lists.sourceforge.net

    David Howells
     

11 Dec, 2014

2 commits

  • b6da0076b   Merge branch 'akpm' (patchbomb from Andrew) ... Browse Code »

    Merge first patchbomb from Andrew Morton:
    - a few minor cifs fixes
    - dma-debug upadtes
    - ocfs2
    - slab
    - about half of MM
    - procfs
    - kernel/exit.c
    - panic.c tweaks
    - printk upates
    - lib/ updates
    - checkpatch updates
    - fs/binfmt updates
    - the drivers/rtc tree
    - nilfs
    - kmod fixes
    - more kernel/exit.c
    - various other misc tweaks and fixes

    * emailed patches from Andrew Morton : (190 commits)
    exit: pidns: fix/update the comments in zap_pid_ns_processes()
    exit: pidns: alloc_pid() leaks pid_namespace if child_reaper is exiting
    exit: exit_notify: re-use "dead" list to autoreap current
    exit: reparent: call forget_original_parent() under tasklist_lock
    exit: reparent: avoid find_new_reaper() if no children
    exit: reparent: introduce find_alive_thread()
    exit: reparent: introduce find_child_reaper()
    exit: reparent: document the ->has_child_subreaper checks
    exit: reparent: s/while_each_thread/for_each_thread/ in find_new_reaper()
    exit: reparent: fix the cross-namespace PR_SET_CHILD_SUBREAPER reparenting
    exit: reparent: fix the dead-parent PR_SET_CHILD_SUBREAPER reparenting
    exit: proc: don't try to flush /proc/tgid/task/tgid
    exit: release_task: fix the comment about group leader accounting
    exit: wait: drop tasklist_lock before psig->c* accounting
    exit: wait: don't use zombie->real_parent
    exit: wait: cleanup the ptrace_reparented() checks
    usermodehelper: kill the kmod_thread_locker logic
    usermodehelper: don't use CLONE_VFORK for ____call_usermodehelper()
    fs/hfs/catalog.c: fix comparison bug in hfs_cat_keycmp
    nilfs2: fix the nilfs_iget() vs. nilfs_new_inode() races
    ...

    Linus Torvalds
     
  • bc09d141e   fs/cifs: remove obsolete __constant ... Browse Code »

    Replace all __constant_foo to foo() except in smb2status.h (1700 lines to
    update).

    Signed-off-by: Fabian Frederick
    Cc: Steve French
    Cc: Jeff Layton
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Fabian Frederick
     

08 Dec, 2014

1 commit

  • ee9bbf465   Set UID in sess_auth_rawntlmssp_authenticate too ... Browse Code »

    A user complained that they were unable to login to their cifs share
    after a kernel update. From the wiretrace we can see that the server
    returns different UIDs as response to NTLMSSP_NEGOTIATE and NTLMSSP_AUTH
    phases.

    With changes in the authentication code, we no longer set the
    cifs_sess->Suid returned in response to the NTLM_AUTH phase and continue
    to use the UID sent in response to the NTLMSSP_NEGOTIATE phase. This
    results in the server denying access to the user when the user attempts
    to do a tcon connect.

    See https://bugzilla.redhat.com/show_bug.cgi?id=1163927

    A test kernel containing patch was tested successfully by the user.

    Signed-off-by: Sachin Prabhu
    Signed-off-by: Steve French

    Sachin Prabhu
     

16 Sep, 2014

1 commit

  • 116ae5e2b   cifs: remove dead code ... Browse Code »

    cifs provides two dummy functions 'sess_auth_lanman' and
    'sess_auth_kerberos' for the case in which the respective
    features are not defined. However, the caller is also under
    an #ifdef, so we just get warnings about unused code:

    fs/cifs/sess.c:1109:1: warning: 'sess_auth_kerberos' defined but not used [-Wunused-function]
    sess_auth_kerberos(struct sess_data *sess_data)

    Removing the dead functions gets rid of the warnings without
    any downsides that I can see.

    (Yalin Wang reported the identical problem and fix so added him)

    Signed-off-by: Arnd Bergmann
    Signed-off-by: Yalin Wang
    Signed-off-by: Steve French

    Arnd Bergmann
     

22 Aug, 2014

1 commit

02 Aug, 2014

1 commit

01 Aug, 2014

4 commits

07 Oct, 2013

1 commit