18 Jun, 2005

1 commit


17 Jun, 2005

1 commit

  • __cfq_get_queue(). __cfq_get_queue() finds an existing queue (struct
    cfq_queue) of the current process for the device and returns it. If it's not
    found, __cfq_get_queue() creates and returns a new one if __cfq_get_queue() is
    called with __GFP_WAIT flag, or __cfq_get_queue() returns NULL (this means that
    get_request() fails) if no __GFP_WAIT flag.

    On the other hand, in __make_request(), get_request() is called without
    __GFP_WAIT flag at the first time. Thus, the get_request() fails when there is
    no existing queue, typically when it's called for the first I/O request of the
    process to the device.

    Though it will be followed by get_request_wait() for general case,
    __make_request() will just end the I/O with an error (EWOULDBLOCK) when the
    request was for read-ahead.

    Signed-off-by: Jens Axboe
    Signed-off-by: Kiyoshi Ueda
    Signed-off-by: Jun'ichi Nomura

    Kiyoshi Ueda
     

16 Jun, 2005

2 commits


12 Jun, 2005

1 commit

  • Patch removes our homegrown DMA masks and uses the ones defined in the kernel.
    This patch replaces the broken one I sent in earlier. It has been tested and works. Please discard the first submission.

    Signed-off-by: Mike Miller
    Signed-off-by: James Bottomley

    mike.miller@hp.com
     

09 Jun, 2005

1 commit

  • This smoothes two imperfections:
    - Increase number of LUNs per device from 4 to 9. The best solution
    would be to remove this limit altogether, but that has to wait until
    the time when more than 26 hosts are allowed.
    - Replace mdelay with msleep in a probing routine.

    Signed-off-by: Pete Zaitcev
    Signed-off-by: Greg Kroah-Hartman

    Pete Zaitcev
     

03 Jun, 2005

1 commit


27 May, 2005

1 commit


21 May, 2005

4 commits


17 May, 2005

3 commits

  • I found a bug in the packet writing driver that could cause data
    corruption. The problem arised if the driver got a write request for a
    sector in a "zone" it was already working on. In that case it was supposed
    to queue the write request until it was done processing earlier requests
    for the same zone, and instead work on some other zone in the mean time.
    However, if there was no other zone to work on, the driver would initiate
    two packet_data objects for the same zone, causing unpredictable things to
    happen.

    Signed-off-by: Peter Osterlund
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Peter Osterlund
     
  • ioctl_by_bdev may only be used INSIDE the kernel. If the "arg" argument
    refers to memory that is accessed by put_user/get_user in the ioctl
    function, the memory needs to be in the kernel address space (that's the
    set_fs(KERNEL_DS) doing in the ioctl_by_bdev). This works on i386 because
    even with set_fs(KERNEL_DS) the user space memory is still accessible with
    put_user/get_user. That is not true for s390. In short the ioctl
    implementation of the pktcdvd device driver is horribly broken.

    Signed-off-by: Peter Osterlund
    Signed-off-by: Andrew Morton
    Signed-off-by: Greg Kroah-Hartman

    Peter Osterlund
     
  • [Patch] Fix raw device ioctl pass-through

    Raw character devices are supposed to pass ioctls through to the block
    devices they are bound to. Unfortunately, they are using the wrong
    function for this: ioctl_by_bdev(), instead of blkdev_ioctl().

    ioctl_by_bdev() performs a set_fs(KERNEL_DS) before calling the ioctl,
    redirecting the user-space buffer access to the kernel address space.
    This is, needless to say, a bad thing.

    This was noticed first on s390, where raw IO was non-functioning. The
    s390 driver config does not actually allow raw IO to be enabled, which
    was the first part of the problem. Secondly, the s390 kernel address
    space is distinct from user, causing legal raw ioctls to fail. I've
    reproduced this on a kernel built with 4G:4G split on x86, which fails
    in the same way (-EFAULT if the address does not exist kernel-side;
    returns success without actually populating the user buffer if it does.)

    The patch below fixes both the config and address-space problems. It's
    based closely on a patch by Jan Glauber , which has
    been tested on s390 at IBM. I've tested it on x86 4G:4G (split address
    space) and x86_64 (common address space).

    Kernel-address-space access has been assigned CAN-2005-1264.

    Signed-off-by: Stephen Tweedie
    Signed-off-by: Dave Jones
    Signed-off-by: Greg Kroah-Hartman

    Stephen Tweedie
     

07 May, 2005

1 commit


06 May, 2005

3 commits

  • This patch makes some needlessly global identifiers static.

    Signed-off-by: Adrian Bunk
    Acked-by: Arjan van de Ven
    Acked-by: Trond Myklebust
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • The only caller that ever sets it can call fsync_bdev itself easily. Also
    update some comments.

    Signed-off-by: Christoph Hellwig
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     
  • This patch adds support for a new class of DAC960 controllers. It's based
    on the GPLed idac320 driver from IBM for Linux 2.4.18. That driver is a
    fork of the 2.4.18 version of DAC960 that adds support for this new type of
    controllers (internally called "GEM Series"), that differ from other DAC960
    V2 firmware controllers only in the register offsets and removes support
    for all others.

    This patch instead integrates support for these controllers into the DAC960
    driver.

    Thanks to Anders Norrbring for pointing me to the idac320 driver and
    testing this patch.

    No Signed-Off: line because all code is either copy & pasted from IBM's
    idac320 driver or support for other controllers in the 2.6 DAC960 driver.

    Note: the really odd formating matches the rest of the DAC960 driver.

    Cc: Dave Olien
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christoph Hellwig
     

04 May, 2005

5 commits


01 May, 2005

2 commits

  • This patches adds the "nbds_max" parameter to the nbd kernel module, which
    limits the number of nbds allocated. Previously, always all 128 entries
    were allocated unconditionally, which used to waste resources and
    needlessly flood the hotplug system with events. (Defaults to 16 now.)

    Signed-off-by: Lars Marowsky-Bree
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Lars Marowsky-Bree
     
  • Profiling hit rates on merging shows that the last merge hint works
    extremely well for most work loads. So lets kill the linear merge scan in
    noop-iosched, so it provides O(1) run time for any operation.

    Testing credits go to Ken Chen from Intel.

    Signed-off-by: Jens Axboe
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jens Axboe
     

25 Apr, 2005

1 commit

  • (!ARCH_S390 && !M68K && !IA64 && !UML) is obviously always true on ARM.

    Intended behaviour for ARM is "absent unless we are on RiscPC or
    EBSA285". So what we want is added && !ARM in the first term - without
    it the last part (|| ARCH_RPC || ARCH_EBSA285, that is) doesn't do
    anything.

    Signed-off-by: Al Viro
    Signed-off-by: Linus Torvalds

    Al Viro
     

19 Apr, 2005

9 commits


17 Apr, 2005

4 commits

  • The current problem seen is that the queue lock is actually in the
    SCSI device structure, so when that structure is freed on device
    release, we go boom if the queue tries to access the lock again.

    The fix here is to move the lock from the scsi_device to the queue.

    Signed-off-by: James Bottomley

     
  • Both the RiscPC and (optionally) EBSA285 have floppy disk support. Allow this
    option to be selected on these ARM platforms again.

    Signed-off-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Russell King
     
  • In function __generic_unplug_device(), kernel can use a cheaper function
    elv_queue_empty() instead of more expensive elv_next_request to find
    whether the queue is empty or not. blk_run_queue can also made conditional
    on whether queue's emptiness before calling request_fn().

    Signed-off-by: Jens Axboe
    Signed-off-by: Ken Chen
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ken Chen
     
  • There is a possibility that a bio will be accessed after it has been freed
    on SCSI. It happens if you submit a bio with BIO_SYNC marked and the
    auto-unplugging kicks the request_fn, SCSI re-enables interrupts in-between
    so if the request completes between the add_request() in __make_request()
    and the bio_sync() call, we could be looking at a dead bio. It's a slim
    race, but it has been triggered in the Real World.

    So assign bio_sync() to a local variable instead.

    Signed-off-by: Jens Axboe
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jens Axboe