13 Jan, 2011

1 commit

  • As discussed one year ago, the WDIOC_GETSUPPORT ioctl only needs a
    mutex because it operates on a static variable. There is no good
    reason to keep this variable static, so let's just make it non-static
    and drop the now useless mutex altogether.

    See the discussion at:
    http://marc.info/?l=lm-sensors&m=125563869402323&w=2

    Signed-off-by: Jean Delvare
    Cc: Hans de Goede
    Acked-by: Guenter Roeck
    Acked-by: Arnd Bergmann
    Acked-by: Thomas Gleixner

    Jean Delvare
     

05 Oct, 2010

1 commit

  • All these files use the big kernel lock in a trivial
    way to serialize their private file operations,
    typically resulting from an earlier semi-automatic
    pushdown from VFS.

    None of these drivers appears to want to lock against
    other code, and they all use the BKL as the top-level
    lock in their file operations, meaning that there
    is no lock-order inversion problem.

    Consequently, we can remove the BKL completely,
    replacing it with a per-file mutex in every case.
    Using a scripted approach means we can avoid
    typos.

    These drivers do not seem to be under active
    maintainance from my brief investigation. Apologies
    to those maintainers that I have missed.

    file=$1
    name=$2
    if grep -q lock_kernel ${file} ; then
    if grep -q 'include.*linux.mutex.h' ${file} ; then
    sed -i '/include.*/d' ${file}
    else
    sed -i 's/include.*.*$/include /g' ${file}
    fi
    sed -i ${file} \
    -e "/^#include.*linux.mutex.h/,$ {
    1,/^\(static\|int\|long\)/ {
    /^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);

    } }" \
    -e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
    -e '/[ ]*cycle_kernel_lock();/d'
    else
    sed -i -e '/include.*\/d' ${file} \
    -e '/cycle_kernel_lock()/d'
    fi

    Signed-off-by: Arnd Bergmann

    Arnd Bergmann
     

17 May, 2010

1 commit

  • These are the last remaining device drivers using
    the ->ioctl file operation in the drivers directory
    (except from v4l drivers).

    [fweisbec: drop i8k pushdown as it has been done from
    procfs pushdown branch already]

    Signed-off-by: Arnd Bergmann
    Signed-off-by: Frederic Weisbecker

    Arnd Bergmann
     

06 Mar, 2010

1 commit

  • Recent changes on the I2C front have left off-by-one array indexes in
    3 hwmon drivers. Fix them.

    Faulty commit:
    e5e9f44c2 i2c: Drop I2C_CLIENT_INSMOD_2 to 8

    Reported-by: Dan Carpenter
    Signed-off-by: Jean Delvare
    Cc: Hans de Goede
    Cc: Andre Prendel
    Cc: stable@kernel.org

    Jean Delvare
     

25 Jan, 2010

1 commit


15 Dec, 2009

3 commits


10 Dec, 2009

1 commit

  • As kind is now hard-coded to -1, there is room for code clean-ups.

    Signed-off-by: Jean Delvare
    Acked-by: Corentin Labbe
    Cc: "Mark M. Hoffman"
    Cc: Juerg Haefliger
    Cc: Riku Voipio
    Acked-by: "Hans J. Koch"
    Cc: Rudolf Marek

    Jean Delvare
     

24 Oct, 2009

1 commit


02 Oct, 2009

1 commit


31 Mar, 2009

3 commits


08 Jan, 2009

1 commit

  • * 'hwmon-for-linus' of git://jdelvare.pck.nerim.net/jdelvare-2.6: (29 commits)
    hwmon: Fix various typos
    hwmon: Check for ACPI resource conflicts
    hwmon: (lm70) Add TI TMP121 support
    hwmon: (lm70) Code streamlining and cleanup
    hwmon: Deprecate the fscher and fscpos drivers
    hwmon: (fschmd) Add watchdog support
    hwmon: (fschmd) Cleanups for watchdog support
    hwmon: (i5k_amb) Load automatically on all 5000/5400 chipsets
    hwmon: (it87) Add support for the ITE IT8720F
    hwmon: Don't overuse I2C_CLIENT_MODULE_PARM
    hwmon: Add LTC4245 driver
    hwmon: (f71882fg) Fix fan_to/from_reg prototypes
    hwmon: (f71882fg) Printout fan modes
    hwmon: (f71882fg) Add documentation
    hwmon: (f71882fg) Fix auto_channels_temp temp numbering with f8000
    hwmon: (f71882fg) Add missing pwm3 attr for f71862fg
    hwmon: (f71882fg) Add F8000 support
    hwmon: (f71882fg) Remove the fan_mode module option
    hwmon: (f71882fg) Separate max and crit alarm and beep
    hwmon: (f71882fg) Check for hwmon powerdown state
    ...

    Linus Torvalds
     

07 Jan, 2009

2 commits


06 Jan, 2009

1 commit


17 Jul, 2008

1 commit


19 Feb, 2008

1 commit


08 Feb, 2008

2 commits


11 Oct, 2007

1 commit