Eric Lee / smarc-fsl-linux-kernel

01 Jan, 2011

1 commit

24 Dec, 2010

1 commit

  • 9d32af66a   spi/topcliff_pch: Fix data transfer issue ... Browse Code »

    It seems spi_topcliff_pch of linux-2.6.37-rc6 degraded by previous patch.
    In fact, data transfer fails on evaluation board testing.
    I found like the following register miss-setting line.
    Using this patch, I have confirmed data transfer can work well.

    Signed-off-by: Tomoya MORINAGA
    Signed-off-by: Grant Likely

    Tomoya MORINAGA
     

14 Oct, 2010

1 commit

  • 8e41b527f   spi/topcliff: Fix uninitialized variable defect ... Browse Code »

    This patch fixes the following build error introduced by commit
    65308c46, "spi/topcliff: cleanup for style and conciseness".

    drivers/spi/spi_topcliff_pch.c: In function 'pch_spi_process_messages':
    drivers/spi/spi_topcliff_pch.c:752: warning: 'data' is used uninitialized in
    +this function

    Signed-off-by: Grant Likely

    Grant Likely
     

13 Oct, 2010

1 commit

  • 65308c46b   spi/topcliff: cleanups for style and conciseness ... Browse Code »

    This patch makes multiple cleanups to the new topcliff pch spi driver
    including, but not limited to,
    - removing superfluous brackets around variables
    - open coding functions that are only used once
    - removing unnecessary line breaks
    - removing unused functions
    - simplifying the interrupt enable/disable code
    - remove unnecessary (void *) casts.
    - remove b_mem_fail from pch_spi_set_tx to code it more cleanly
    - shorten dev_dbg() messages for conciseness and readability

    More cleanups are still needed in this driver. In particular,
    - the driver filename should be changed to spi_topcliff_pch.c
    - many of the dev_dbg() lines should be trimmed (particularly the ones
    on unconditional code paths).
    - I suspect that the locking model not correct. I'd like to know what
    drivers' critical regions are, and how they are protected.
    - get_resources and release_resources probably should be open coded in
    .probe and .release respectively.

    Signed-off-by: Grant Likely

    Grant Likely
     

09 Oct, 2010

1 commit