28 Mar, 2016
2 commits
-
Alignment should match open parenthesis. Checkpatch detected these
issues.Signed-off-by: Laura Garcia Liebana
Signed-off-by: Greg Kroah-Hartman -
Prefer the use of type int instead of int32_t. Checkpatch detected these
issues.Signed-off-by: Laura Garcia Liebana
Signed-off-by: Greg Kroah-Hartman
12 Mar, 2016
9 commits
-
Braces should be used on all arms of the if statement. Checkpatch
detected this issue.Signed-off-by: Laura Garcia Liebana
Signed-off-by: Greg Kroah-Hartman -
Avoid the use of multiple blank lines. Checkpatch detected these issues.
Signed-off-by: Laura Garcia Liebana
Signed-off-by: Greg Kroah-Hartman -
The lines should be adjusted to 80 characters. Checkpatch detected these
issues.Signed-off-by: Laura Garcia Liebana
Signed-off-by: Greg Kroah-Hartman -
Blank lines are not necessary after an open brace. Checkpatch detected
these issues.Signed-off-by: Laura Garcia Liebana
Signed-off-by: Greg Kroah-Hartman -
Remove commented source code. Checkpatch detected these issues.
Signed-off-by: Laura Garcia Liebana
Signed-off-by: Greg Kroah-Hartman -
Comparison to NULL should be avoided in conditions. Chackpatch detected
these issues.Signed-off-by: Laura Garcia Liebana
Signed-off-by: Greg Kroah-Hartman -
Blank line is inserted after a struct declaration. Checkpatch detected
these issues.Signed-off-by: Laura Garcia Liebana
Signed-off-by: Greg Kroah-Hartman -
Logical continuations should be on the previous line. Checkpatch detected this issue.
Signed-off-by: Laura Garcia Liebana
Signed-off-by: Greg Kroah-Hartman -
With conccurency managed workqueues, use of dedicated workqueues can
be replaced by system_wq. Drop cvm_oct_poll_queue by using system_wq.There are multiple work items per cvm_oct_poll_queue (viz.
cvm_oct_rx_refill_work, port_periodic_work) and different
cvm_oct_poll_queues need not be be ordered. Hence, concurrency
can be increased by switching to system_wq.All work items are sync canceled in cvm_oct_remove() so it
is guaranteed that no work is in flight by the time exit path runs.Signed-off-by: Bhaktipriya Shridhar
Acked-by: Tejun Heo
Signed-off-by: Greg Kroah-Hartman
21 Feb, 2016
2 commits
-
This patch fixes "blank lines aren't necessary after an open brace '{'"
checkpatch.pl warning in ethernet.cSigned-off-by: Dilek Uzulmez
Signed-off-by: Greg Kroah-Hartman -
We have only one NAPI poll running at a time, so virtual port rx counters
can be updated normally.Update of rx_dropped can still race with the gathering of statistics,
but full accuracy is not required there.Signed-off-by: Aaro Koskinen
Acked-by: David Daney
Signed-off-by: Greg Kroah-Hartman
15 Feb, 2016
1 commit
-
Support fixed-link PHYs. This allows to remove some of the board-specific
link cvmx_helper code in the future.Signed-off-by: Aaro Koskinen
Signed-off-by: Greg Kroah-Hartman
12 Feb, 2016
2 commits
-
Refactor RGMII 10 Mbps preamble error checking. The current implementation
does not work correctly in phydev mode since only the link status changes
trigger the callback, and if we stay on 10 Mbps operation the periodic
checks for error counters are never done.Provide a periodic worker also during the phydev operation, and notify
the link status changes through the phydev instead of the inband
status change interrupt. This also has the benefit that we don't need
to use legacy CVMX MDIO calls to check the PHY state, and we can avoid
races that trigger bogus "Using 10Mbps with software preamble removal"
logs when interfaces are being bringed up. It also avoids some corner-case
crashes when the in-band interrupt triggers while the interface is
being taken down.Tested on EdgeRouter Lite & D-Link DSR-1000N.
Signed-off-by: Aaro Koskinen
Signed-off-by: Greg Kroah-Hartman -
Add spaces around operators for better readability. Change suggested by
checkpatch.Signed-off-by: Janani Ravichandran
Signed-off-by: Greg Kroah-Hartman
08 Feb, 2016
3 commits
-
Removed blank line after curly braces.
Found using checkpatch.pl.Signed-off-by: Bhumika Goyal
Signed-off-by: Greg Kroah-Hartman -
Only wake tx queue when driver queue is back within bounds.
The logic here was just reenabling the queue when any buffers had been
freed. the queue was stopped whenever the length exceeded 1000
(MAX_OUT_QUEUE_DEPTH), but then was essentially immediately started again.
On a congested link, the queue length would just keep increasing up to
around 8000 (for average size packets), at which point the hardware would
start refusing the packets and they would begin to be dropped.
This prevented the qdisc layer from effectively managing and prioritising
packets, as essentially all packets were being allowed into the driver
queue and then were being dropped by the hardware.This change only restarts the queue if the length is less than 1000
(MAX_OUT_QUEUE_DEPTH).Reviewed-by: Kyeong Yoo
Reviewed-by: Chris Packham
Reviewed-by: Richard Laing
Signed-off-by: Luuk Paulussen
Signed-off-by: Greg Kroah-Hartman -
If the network portion of a frame is preceded by more than 14 bytes of
data, the checksum calculated in the HW is done over the wrong data and
is put in the wrong place.
In our use case an Octeon ethernet controller is connected to a Broadcom
switch chip. Extra data is included in the frame prior to egressing the
Octeon ethernet (i.e. 4 bytes of an 802.1Q tag, 4 bytes of a proprietary
BCM tag later stripped by the switch chip). This extra data causes the
checksum calculation to be incorrect.
The fix in this patch is to make use of the network header offset of the
skb. This enables the checksum to be calculated correctly.
This has been tested in both the configuration with the switch chip in
the egress path (as described above) and in a simple connection direct
to the wire.Reviewed-by: Richard Laing
Reviewed-by: Tim Beale
Reviewed-by: Chris Packham
Signed-off-by: Hamish Martin
Signed-off-by: Greg Kroah-Hartman
14 Jan, 2016
1 commit
-
Pull staging driver updates from Greg KH:
"Here is the big staging driver pull request for 4.5-rc1.Lots of cleanups and fixes here, not as many as some releases, but
800+ isn't that bad. Full details in the shortlog. All of these have
been in linux-next for a while"* tag 'staging-4.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (843 commits)
Revert "arm64: dts: Add dts files to enable ION on Hi6220 SoC."
staging: gdm724x: constify tty_port_operations structs
staging: gdm72xx: add userspace data struct
staging: gdm72xx: Replace timeval with ktime_t
iio: adc: ina2xx: Fix incorrect report of data endianness to userspace.
iio: light: us5182d: Refactor read_raw function
iio: light: us5182d: Add interrupt support and events
iio: light: us5182d: Fix enable status inconcistency
iio: Make IIO value formating function globally available.
staging: emxx_udc: use list_first_entry_or_null()
staging/emxx_udc: fix 64-bit warnings
STAGING: COMEDI: Using kernel types in plx9080.h
STAGING: COMEDI: Added spaces around binary operators in plx9080.h
STAGING: COMEDI: Fixed format of comments in plx9080.h
staging: comedi: comedilib.h: Coding style warning fix for block comments
staging: comedi: s526: add macros for counter control reg values
staging: comedi: s526: replace counter mode bitfield struct
staging: comedi: check for more errors for zero-length write
staging: comedi: simplify returned errors for comedi_write()
staging: comedi: return error on "write" if no command set up
...
11 Jan, 2016
1 commit
-
The mdio device patches moved the bus member in phy_device into a
substructure. This driver got missed. Fix it.Signed-off-by: Andrew Lunn
Signed-off-by: David S. Miller
16 Nov, 2015
1 commit
-
Add space around operator '+'. Problem found using
checkpatch.pl
CHECK: spaces preferred around that '+' (ctx:VxV)Signed-off-by: Burcin Akalin
Signed-off-by: Greg Kroah-Hartman
25 Oct, 2015
3 commits
-
Remove multiple blank lines. Problem found using checkpatch.pl
"CHECK: Please don't use multiple blank lines".Signed-off-by: Burcin Akalin
Signed-off-by: Greg Kroah-Hartman -
Remove the explicit NULL comparison and rewrite in a compact form.
Signed-off-by: Muhammad Falak R Wani
Signed-off-by: Greg Kroah-Hartman -
Remove the explicit NULL comparison and rewrite in a compact form.
Signed-off-by: Muhammad Falak R Wani
Signed-off-by: Greg Kroah-Hartman
18 Oct, 2015
3 commits
-
cvm_oct_xaui_open() is trivial and does not need a dedicated file.
Move it to the main file.Signed-off-by: Aaro Koskinen
Signed-off-by: Greg Kroah-Hartman -
Drop redundant poll_now parameter from cvm_oct_common_open.
Signed-off-by: Aaro Koskinen
Signed-off-by: Greg Kroah-Hartman -
Get the initial link status already on open instead of postponing
it to the periodic poll task. This unifies the behaviour with
other interfaces types.Signed-off-by: Aaro Koskinen
Signed-off-by: Greg Kroah-Hartman
13 Oct, 2015
5 commits
-
Use common init.
Signed-off-by: Aaro Koskinen
Signed-off-by: Greg Kroah-Hartman -
Link status poll function is already controlled by open/stop functions,
so we don't need to do it on init.This eliminates a redundant xaui link status notification when the module
is loaded.Signed-off-by: Aaro Koskinen
Signed-off-by: Greg Kroah-Hartman -
Fix kernel-doc 'Excess function parameter' by moving
the description to the correct location. Also corrected
parameter descriptionSigned-off-by: Cristina Moraru
Signed-off-by: Greg Kroah-Hartman -
Fix kernel-doc warnings 'cannot understand function prototype'
by removing /** from regular commentsSigned-off-by: Cristina Moraru
Signed-off-by: Greg Kroah-Hartman -
Fix 'bad line' kernel-doc warning
Signed-off-by: Cristina Moraru
Signed-off-by: Greg Kroah-Hartman
04 Oct, 2015
1 commit
-
Fix 'No description found for parameter' kernel-doc warnings
Signed-off-by: Cristina Moraru
Signed-off-by: Greg Kroah-Hartman
02 Oct, 2015
1 commit
-
This patch "uint*_t" type instead of "u*" type was used.
checkpatch.pl issue in octeon driver.Signed-off-by: Aybuke Ozdemir
Reviewed-by: Arnd Bergmann
Signed-off-by: Greg Kroah-Hartman
04 Sep, 2015
1 commit
-
Pull MIPS updates from Ralf Baechle:
"This is the main pull request for 4.3 for MIPS. Here's the summary:Three fixes that didn't make 4.2-stable:
- a -Os build might compile the kernel using the MIPS16 instruction
set but the R2 optimized inline functions in are
implemented using 32-bit wide instructions which is invalid.- a build error in pgtable-bits.h for a particular kernel
configuration.- accessing registers of the CM GCR might have been compiled to use
64 bit accesses but these registers are onl 32 bit wide.And also a few new bits:
- move the ATH79 GPIO driver to drivers/gpio
- the definition of IRQCHIP_DECLARE has moved to linux/irqchip.h,
change ATH79 accordingly.- fix definition of pgprot_writecombine
- add an implementation of dma_map_ops.mmap
- fix alignment of quiet build output for vmlinuz link
- BCM47xx: Use kmemdup rather than duplicating its implementation
- Netlogic: Fix 0x0x prefixes of constants.
- merge Bjorn Helgaas' series to remove most of the weak keywords
from function declarations.- CP0 and CP1 registers are best considered treated as unsigned
values to avoid large values from becoming negative values.- improve support for the MIPS GIC timer.
- enable common clock framework for Malta and SEAD3.
- a number of improvments and fixes to dump_tlb().
- document the MIPS TLB dump functionality in Magic SysRq.
- Cavium Octeon CN68XX improvments.
- NetLogic improvments.
- irq: Use access helper irq_data_get_affinity_mask.
- handle MSA unaligned accesses.
- a number of R6-related math-emu fixes.
- support for I6400.
- improvments to MSA support.
- add uprobes support.
- move from deprecated __initcall to arch_initcall.
- remove finish_arch_switch().
- IRQ cleanups by Thomas Gleixner.
- migrate to new 'set-state' interface.
- random small cleanups"
* 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus: (148 commits)
MIPS: UAPI: Fix unrecognized opcode WSBH/DSBH/DSHD when using MIPS16.
MIPS: Fix alignment of quiet build output for vmlinuz link
MIPS: math-emu: Remove unused handle_dsemul function declaration
MIPS: math-emu: Add support for the MIPS R6 MAX{, A} FPU instruction
MIPS: math-emu: Add support for the MIPS R6 MIN{, A} FPU instruction
MIPS: math-emu: Add support for the MIPS R6 CLASS FPU instruction
MIPS: math-emu: Add support for the MIPS R6 RINT FPU instruction
MIPS: math-emu: Add support for the MIPS R6 MSUBF FPU instruction
MIPS: math-emu: Add support for the MIPS R6 MADDF FPU instruction
MIPS: math-emu: Add support for the MIPS R6 SELNEZ FPU instruction
MIPS: math-emu: Add support for the MIPS R6 SELEQZ FPU instruction
MIPS: math-emu: Add support for the CMP.condn.fmt R6 instruction
MIPS: inst.h: Add new MIPS R6 FPU opcodes
MIPS: Octeon: Fix management port MII address on Kontron S1901
MIPS: BCM47xx: Use kmemdup rather than duplicating its implementation
STAGING: Octeon: Use common helpers for determining interface and port
MIPS: Octeon: Support interfaces 4 and 5
MIPS: Octeon: Set up 1:1 mapping between CN68XX PKO queues and ports
MIPS: Octeon: Initialize CN68XX PKO
STAGING: Octeon: Support CN68XX style WQE
...
03 Sep, 2015
4 commits
-
Currently the Octeon Ethernet driver hardcodes the mapping between
interface/port and IPD port number. Since we have generic helpers for
the very same purpose, we might as well use them instead. This prevents
having the same information in multiple places.Signed-off-by: Janne Huttunen
Signed-off-by: Aaro Koskinen
Acked-by: David Daney
Cc: David Daney
Cc: linux-mips@linux-mips.org
Cc: Janne Huttunen
Cc: Aaro Koskinen
Cc: Greg Kroah-Hartman
Cc: devel@driverdev.osuosl.org
Patchwork: https://patchwork.linux-mips.org/patch/10975/
Signed-off-by: Ralf Baechle -
CN68XX has a bit different WQE structure. This patch provides the new
definitions and converts the code to use the proper variant based on
the actual model.Signed-off-by: Janne Huttunen
Signed-off-by: Aaro Koskinen
Acked-by: David Daney
Cc: David Daney
Cc: linux-mips@linux-mips.org
Cc: Janne Huttunen
Cc: Aaro Koskinen
Cc: Greg Kroah-Hartman
Cc: devel@driverdev.osuosl.org
Patchwork: https://patchwork.linux-mips.org/patch/10973/
Signed-off-by: Ralf Baechle -
The Octeon II models have more interfaces and thus require more output
command buffers. Increase the allocation to support these models.Signed-off-by: Janne Huttunen
Signed-off-by: Aaro Koskinen
Acked-by: David Daney
Cc: David Daney
Cc: linux-mips@linux-mips.org
Cc: Janne Huttunen
Cc: Aaro Koskinen
Cc: Greg Kroah-Hartman
Cc: devel@driverdev.osuosl.org
Patchwork: https://patchwork.linux-mips.org/patch/10965/
Signed-off-by: Ralf Baechle -
CN68XX uses SSO instead of POW.
Signed-off-by: Aaro Koskinen
Acked-by: David Daney
Cc: David Daney
Cc: linux-mips@linux-mips.org
Cc: Janne Huttunen
Cc: Aaro Koskinen
Cc: Greg Kroah-Hartman
Cc: devel@driverdev.osuosl.org
Patchwork: https://patchwork.linux-mips.org/patch/10966/
Signed-off-by: Ralf Baechle