22 May, 2020

2 commits


14 Mar, 2020

1 commit


21 Nov, 2019

1 commit


21 May, 2019

1 commit

  • Add SPDX license identifiers to all files which:

    - Have no license information of any form

    - Have MODULE_LICENCE("GPL*") inside which was used in the initial
    scan/conversion to ignore the file

    These files fall under the project license, GPL v2 only. The resulting SPDX
    license identifier is:

    GPL-2.0-only

    Signed-off-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

01 Oct, 2018

1 commit

  • Currently, "disable_clkrun" yenta_socket module parameter is only
    implemented for TI CardBus bridges.
    Add also an implementation for Ricoh bridges that have the necessary
    setting documented in publicly available datasheets.

    Tested on a RL5C476II with a Sunrich C-160 CardBus NIC that doesn't work
    correctly unless the CLKRUN protocol is disabled.

    Let's also make it clear in its description that the "disable_clkrun"
    module parameter only works on these two previously mentioned brands of
    CardBus bridges.

    Signed-off-by: Maciej S. Szmigiero
    Cc: stable@vger.kernel.org
    Signed-off-by: Dominik Brodowski

    Maciej S. Szmigiero
     

03 Nov, 2017

1 commit

  • In preparation for unconditionally passing the struct timer_list pointer to
    all timer callbacks, switch to using the new timer_setup() and from_timer()
    to pass the timer pointer explicitly.

    Cc: Florian Fainelli
    Cc: bcm-kernel-feedback-list@broadcom.com
    Cc: David Howells
    Cc: Arnd Bergmann
    Cc: linux-pcmcia@lists.infradead.org
    Cc: linux-arm-kernel@lists.infradead.org
    Signed-off-by: Kees Cook
    Acked-by: Russell King # for soc_common.c

    Kees Cook
     

15 Jun, 2015

1 commit

  • There are some resource leaks in yenta_probe() and _close(). I fixed
    the following issues with some code cleanups. Thanks to Dominik's
    suggestions.

    On the error path in yenta_probe():
    - a requested irq is not released
    - yenta_free_resources() and pci_set_drvdata(dev, NULL) are not called

    In yenta_close():
    - kfree(sock) is not called
    - sock->base is always set to non-NULL when yenta_close() is called,
    therefore the check in yenta_close() is not necessary.

    Signed-off-by: Takeshi Yoshimura
    Signed-off-by: Dominik Brodowski

    Takeshi Yoshimura
     

30 May, 2015

1 commit

  • Reduce object size a little by using dev_
    calls instead of dev_printk(KERN_.

    Other miscellanea:

    o Coalesce formats
    o Realign arguments
    o Use pr_cont instead of naked printk
    reorder test to use "%s\n"

    Signed-off-by: Joe Perches
    Signed-off-by: Dominik Brodowski

    Joe Perches
     

17 Mar, 2015

1 commit

  • This patch introduces the use of functions setup_timer
    and mod_timer.

    This is done using Coccinelle and semantic patch used
    for this as follows:

    //
    @@
    expression x,y,z,a,b;
    @@

    -init_timer (&x);
    +setup_timer (&x, y, z);
    +mod_timer (&a, b);
    -x.function = y;
    -x.data = z;
    -x.expires = b;
    -add_timer(&a);

    //

    Signed-off-by: Vaishali Thakkar
    Signed-off-by: Greg Kroah-Hartman

    Vaishali Thakkar
     

19 Jul, 2014

1 commit


15 Feb, 2014

1 commit


22 Dec, 2013

1 commit

  • These interfaces:

    pcibios_resource_to_bus(struct pci_dev *dev, *bus_region, *resource)
    pcibios_bus_to_resource(struct pci_dev *dev, *resource, *bus_region)

    took a pci_dev, but they really depend only on the pci_bus. And we want to
    use them in resource allocation paths where we have the bus but not a
    device, so this patch converts them to take the pci_bus instead of the
    pci_dev:

    pcibios_resource_to_bus(struct pci_bus *bus, *bus_region, *resource)
    pcibios_bus_to_resource(struct pci_bus *bus, *resource, *bus_region)

    In fact, with standard PCI-PCI bridges, they only depend on the host
    bridge, because that's the only place address translation occurs, but
    we aren't going that far yet.

    [bhelgaas: changelog]
    Signed-off-by: Yinghai Lu
    Signed-off-by: Bjorn Helgaas

    Yinghai Lu
     

26 Sep, 2013

1 commit


29 Nov, 2012

3 commits


14 Jun, 2012

1 commit


03 Mar, 2012

1 commit


13 Jan, 2012

1 commit


25 Oct, 2010

1 commit

  • * 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (39 commits)
    Update broken web addresses in arch directory.
    Update broken web addresses in the kernel.
    Revert "drivers/usb: Remove unnecessary return's from void functions" for musb gadget
    Revert "Fix typo: configuation => configuration" partially
    ida: document IDA_BITMAP_LONGS calculation
    ext2: fix a typo on comment in ext2/inode.c
    drivers/scsi: Remove unnecessary casts of private_data
    drivers/s390: Remove unnecessary casts of private_data
    net/sunrpc/rpc_pipe.c: Remove unnecessary casts of private_data
    drivers/infiniband: Remove unnecessary casts of private_data
    drivers/gpu/drm: Remove unnecessary casts of private_data
    kernel/pm_qos_params.c: Remove unnecessary casts of private_data
    fs/ecryptfs: Remove unnecessary casts of private_data
    fs/seq_file.c: Remove unnecessary casts of private_data
    arm: uengine.c: remove C99 comments
    arm: scoop.c: remove C99 comments
    Fix typo configue => configure in comments
    Fix typo: configuation => configuration
    Fix typo interrest[ing|ed] => interest[ing|ed]
    Fix various typos of valid in comments
    ...

    Fix up trivial conflicts in:
    drivers/char/ipmi/ipmi_si_intf.c
    drivers/usb/gadget/rndis.c
    net/irda/irnet/irnet_ppp.c

    Linus Torvalds
     

18 Oct, 2010

1 commit

  • The patch below updates broken web addresses in the kernel

    Signed-off-by: Justin P. Mattock
    Cc: Maciej W. Rozycki
    Cc: Geert Uytterhoeven
    Cc: Finn Thain
    Cc: Randy Dunlap
    Cc: Matt Turner
    Cc: Dimitry Torokhov
    Cc: Mike Frysinger
    Acked-by: Ben Pfaff
    Acked-by: Hans J. Koch
    Reviewed-by: Finn Thain
    Signed-off-by: Jiri Kosina

    Justin P. Mattock
     

29 Sep, 2010

1 commit

  • pcmcia_enable_device() now replaces pcmcia_request_configuration().
    Instead of config_req_t, all necessary flags are either passed as
    a parameter to pcmcia_enable_device(), or (in rare circumstances)
    set in struct pcmcia_device -> flags.

    With the last remaining user of include/pcmcia/cs.h gone, remove
    all references.

    CC: netdev@vger.kernel.org
    CC: linux-wireless@vger.kernel.org
    CC: linux-ide@vger.kernel.org
    CC: linux-usb@vger.kernel.org
    CC: laforge@gnumonks.org
    CC: linux-mtd@lists.infradead.org
    CC: alsa-devel@alsa-project.org
    CC: linux-serial@vger.kernel.org
    CC: Jiri Kosina
    CC: linux-scsi@vger.kernel.org
    Acked-by: Gustavo F. Padovan (for drivers/bluetooth)
    Tested-by: Wolfram Sang
    Signed-off-by: Dominik Brodowski

    Dominik Brodowski
     

31 Jul, 2010

1 commit

  • Remove cs_types.h which is no longer needed: Most definitions aren't
    used at all, a few can be made away with, and two remaining definitions
    (typedefs, unfortunatley) may be moved to more specific places.

    CC: linux-ide@vger.kernel.org
    CC: linux-usb@vger.kernel.org
    CC: laforge@gnumonks.org
    CC: linux-mtd@lists.infradead.org
    CC: alsa-devel@alsa-project.org
    CC: linux-serial@vger.kernel.org
    Acked-by: Marcel Holtmann (for drivers/bluetooth/)
    Acked-by: David S. Miller
    Signed-off-by: Dominik Brodowski

    Dominik Brodowski
     

08 Jun, 2010

2 commits


10 May, 2010

1 commit


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

24 Mar, 2010

1 commit

  • Instead of requiring PCMCIA socket drivers to call various functions
    during their (bus) resume and suspend functions, register an own
    dev_pm_ops for this class. This fixes several suspend/resume bugs
    seen on db1xxx-ss, and probably on some other socket drivers, too.

    With regard to the asymmetry with only _noirq suspend, but split up
    resume, please see bug 14334 and commit 9905d1b411946fb3 .

    Signed-off-by: Dominik Brodowski

    Dominik Brodowski
     

15 Mar, 2010

3 commits

  • As the PCI irq pin of the ti1130 pcmcia bridge is not connected (at
    least on some old IBM Thinkpad 760ED notebooks), the Cardbus IRQ has
    to be routed to an ISA irq.

    Part 3 of a series to allow the ISA irq to be used for Cardbus devices
    if the socket's PCI irq is unusable.

    [linux@dominikbrodowski.net: split up the original patch, commit message,
    cleanup]

    Signed-off-by: Jens Kuenzer
    Signed-off-by: Dominik Brodowski

    Jens Künzer
     
  • cb_irq is presumed to be the same as the pci_dev's irq. This won't be
    true any more as soon as we allow the ISA irq to be used for Cardbus
    devices. Therefore, use the pci_dev's irq explicitely whenever we
    care about it.

    Part 2 of a series to allow the ISA irq to be used for Cardbus devices
    if the socket's PCI irq is unusable.

    [linux@dominikbrodowski.net: split up the original patch, commit message]

    Signed-off-by: Jens Kuenzer
    Signed-off-by: Dominik Brodowski

    Jens Künzer
     
  • Instead of overwriting the I365_CSCINT register, save the old value and
    merely change the bits we care about.

    Part 1 of a series to allow the ISA irq to be used for Cardbus devices
    if the socket's PCI irq is unusable.

    [linux@dominikbrodowski.net: split up the original patch, commit message]

    Signed-off-by: Jens Kuenzer
    Signed-off-by: Dominik Brodowski

    Jens Künzer
     

03 Mar, 2010

1 commit

  • Indigos are well known for distortions when running on some buggy ENE
    controllers. There is a workaround in the yenta driver, but for some
    reason it isn't activated on CB712. However, I own a laptop with such
    chip and it seems that it also is affected - I can clearly hear occasional
    cracks, especially under heavy network load, and in Windows XP the card is
    completely unusable.

    This simple change fixed things for me.

    Addresses http://bugzilla.kernel.org/show_bug.cgi?id=15191

    [linux@dominikbrodowski.net: extend it to the other ENE bridges]
    Signed-off-by: Michal Pecio
    Signed-off-by: Andrew Morton
    Signed-off-by: Dominik Brodowski

    Michal Pecio
     

28 Feb, 2010

1 commit

  • * git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6: (49 commits)
    pcmcia: validate late-added resources
    pcmcia: allow for extension of resource interval
    pcmcia: remove useless msleep in ds.c
    pcmcia: use read_cis_mem return value
    pcmcia: handle error in serial_cs config calls
    pcmcia: add locking to pcmcia_{read,write}_cis_mem
    pcmcia: avoid prod_id memleak
    pcmcia: avoid sysfs-related lockup for cardbus
    pcmcia: use state machine for extended requery
    pcmcia: delay re-scanning and re-querying of PCMCIA bus
    pcmcia: use pccardd to handle eject, insert, suspend and resume requests
    pcmcia: use ops_mutex for rsrc_{mgr,nonstatic} locking
    pcmcia: use mutex for dynid lock
    pcmcia: assert locking to struct pcmcia_device
    pcmcia: add locking documentation
    pcmcia: simplify locking
    pcmcia: add locking to struct pcmcia_socket->pcmcia_state()
    pcmcia: protect s->device_count
    pcmcia: properly lock skt->irq, skt->irq_mask
    pcmcia: lock ops->set_socket
    ...

    Linus Torvalds
     

24 Feb, 2010

1 commit


18 Feb, 2010

1 commit

  • O2-bridges can do read prefetch and write burst. However, for some combinations
    of older bridges and cards, this causes problems, so it is disabled for those
    bridges. Now, as some users know their setup works with the speedups enabled, a
    new parameter is introduced to the driver. Now, a user can specifically enable
    or disable these features, while the default is what we have today: detect the
    bridge and decide accordingly. Fixes Bugzilla entry 15014.

    Simplify and unify the printouts, fix a whitespace issue while we are here.

    Signed-off-by: Wolfram Sang
    Tested-by: frodone@gmail.com
    [linux@dominikbrodowski.net: whitespace fixes]
    Signed-off-by: Dominik Brodowski

    Wolfram Sang
     

16 Dec, 2009

1 commit


08 Dec, 2009

1 commit

  • Fix several CodingStyle issues in drivers/pcmcia/ . checkpatch.pl no longer
    reports errors in the PCMCIA core. The remaining warnings mostly relate to
    wrong indent -- PCMCIA historically used 4 spaces --, to lines over 80
    characters and to hundreds of typedefs. The cleanup of those will follow
    in the future.

    Signed-off-by: Dominik Brodowski

    Dominik Brodowski
     

03 Nov, 2009

1 commit

  • Commit 0c570cdeb8fdfcb354a3e9cd81bfc6a09c19de0c
    (PM / yenta: Fix cardbus suspend/resume regression) caused resume to
    fail on systems with two CardBus bridges. While the exact nature
    of the failure is not known at the moment, it can be worked around by
    splitting the yenta resume into an early part, executed during the
    early phase of resume, that will only resume the socket and power it
    up if there was a card in it during suspend, and a late part,
    executed during "regular" resume, that will carry out all of the
    remaining yenta resume operations.

    Fixes http://bugzilla.kernel.org/show_bug.cgi?id=14334, which is a
    listed regression from 2.6.31.

    Signed-off-by: Rafael J. Wysocki
    Acked-by: Dominik Brodowski
    Reported-by: Stephen J. Gowdy
    Tested-by: Jose Marino

    Rafael J. Wysocki
     

29 Sep, 2009

1 commit

  • Since 2.6.29 the PCI PM core have been restoring the standard
    configuration registers of PCI devices in the early phase of
    resume. In particular, PCI devices without drivers have been handled
    this way since commit 355a72d75b3b4f4877db4c9070c798238028ecb5
    (PCI: Rework default handling of suspend and resume). Unfortunately,
    this leads to post-resume problems with CardBus devices which cannot
    be accessed in the early phase of resume, because the sockets they
    are on have not been woken up yet at that point.

    To solve this problem, move the yenta socket resume to the early
    phase of resume and, analogously, move the suspend of it to the late
    phase of suspend. Additionally, remove some unnecessary PCI code
    from the yenta socket's resume routine.

    Fixes http://bugzilla.kernel.org/show_bug.cgi?id=13092, which is a
    post-2.6.28 regression.

    Signed-off-by: Rafael J. Wysocki
    Reported-by: Florian
    Cc: stable@kernel.org

    Rafael J. Wysocki