Eric Lee / smarc-fsl-linux-kernel

14 Jul, 2020

1 commit

17 Mar, 2020

1 commit

09 Jul, 2019

1 commit

  • c8320ccdd   nfsd: Fix misuse of strlcpy ... Browse Code »

    Probable cut&paste typo - use the correct field size.

    (Not currently a practical problem since these two fields have the same
    size, but we should fix it anyway.)

    Signed-off-by: Joe Perches
    Signed-off-by: J. Bruce Fields

    Joe Perches
     

24 Apr, 2019

1 commit

30 Oct, 2018

1 commit

28 Nov, 2017

1 commit

18 Feb, 2017

1 commit

  • c3821b349   nfsd/idmap: return nfserr_inval for 0-length names ... Browse Code »

    Tigran Mkrtchyan's new pynfs testcases for zero length principals fail:

    SATT16 st_setattr.testEmptyPrincipal : FAILURE
    Setting empty owner should return NFS4ERR_INVAL,
    instead got NFS4ERR_BADOWNER
    SATT17 st_setattr.testEmptyGroupPrincipal : FAILURE
    Setting empty owner_group should return NFS4ERR_INVAL,
    instead got NFS4ERR_BADOWNER

    This patch checks the principal and returns nfserr_inval directly. It
    could check after decoding in nfs4xdr.c, but it's simpler to do it in
    nfsd_map_xxxx.

    Signed-off-by: Kinglong Mee
    Signed-off-by: J. Bruce Fields

    Kinglong Mee
     

21 Jul, 2015

1 commit

04 Sep, 2014

2 commits

29 May, 2014

1 commit

  • ddd1ea563   nfsd4: use xdr_reserve_space in attribute encoding ... Browse Code »

    This is a cosmetic change for now; no change in behavior.

    Note we're just depending on xdr_reserve_space to do the bounds checking
    for us, we're not really depending on its adjustment of iovec or xdr_buf
    lengths yet, as those are fixed up by as necessary after the fact by
    read-link operations and by nfs4svc_encode_compoundres. However we do
    have to update xdr->iov on read-like operations to prevent
    xdr_reserve_space from messing with the already-fixed-up length of the
    the head.

    When the attribute encoding fails partway through we have to undo the
    length adjustments made so far. We do it manually for now, but later
    patches will add an xdr_truncate_encode() helper to handle cases like
    this.

    Signed-off-by: J. Bruce Fields

    J. Bruce Fields
     

09 Jan, 2014

1 commit

01 Mar, 2013

1 commit

  • b6669737d   Merge branch 'for-3.9' of git://linux-nfs.org/~bfields/linux ... Browse Code »

    Pull nfsd changes from J Bruce Fields:
    "Miscellaneous bugfixes, plus:

    - An overhaul of the DRC cache by Jeff Layton. The main effect is
    just to make it larger. This decreases the chances of intermittent
    errors especially in the UDP case. But we'll need to watch for any
    reports of performance regressions.

    - Containerized nfsd: with some limitations, we now support
    per-container nfs-service, thanks to extensive work from Stanislav
    Kinsbursky over the last year."

    Some notes about conflicts, since there were *two* non-data semantic
    conflicts here:

    - idr_remove_all() had been added by a memory leak fix, but has since
    become deprecated since idr_destroy() does it for us now.

    - xs_local_connect() had been added by this branch to make AF_LOCAL
    connections be synchronous, but in the meantime Trond had changed the
    calling convention in order to avoid a RCU dereference.

    There were a couple of more obvious actual source-level conflicts due to
    the hlist traversal changes and one just due to code changes next to
    each other, but those were trivial.

    * 'for-3.9' of git://linux-nfs.org/~bfields/linux: (49 commits)
    SUNRPC: make AF_LOCAL connect synchronous
    nfsd: fix compiler warning about ambiguous types in nfsd_cache_csum
    svcrpc: fix rpc server shutdown races
    svcrpc: make svc_age_temp_xprts enqueue under sv_lock
    lockd: nlmclnt_reclaim(): avoid stack overflow
    nfsd: enable NFSv4 state in containers
    nfsd: disable usermode helper client tracker in container
    nfsd: use proper net while reading "exports" file
    nfsd: containerize NFSd filesystem
    nfsd: fix comments on nfsd_cache_lookup
    SUNRPC: move cache_detail->cache_request callback call to cache_read()
    SUNRPC: remove "cache_request" argument in sunrpc_cache_pipe_upcall() function
    SUNRPC: rework cache upcall logic
    SUNRPC: introduce cache_detail->cache_request callback
    NFS: simplify and clean cache library
    NFS: use SUNRPC cache creation and destruction helper for DNS cache
    nfsd4: free_stid can be static
    nfsd: keep a checksum of the first 256 bytes of request
    sunrpc: trim off trailing checksum before returning decrypted or integrity authenticated buffer
    sunrpc: fix comment in struct xdr_buf definition
    ...

    Linus Torvalds
     

15 Feb, 2013

2 commits

  • 2d4383383   SUNRPC: rework cache upcall logic ... Browse Code »

    For most of SUNRPC caches (except NFS DNS cache) cache_detail->cache_upcall is
    redundant since all that it's implementations are doing is calling
    sunrpc_cache_pipe_upcall() with proper function address argument.
    Cache request function address is now stored on cache_detail structure and
    thus all the code can be simplified.
    Now, for those cache details, which doesn't have cache_upcall callback (the
    only one, which still has is nfs_dns_resolve_template)
    sunrpc_cache_pipe_upcall will be called instead.

    Signed-off-by: Stanislav Kinsbursky
    Signed-off-by: J. Bruce Fields

    Stanislav Kinsbursky
     
  • 73fb847a4   SUNRPC: introduce cache_detail->cache_request callback ... Browse Code »

    This callback will allow to simplify upcalls in further patches in this
    series.

    Signed-off-by: Stanislav Kinsbursky
    Signed-off-by: J. Bruce Fields

    Stanislav Kinsbursky
     

13 Feb, 2013

2 commits

11 Sep, 2012

2 commits

28 Jul, 2012

1 commit

01 Jun, 2012

1 commit

12 Apr, 2012

4 commits

28 Mar, 2012

1 commit

26 Mar, 2012

1 commit

  • e9541ce8e   nfsd4: allow numeric idmapping ... Browse Code »

    Mimic the client side by providing a module parameter that turns off
    idmapping in the auth_sys case, for backwards compatibility with NFSv2
    and NFSv3.

    Unlike in the client case, we don't have any way to negotiate, since the
    client can return an error to us if it doesn't like the id that we
    return to it in (for example) a getattr call.

    However, it has always been possible for servers to return numeric id's,
    and as far as we're aware clients have always been able to handle them.

    Also, in the auth_sys case clients already need to have numeric id's the
    same between client and server.

    Therefore we believe it's safe to default this to on; but the module
    parameter is available to return to previous behavior if this proves to
    be a problem in some unexpected setup.

    Signed-off-by: J. Bruce Fields

    J. Bruce Fields
     

08 Dec, 2011

1 commit

08 Mar, 2011

1 commit

05 Jan, 2011

3 commits

22 Sep, 2010

1 commit

08 Sep, 2010

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

16 Dec, 2009

1 commit

15 Dec, 2009

1 commit

  • 341eb1844   nfsd: Source files #include cleanups ... Browse Code »

    Now that the headers are fixed and carry their own wait, all fs/nfsd/
    source files can include a minimal set of headers. and still compile just
    fine.

    This patch should improve the compilation speed of the nfsd module.

    Signed-off-by: Boaz Harrosh
    Signed-off-by: J. Bruce Fields

    Boaz Harrosh
     

24 Sep, 2009

1 commit

  • 2bcd57ab6   headers: utsname.h redux ... Browse Code »

    * remove asm/atomic.h inclusion from linux/utsname.h --
    not needed after kref conversion
    * remove linux/utsname.h inclusion from files which do not need it

    NOTE: it looks like fs/binfmt_elf.c do not need utsname.h, however
    due to some personality stuff it _is_ needed -- cowardly leave ELF-related
    headers and files alone.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Linus Torvalds

    Alexey Dobriyan
     

10 Aug, 2009

2 commits