02 Aug, 2011
2 commits
-
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/lrg/voltage-2.6: (23 commits)
regulator: Improve WM831x DVS VSEL selection algorithm
regulator: Bootstrap wm831x DVS VSEL value from ON VSEL if not already set
regulator: Set up GPIO for WM831x VSEL before enabling VSEL mode
regulator: Add EPEs to the MODULE_ALIAS() for wm831x-dcdc
regulator: Fix WM831x DCDC DVS VSEL bootstrapping
regulator: Fix WM831x regulator ID lookups for multiple WM831xs
regulator: Fix argument format type errors in error prints
regulator: Fix memory leak in set_machine_constraints() error paths
regulator: Make core more chatty about some errors
regulator: tps65910: Fix array access out of bounds bug
regulator: tps65910: Add missing breaks in switch/case
regulator: tps65910: Fix a memory leak in tps65910_probe error path
regulator: TWL: Remove entry of RES_ID for 6030 macros
ASoC: tlv320aic3x: Add correct hw registers to Line1 cross connect muxes
regulator: Add basic per consumer debugfs
regulator: Add rdev_crit() macro
regulator: Refactor supply implementation to work as regular consumers
regulator: Include the device name in the microamps_requested_ file
regulator: Increase the limit on sysfs file names
regulator: Properly register dummy regulator driver
...
01 Aug, 2011
3 commits
-
get_ctrl_reg() returns -EINVAL so the error handling won't work here
if reg is a u8.Signed-off-by: Dan Carpenter
Signed-off-by: Samuel Ortiz -
Add regulator driver for AnalogicTech AAT2870.
Signed-off-by: Jin Park
Acked-by: Mark Brown
Signed-off-by: Samuel Ortiz -
The tps65912 consist of 4 DCDCs and 10 LDOs. The output voltages can be
configured by the SPI or I2C interface, they are meant to supply power
to the main processor and other components.Signed-off-by: Margarita Olaya Cabrera
Acked-by: Mark Brown
Acked-by: Liam Girdwood
Signed-off-by: Samuel Ortiz
28 Jul, 2011
6 commits
-
Rather than using the maximum voltage we get passed to select the DVS
voltage to use remember the highest voltage we've ever seen. This improves
how the driver works when the consumer permits higher voltages than it
will ever selects in order to support the widest possible voltage range.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
If we don't have a DVS VSEL value already set when we start up then start
it off with the value currently being used for ON.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
If the VSEL is not in use prior to us starting up then we need to make
sure we initialise the GPIO before we push the DVS control to being done
by the GPIO.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
Read our initial VSEL from the correct register.
Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
With multiple wm831x devices the device IDs used for the regulators will
not always be contiguous so simply taking the modulus is not sufficient
to look up the ID, we need to reverse the way the ID is generated.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood
23 Jul, 2011
1 commit
-
Signed-off-by: Mark Brown
Acked-by: Liam Girdwood
Acked-by: Grant Likely
22 Jul, 2011
7 commits
-
We need to dereference the pointers to print their values.
Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
Properly kfree rdev->constraints in all set_machine_constraints() error paths.
Also properly kfree rdev->constraints in regulator_register() error paths.Signed-off-by: Axel Lin
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
Prevent some head scratching by making the core log about some rare but
possible errors with invalid voltage ranges and modes being set.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
For tps65910, the number of regulator is 13. ( ARRAY_SIZE(tps65910_regs) is 13)
For tps65911, the number of regulator is 12. ( ARRAY_SIZE(tps65911_regs) is 12)
If we are using this driver for tps65911,
we hit array access out of bounds bug in tps65910_probe() because
current implementation always assume the number of regulator is 13 and
thus it will access tps65911_regs[12].Fix it by setting correct num_regulators for both chips in tps65910_probe(),
and allocated neccessay memory accordingly.Signed-off-by: Axel Lin
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
Also add a default case in tps65910_list_voltage_dcdc to silence
'volt' may be used uninitialized in this function warning.Signed-off-by: Axel Lin
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
Fix a memory leak if chip id is not matched.
Signed-off-by: Axel Lin
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
RES_ID is only used in 4030, to send PBM singular message to control
the state of dedicated resources. In 6030, we don't have concept of PBM,
hence removing the definition of RES_ID (num) from macros.Signed-off-by: Ambresh K
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood
09 Jul, 2011
5 commits
-
The ramp_delay variable can be set lower than the desired value.
This patch fixes it.Signed-off-by: Donggeun Kim
Signed-off-by: MyungJoo Ham
Signed-off-by: KyungMin Park
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
Small cleanups for better readability.
Signed-off-by: Axel Lin
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
The platform_data (pdata) may be pointing to __initdata section, which
may be free'd from the memory. The dependency on pdata in non-init
functions is removed in this patch to allow platform to declare
__initdata for platform data.Signed-off-by: MyungJoo Ham
Signed-off-by: Kyungmin Park
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
Currently, ramp_delay variable is used uninitialzed in
max8997_set_voltage_ldobuck which gets called through
regulator_register calls.To fix the problem, in max8997_pmic_probe, ramp_delay initialization
code is moved before calls to regulator_register.Cc: Liam Girdwood
Cc: Mark Brown
Cc: MyungJoo Ham
Cc: Kyungmin Park
Cc: Samuel Ortiz
Signed-off-by: Tushar Behera
Acked-by: MyungJoo Ham
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
Signed-off-by: Jonghwan Choi
Acked-by: MyungJoo Ham
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood
05 Jul, 2011
1 commit
-
Report the requested load and voltage for each consumer in debugfs when it
is enabled.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood
10 Jun, 2011
4 commits
-
No actual users but provide the macro so there's less surprise when it's
not there.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
Currently the regulator supply implementation is somewhat complex and
fragile as it doesn't look like standard consumers but is instead a
parallel implementation. This causes issues with locking and reference
counting.Move the implementation over to using standard consumers to address this.
Rather than only notifying the supply on the first enable/disable we do so
every time the regulator is enabled or disabled, simplifying locking as we
don't need to hold a lock on the consumer we are about to enable.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
We may have multiple devices requesting a supply with the same name so
include the device name in the generated filename for microamps_requested
to avoid duplicate files.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
With verbose filenames we can easily hit 32 characters.
Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood
09 Jun, 2011
1 commit
-
Recent changes in the driver core appear to mean that the data structures
for the driver core are not fully initialised unless the driver is bound.
Make sure the driver core knows the dummy driver is in use by binding it
to a driver.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood
30 May, 2011
3 commits
-
The n_voltages initializer for the TWL6030_ADJUSTABLE_LDO macro is
off by one, causing the the highest supported voltage to be
unreachable. Setting the machine constraints to only allow the
highest voltage causes errors:machine_constraints_voltage: VAUX3_6030: unsupportable voltage constraints
twl_reg twl_reg.39: can't register VAUX3_6030, -22
twl_reg: probe of twl_reg.39 failed with error -22This patch fixes the off by one error. Tested by setting
VAUX3_6030 to 3.3V.Signed-off-by: Colin Cross
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
The WM8994 regulator driver is perfectly happy if the GPIO used to enable
the regulator sleeps so call the appropriate GPIO API.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood -
In order to reduce the impact of ramp times rather than enabling the
regulators for a device in series use async tasks to run the actual
enables. This means that the delays which the enables implement can all
run in parallel, though it does mean that the order in which the
supplies come on may be unstable.For super bonus fun points if any of the regulators are shared between
multiple supplies on the same device (as is rather likely) then this
will test our locking. Note that in this case we only delay once for
each physical regulator so the threads shouldn't block each other while
delaying.It'd be even nicer if we could coalesce writes to a shared enable registers
in PMICs but that's definitely future work, and it may also be useful
and is certainly more achievable to optimise out the parallelism if none
of the regulators implement ramp delays.Signed-off-by: Mark Brown
Signed-off-by: Liam Girdwood
27 May, 2011
7 commits
-
In the case of get_voltage callback is NULL, current implementation in
_regulator_get_voltage will return -EINVAL.Also returns proper error if ret is negative value.
Signed-off-by: Axel Lin
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
Adding support for the twl6025. Major difference in the twl6025 is the
group functionality has been removed from the chip so this affects how
regulators are enabled and disabled.The names of the regulators also changed.
The DCDCs of the 6025 are software controllable as well.
Since V1
Use the features variable passed via platform data instead of calling
global function.Change the very switch like if statements to be a more readable
switch statement.Since V2
twl6025 doesn't use remap so remove it from the macros.
Since V3
enable/disable functions for 4030/6030 were seperated upstream so rebase
on top of this. Change DCDC reference to SMPS as this is used in TRM.
Change list_voltage slightly to have less code.Signed-off-by: Graeme Gregory
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
TWL6030: regulator is disabled via VREG_STATE
TWL4030: regulator is disabled via VREG_GRP
Since there is nothing common, split twlreg_enable similar to other regulator_opsSigned-off-by: Balaji T K
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
TWL6030: regulator is enabled via VREG_STATE
TWL4030: regulator is enabled via VREG_GRP
Since there is nothing common, split twlreg_enable similar to other regulator_opsSigned-off-by: Balaji T K
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
The tps65911 chip introduces new features, including changes in
the regulator module.- VDD1 and VDD2 remain unchanged.
- VDD3 is now named VDDCTRL and has a wider voltage range.
- LDOs are now named LDO1...8 and voltage ranges are sequential,
making LDOs easier to handle.Signed-off-by: Jorge Eduardo Candelaria
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
We use val as array index,
thus the valid value rangae for val should be 0 .. n_voltages-1.Signed-off-by: Axel Lin
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood -
Voltage values should be expressed in microvolts, not in milivolts.
Signed-off-by: Fabio Estevam
Signed-off-by: Ranjani Vaidyanathan
Acked-by: Mark Brown
Signed-off-by: Liam Girdwood
