22 Jun, 2005

1 commit

  • Fix overrun of static array "ipmi_interfaces" of size 4 at position 4 with
    index variable "if_num".

    Definitions involved:
    297 #define MAX_IPMI_INTERFACES 4
    298 static ipmi_smi_t ipmi_interfaces[MAX_IPMI_INTERFACES];

    Signed-off-by: Zaur Kambarov
    Cc: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Zaur Kambarov
     

21 Jun, 2005

7 commits


19 Jun, 2005

1 commit

  • When significant delays happen during boot (e.g. with a kernel debugger,
    but the problem has also seen in other cases) the timeout for blanking the
    console may trigger, but the work scheduler may not have been initialized,
    yet. schedule_work() will oops over the null keventd_wq.

    Signed-off-by: Jan Beulich
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Beulich
     

11 Jun, 2005

1 commit


10 Jun, 2005

2 commits


08 Jun, 2005

4 commits

  • [AGPGART] Replace check_bridge_mode() with (bridge->mode & AGSTAT_MODE_3_0).

    As mentioned earlier, the current check_bridge_mode() code assumes
    that AGP bridges are PCI devices. This isn't always true. Definitely
    not for HP zx1 chipset and the same seems to be the case for SGI's AGP
    bridge.

    The patch below fixes the problem by picking up the AGP_MODE_3_0 bit
    from bridge->mode. I feel like I may be missing something, since I
    can't see any reason why check_bridge_mode() wasn't doing that in the
    first place. According to the AGP 3.0 specs, the AGP_MODE_3_0 bit is
    determined during the hardware reset and cannot be changed, so it
    seems to me it should be safe to pick it up from bridge->mode.

    With the patch applied, I can definitely use AGP acceleration both
    with AGP 2.0 and AGP 3.0 (one with an Nvidia card, the other with an
    ATI FireGL card).

    Unless someone spots a problem, please apply this patch so 3d
    acceleration can work on zx1 boxes again.

    This makes AGP work again on machines with an AGP bridge that isn't a
    PCI device.

    Signed-off-by: David Mosberger-Tang
    Signed-off-by: Dave Jones

    David Mosberger
     
  • When Linux is running on the Xen virtual machine monitor, physical
    addresses are virtualised and cannot be directly referenced by the AGP
    GART. This patch fixes the GART driver for Xen by adding a layer of
    abstraction between physical addresses and 'GART addresses'.

    Architecture-specific functions are also defined for allocating and freeing
    the GATT. Xen requires this to ensure that table really is contiguous from
    the point of view of the GART.

    These extra interface functions are defined as 'no-ops' for all existing
    architectures that use the GART driver.

    Signed-off-by: Keir Fraser
    Signed-off-by: Andrew Morton
    Signed-off-by: Dave Jones

    Keir Fraser
     
  • …memory and sgi_tioca_remove_memory

    This patch fixes a problem with accessing GART memory in
    sgi_tioca_insert_memory and sgi_tioca_remove_memory.

    sgi-agp.c | 12 +++++++++---
    1 files changed, 9 insertions(+), 3 deletions(-)

    Signed-off-by: Mike Werner <werner@sgi.com>
    Signed-off-by: Dave Jones <davej@redhat.com>

    Michael Werner
     
  • Attached is a small patch for i945G support against 2.6.11.11.

    From: Alan Hourihane
    Signed-off-by: Dave Jones

    Alan Hourihane
     

07 Jun, 2005

1 commit

  • Stop using tty internal structure in mxser_receive_chars(), use
    tty_insert_flip_char(tty, ch flag); instead.

    Without this change driver ignores any rx'ed chars.

    Run tested.

    Cc: Alan Cox
    Cc: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Denis Vlasenko
     

26 May, 2005

1 commit

  • It looks like the recent IPMI patches had some -mm-onlyisms.

    Signed-off-by: Neil Horman
    Cc: Corey Minyard
    Cc: Greg KH
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Neil Horman
     

20 May, 2005

1 commit


19 May, 2005

1 commit

  • Don't pass meaningless file handles to block device ioctls.

    The recent raw IO ioctl-passthrough fix started passing the raw file
    handle into the block device ioctl handler. That's unlikely to be
    useful, as the file handle is actually open on a character-mode raw
    device, not a block device, so dereferencing it is not going to yield
    useful results to a block device ioctl handler.

    Previously we just passed NULL; also not a value that can usefully
    be dereferenced, but at least if it does happen, we'll oops instead of
    silently pretending that the file is a block device, so NULL is the more
    defensive option here. This patch reverts to that behaviour.

    Noticed by Al Viro.

    Signed-off-by: Stephen Tweedie
    Acked-by: Al Viro
    Signed-off-by: Linus Torvalds

    Stephen Tweedie
     

17 May, 2005

2 commits

  • Additional i8xx_tco device support.

    Cc: David Hardeman
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Peter Lundkvist
     
  • [Patch] Fix raw device ioctl pass-through

    Raw character devices are supposed to pass ioctls through to the block
    devices they are bound to. Unfortunately, they are using the wrong
    function for this: ioctl_by_bdev(), instead of blkdev_ioctl().

    ioctl_by_bdev() performs a set_fs(KERNEL_DS) before calling the ioctl,
    redirecting the user-space buffer access to the kernel address space.
    This is, needless to say, a bad thing.

    This was noticed first on s390, where raw IO was non-functioning. The
    s390 driver config does not actually allow raw IO to be enabled, which
    was the first part of the problem. Secondly, the s390 kernel address
    space is distinct from user, causing legal raw ioctls to fail. I've
    reproduced this on a kernel built with 4G:4G split on x86, which fails
    in the same way (-EFAULT if the address does not exist kernel-side;
    returns success without actually populating the user buffer if it does.)

    The patch below fixes both the config and address-space problems. It's
    based closely on a patch by Jan Glauber , which has
    been tested on s390 at IBM. I've tested it on x86 4G:4G (split address
    space) and x86_64 (common address space).

    Kernel-address-space access has been assigned CAN-2005-1264.

    Signed-off-by: Stephen Tweedie
    Signed-off-by: Dave Jones
    Signed-off-by: Greg Kroah-Hartman

    Stephen Tweedie
     

06 May, 2005

2 commits


05 May, 2005

1 commit


04 May, 2005

5 commits


01 May, 2005

10 commits

  • Another large rollup of various patches from Adrian which make things static
    where they were needlessly exported.

    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Adrian Bunk
     
  • Convert most of the current code that uses _NSIG directly to instead use
    valid_signal(). This avoids gcc -W warnings and off-by-one errors.

    Signed-off-by: Jesper Juhl
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     
  • Correct an issue with the IPMI message layer taking a lock and calling
    lower layer driver. If an error occrues at the lower layer the lock can be
    taken again causing a deadlock. The lock is released before calling the
    lower layer.

    Signed-off-by: David Griego
    Signed-off-by: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Corey Minyard
     
  • Enable interrupts for a BT interface. There is a specific register that
    needs to be set up to enable interrupts that also must be modified to clear
    the irq.

    Also, don't reset the BMC on a BT interface. That's probably not a good
    idea as the BMC may be performing other important functions and a reset
    should only be a last resort. Also, that register is also used to
    enable/disable interrupts to the BT; modifying it may screw up the
    interrupts.

    Signed-off-by: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Corey Minyard
     
  • If there is an unexpected close, still allow the watchdog interface to be
    re-opened on the IPMI watchdog.

    Signed-off-by: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Corey Minyard
     
  • If the ACPI register bit width is zero (an invalid value) assume it is the
    default spacing. This avoids some coredumps on invalid data and makes some
    systems work that have broken ACPI data.

    Signed-off-by: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Corey Minyard
     
  • Ignore the bottom bit of the base address from the DMI data. It is
    supposed to be set to 1 if it is I/O space. Few systems do this, but this
    enables the ones that do set it to work properly.

    Signed-off-by: Corey Minyard
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Corey Minyard
     
  • There were still a few comments left refering to verify_area, and two
    functions, verify_area_skas & verify_area_tt that just wrap corresponding
    access_ok_skas & access_ok_tt functions, just like verify_area does for
    access_ok - deprecate those.

    There was also a few places that still used verify_area in commented-out
    code, fix those up to use access_ok.

    After applying this one there should not be anything left but finally
    removing verify_area completely, which will happen after a kernel release
    or two.

    Signed-off-by: Jesper Juhl
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     
  • I recently realized that the in-kernel copy of hangcheck-timer was quite
    stale. Here's the latest. It adds support for s390, ppc64, and ia64 too.

    Signed-off-by: Joel Becker
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joel Becker
     
  • This patch changes calls to synchronize_kernel(), deprecated in the earlier
    "Deprecate synchronize_kernel, GPL replacement" patch to instead call the new
    synchronize_rcu() and synchronize_sched() APIs.

    Signed-off-by: Paul E. McKenney
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Paul E. McKenney