21 Dec, 2011
14 commits
-
Fix some trivial typos.
Signed-off-by: Shan Wei
Signed-off-by: David S. Miller -
If recovery is triggered in presence of pending asynchronous
deliveries of storage blocks we do a forced cleanup after
the corresponding tasklets are completely stopped and trigger
appropriate notifications for the correspondingerror state.Signed-off-by: Einar Lueck
Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
In case there are no system resources to run a recovery we have to clear
recovery bitmasks so a further automatic or manual driven recovery can
fix up the device.Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
The NETIUCV device driver allows to connect a Linux guest on z/VM to
another z/VM guest based on the z/VM communication facility IUCV.
Multiple output paths to different guests are possible, as well as
multiple input paths from different guests.
With this feature, you can configure multiple point-to-point NETIUCV
interfaces between your Linux on System z instance and another z/VM
guest.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
A recovery does not make sense during shutdown and may even cause an
error like this:qeth 0.0.f503: A recovery process has been started for the device
Badness at drivers/s390/cio/qdio_main.c:1156
Modules linked in: autofs4 sunrpc dm_multipath scsi_dh scsi_mod qeth_l3 ipv6 vmu
r qeth qdio ccwgroup ext3 jbd mbcache dasd_eckd_mod dasd_mod dm_mirror dm_region
_hash dm_log dm_mod [last unloaded: scsi_wait_scan]
CPU: 3 Not tainted 2.6.32-202.el6.s390x #1
Process qeth_recover (pid: 1498, task: 000000003efe2040, ksp: 000000003d5e3b80)
Krnl PSW : 0404200180000000 000003c000be6da8 (qdio_int_handler+0x88/0x43c [qdio]
)
R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:0 CC:2 PM:0 EA:3
Krnl GPRS: ffffffffffff3bac 0000000000000005 0000000000000000 fffffffffffffff4
0000000000000000 000000000000000c 0000000000000000 000000003ca97000
0000000000000380 fffffffffffffff4 000000003f22d800 000000003f22c478
000003c000bdf000 000003c000bea270 000000003f447e10 000000003f447db0
Krnl Code: 000003c000be6d9a: c21f00000004 clfi %r1,4
000003c000be6da0: a7c40021 brc 12,3c000be6de2
000003c000be6da4: a7f40001 brc 15,3c000be6da6
>000003c000be6da8: e320a0080004 lg %r2,8(%r10)
000003c000be6dae: a7390003 lghi %r3,3
000003c000be6db2: a72b0178 aghi %r2,376
000003c000be6db6: a7490001 lghi %r4,1
000003c000be6dba: a7590000 lghi %r5,0
Call Trace:
([] __per_cpu_offset+0x0/0x200)
[] ccw_device_call_handler+0x70/0xcc
[] ccw_device_irq+0x82/0x180
[] do_IRQ+0x16c/0x1ec
[] io_return+0x0/0x8
[] qeth_determine_capabilities+0x208/0x5cc [qeth]
([] qeth_determine_capabilities+0x1de/0x5cc [qeth])
[] qeth_core_hardsetup_card+0x160/0x1258 [qeth]
[] __qeth_l3_set_online+0x132/0xb14 [qeth_l3]
[] qeth_l3_recover+0x168/0x224 [qeth_l3]
[] kthread+0xa4/0xac
[] kernel_thread_starter+0x6/0xc
[] kernel_thread_starter+0x0/0xcThe patch forbids start of a recovery once qeth shutdown is running.
Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
qeth layer3 recovery invokes its set_multicast_list function, which
invokes function __vlan_find_dev_deep requiring rcu_read_lock or
rtnl lock. This causes kernel messages:kernel: [ INFO: suspicious rcu_dereference_check() usage. ]
kernel: ---------------------------------------------------
kernel: net/8021q/vlan_core.c:70 invoked rcu_dereference_check() without protection!kernel: stack backtrace:
kernel: CPU: 0 Not tainted 3.1.0 #9
kernel: Process qeth_recover (pid: 2078, task: 000000007e584680, ksp: 000000007e3e3930)
kernel: 000000007e3e3d08 000000007e3e3c88 0000000000000002 0000000000000000
kernel: 000000007e3e3d28 000000007e3e3ca0 000000007e3e3ca0 00000000005e77ce
kernel: 0000000000000000 0000000000000001 ffffffffffffffff 0000000000000001
kernel: 000000000000000d 000000000000000c 000000007e3e3cf0 0000000000000000
kernel: 0000000000000000 0000000000100a18 000000007e3e3c88 000000007e3e3cc8
kernel: Call Trace:
kernel: ([] show_trace+0xee/0x144)
kernel: [] __vlan_find_dev_deep+0xb0/0x108
kernel: [] qeth_l3_set_multicast_list+0x976/0xe38
kernel: [] __qeth_l3_set_online+0x75c/0x1498
kernel: [] qeth_l3_recover+0xc4/0x1d0
kernel: [] kthread+0xa6/0xb0
kernel: [] kernel_thread_starter+0x6/0xc
kernel: [] kernel_thread_starter+0x0/0xcThe patch makes sure the rtnl lock is held once qeth recovery invokes
its set_multicast_list function.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
af_iucv differs unnecessarily between state IUCV_SEVERED and
IUCV_DISCONN. This patch removes state IUCV_SEVERED.
While simplifying af_iucv, this patch removes the 2nd invocation of
cpcmd as well.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
af_iucv contains timer infrastructure which is not exploited.
This patch removes the timer related code parts.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
For HiperSockets transport skbs sent are bound to one of the
available HiperSockets devices. Add missing release of reference to
a HiperSockets device before freeing an skb.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
Closing an af_iucv socket may wait for confirmation of outstanding
send requests. This patch adds confirmation code for the new
HiperSockets transport.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
The AF_IUCV address family offers support for ancillary data.
This patch enables usage of ancillary data with the new
HiperSockets transport.Signed-off-by: Ursula Braun
Signed-off-by: Frank Blaschka
Signed-off-by: David S. Miller -
It was reported that the macvtap device selects a
Acked-by: Michael S. TsirkinSigned-off-by: David S. Miller
-
When UDP RSS is enabled, we use same QPN for TCP and UDP ranges
The bug is that the default_qpn was used base UDP qpn before it
was set.
Fixes bug introduced in commit: 1202d460b1df3a77fda66f4ba5f90ae3527dd42fSigned-off-by: Yevgeny Petrilin
Signed-off-by: David S. Miller -
Otherwise getting
| net/unix/diag.c:312:16: error: expected declaration specifiers or ‘...’ before string constant
| net/unix/diag.c:313:1: error: expected declaration specifiers or ‘...’ before string constantSigned-off-by: Cyrill Gorcunov
Signed-off-by: David S. Miller
20 Dec, 2011
18 commits
-
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.(Thanks to Joe Perches for suggesting coccinelle for 0/1 -> true/false).
Cc: "David S. Miller"
Cc: netdev@vger.kernel.org
Signed-off-by: Rusty Russell
Signed-off-by: David S. Miller -
DaveM said:
Please, this kind of stuff rots forever and not using bool properly
drives me crazy.Joe Perches gave me the spatch script:
@@
bool b;
@@
-b = 0
+b = false
@@
bool b;
@@
-b = 1
+b = trueI merely installed coccinelle, read the documentation and took credit.
Signed-off-by: Rusty Russell
Signed-off-by: David S. Miller -
Signed-off-by: Gabor Juhos
Signed-off-by: Frederic Lambert
Signed-off-by: David S. Miller -
Replace open-coded list traversal with list_for_each_entry().
CC: Grant Grundler
CC: netdev@vger.kernel.org
Signed-off-by: Bjorn Helgaas
Signed-off-by: David S. Miller -
Replace open-coded list traversal with list_for_each_entry().
CC: David S. Miller
CC: netdev@vger.kernel.org
Signed-off-by: Bjorn Helgaas
Signed-off-by: David S. Miller -
Signed-off-by: Jitendra Kalsaria
Signed-off-by: David S. Miller -
We can use vzalloc() helper now instead of __vmalloc() trick
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
This patch adds the ethtool callbacks necessary to change the rss
indirection table from userspace. Should the number of interrupts
change (e.g. across a close / open call, or through a reset) and
any one of the indirection table values fall out-of-range, the driver
will reset the indirection table to a default layout.[Integrated many suggestions made by Ben Hutchings.]
Changes since v3
* Removed TG3_FLAG_SUPPORT_MSIX checks at the start of
tg3_get_rxfh_indir() and tg3_set_rxfh_indir().Signed-off-by: Matt Carlson
Signed-off-by: Michael Chan
Reviewed-by: Benjamin Li
Signed-off-by: David S. Miller -
bnx2-mips-06-6.2.3 and bnx2-mips-09-6.2.1.b
New firmware fixes iSCSI problems with some LeftHand targets that don't
set TTT=0xffffffff for Data-In according to spec. Firmware generates
exception warnings for this condition and becomes very slow. This is
fixed by suppressing these warnings when using default error mask.Signed-off-by: Michael Chan
Signed-off-by: David S. Miller -
Lancer does not have HW registers to indicate the EQ causing the INTx
interrupt. As a result EQE entries of one EQ may be consumed when interrupt
is caused by another EQ. Fix this by arming CQs at the end of NAPI poll
routine to regenerate the EQEs.Signed-off-by: Padmanabh Ratnakar
Signed-off-by: David S. Miller -
Signed-off-by: Vinson Lee
Signed-off-by: David S. Miller -
This reverts commit 5c3ddec73d01a1fae9409c197078cb02c42238c3.
S390 qeth driver actually still uses the setup ops.
Reported-by: Frank Blaschka
Signed-off-by: David S. Miller -
The communication channel is HW interface from PF point of view
So the command return status should be stored as HW error code
and only then translated to errno values.Reporetd-by: Dan Carpenter
Signed-off-by: Yevgeny Petrilin
Signed-off-by: David S. Miller -
The function is always called from irq context, changing the call
to spin_lock().Signed-off-by: Yevgeny Petrilin
Signed-off-by: David S. Miller -
Solves an issue where we tried to free the same page twice after
the port has been opened and closed.Signed-off-by: Alexander Guller
Signed-off-by: David S. Miller -
New FW can give clues to driver regarding default port type
and whether or not we should default to link sensing on the port.2 bits are added to QUERY_PORT command:
1. suggested_type: This bit gives a hint whether the default port type should be
IB or Ethernet.
The driver will use this hint in case the user didn't specify explicitly the link layer
type he wants to set.
2. default_sense: If this bit is set, we would sense the port type on start-up
and default the port to link sensingSigned-off-by: Yevgeny Petrilin
Signed-off-by: David S. Miller -
For ConnectX3 devices, we allow link sensing only if FW explicitly
reported it supports the feature.
For older versions (ConnectX1 and 2), if the card supports both link layer types
(Ethenet and Infiniband), link sensing is supported.Signed-off-by: Yevgeny Petrilin
Signed-off-by: David S. Miller -
…wireless-next into for-davem
17 Dec, 2011
8 commits
-
"result" isn't used. We ignore errors here because there is not much we
can do about them.Signed-off-by: Dan Carpenter
Signed-off-by: David S. Miller -
Use IS_ENABLED(CONFIG_FOO)
instead of defined(CONFIG_FOO) || defined (CONFIG_FOO_MODULE)Signed-off-by: Igor Maravić
Signed-off-by: David S. Miller -
Use IS_ENABLED(CONFIG_FOO)
instead of defined(CONFIG_FOO) || defined (CONFIG_FOO_MODULE)Signed-off-by: Igor Maravić
Signed-off-by: David S. Miller -
Use IS_ENABLED(CONFIG_FOO)
instead of defined(CONFIG_FOO) || defined (CONFIG_FOO_MODULE)Signed-off-by: Igor Maravić
Signed-off-by: David S. Miller -
Use IS_ENABLED(CONFIG_FOO)
instead of defined(CONFIG_FOO) || defined (CONFIG_FOO_MODULE)Signed-off-by: Igor Maravić
Signed-off-by: David S. Miller -
Signed-off-by: Ajit Khaparde
Signed-off-by: David S. Miller -
In control path, its better to use GFP_KERNEL allocations where
possible.Before taking qdisc spinlock, we preallocate memory just in case we'll
need it in gred_change_vq()This is a followup to commit 3f1e6d3fd37b (sch_gred: should not use
GFP_KERNEL while holding a spinlock)Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller -
Reported-by: Randy Dunlap
Signed-off-by: Glauber Costa
CC: Hiroyouki Kamezawa
CC: David S. Miller
CC: Eric Dumazet
CC: Stephen Rothwell
Signed-off-by: David S. Miller
