29 Mar, 2020

2 commits

  • The AER interfaces to clear error status registers were a confusing mess:

    - pci_cleanup_aer_uncorrect_error_status() cleared non-fatal errors
    from the Uncorrectable Error Status register.

    - pci_aer_clear_fatal_status() cleared fatal errors from the
    Uncorrectable Error Status register.

    - pci_cleanup_aer_error_status_regs() cleared the Root Error Status
    register (for Root Ports), the Uncorrectable Error Status register,
    and the Correctable Error Status register.

    Rename them to make them consistent:

    From To
    ---------------------------------------- -------------------------------
    pci_cleanup_aer_uncorrect_error_status() pci_aer_clear_nonfatal_status()
    pci_aer_clear_fatal_status() pci_aer_clear_fatal_status()
    pci_cleanup_aer_error_status_regs() pci_aer_clear_status()

    Since pci_cleanup_aer_error_status_regs() (renamed to
    pci_aer_clear_status()) is only used within drivers/pci/, move the
    declaration from to drivers/pci/pci.h.

    [bhelgaas: commit log, add renames]
    Link: https://lore.kernel.org/r/d1310a75dc3d28f7e8da4e99c45fbd3e60fe238e.1585000084.git.sathyanarayanan.kuppuswamy@linux.intel.com
    Signed-off-by: Kuppuswamy Sathyanarayanan
    Signed-off-by: Bjorn Helgaas

    Kuppuswamy Sathyanarayanan
     
  • Previously we passed the PCIe service type parameter to pcie_do_recovery(),
    where reset_link() looked up the underlying pci_port_service_driver and its
    .reset_link() function pointer. Instead of using this roundabout way, we
    can just pass the driver-specific .reset_link() callback function when
    calling pcie_do_recovery() function.

    This allows us to call pcie_do_recovery() from code that is not a PCIe port
    service driver, e.g., Error Disconnect Recover (EDR) support.

    Remove pcie_port_find_service() and pcie_port_service_driver.reset_link
    since they are now unused.

    Link: https://lore.kernel.org/r/60e02b87b526cdf2930400059d98704bf0a147d1.1585000084.git.sathyanarayanan.kuppuswamy@linux.intel.com
    Signed-off-by: Kuppuswamy Sathyanarayanan
    Signed-off-by: Bjorn Helgaas

    Kuppuswamy Sathyanarayanan
     

31 May, 2019

1 commit