24 Aug, 2020
1 commit
-
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
01 May, 2019
1 commit
-
All these files have some form of the usual GPLv2 boilerplate. Switch
them to use SPDX tags instead.Reviewed-by: Chaitanya Kulkarni
Signed-off-by: Christoph Hellwig
Signed-off-by: Jens Axboe
04 Nov, 2017
1 commit
-
MD's rdev_set_badblocks() expects that badblocks_set() returns 1 if
badblocks are disabled, otherwise, rdev_set_badblocks() will record
superblock changes and return success in that case and md will fail to
report an IO error which it should.This bug has existed since badblocks were introduced in commit
9e0e252a048b ("badblocks: Add core badblock management code").Signed-off-by: Liu Bo
Acked-by: Guoqing Jiang
Signed-off-by: Shaohua Li
22 Jun, 2017
1 commit
-
This patch suppresses gcc 7 warnings about falling through in switch
statements when building with W=1. From the gcc documentation: The
-Wimplicit-fallthrough=3 warning is enabled by -Wextra. See also
https://gcc.gnu.org/onlinedocs/gcc-7.1.0/gcc/Warning-Options.html.Signed-off-by: Bart Van Assche
Signed-off-by: Jens Axboe
22 Oct, 2016
1 commit
-
When bandblocks_set acknowledges a range or badblocks_clear a range,
it's possible all badblocks are acknowledged. We should update
unacked_exist if this occurs.Signed-off-by: Shaohua Li
Reviewed-by: Tomasz Majchrzak
Tested-by: Tomasz Majchrzak
Signed-off-by: Jens Axboe
12 Oct, 2016
1 commit
-
Current bad block clear implementation assumes the range to clear
overlaps with at least one bad block already stored. If given range to
clear precedes first bad block in a list, the first entry is incorrectly
updated.Check not only if stored block end is past clear block end but also if
stored block start is before clear block end.Signed-off-by: Tomasz Majchrzak
Acked-by: NeilBrown
Signed-off-by: Jens Axboe
10 Jan, 2016
3 commits
-
Provide a devres interface for initializing a badblocks instance. The
pmem driver has several scenarios where it will be beneficial to have
this structure automatically freed when the device is disabled / fails
probe.Signed-off-by: Dan Williams
-
The badblocks list attached to a gendisk is allocated by the driver
which equates to the driver owning the lifetime of the object. Do not
automatically free it in del_gendisk(). This is in preparation for
expanding the use of badblocks in libnvdimm drivers and introducing
devm_init_badblocks().Signed-off-by: Dan Williams
-
For symmetry with badblocks_init() make it clear that this path only
destroys incremental allocations of a badblocks instance, and does not
free the badblocks instance itself.Signed-off-by: Dan Williams
09 Jan, 2016
1 commit
-
Take the core badblocks implementation from md, and make it generally
available. This follows the same style as kernel implementations of
linked lists, rb-trees etc, where you can have a structure that can be
embedded anywhere, and accessor functions to manipulate the data.The only changes in this copy of the code are ones to generalize
function/variable names from md-specific ones. Also add init and free
functions.Signed-off-by: Vishal Verma
Signed-off-by: Dan Williams
