Eric Lee / smarc-fsl-linux-kernel

25 May, 2011

2 commits

  • eea72d5fd   mtd: remove add_mtd_partitions, add_mtd_device and friends ... Browse Code »

    These symbols are replaced with mtd_device_register() (and removal with
    mtd_device_unregister()) for public registration.

    Signed-off-by: Jamie Iles
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse

    Jamie Iles
     
  • 7c802fbd5   mtd: be silent when mtd partition parser cannot be found ... Browse Code »

    Currently when we register partitions in 'parse_mtd_partitions()' we accept the
    list of parsers we should try. And if one of the parsers was not found we print
    a message. Well, first of all this whole idea is bad - look at how many
    'part_probes' and 'part_probe_types' variables we have - nearly every driver
    defines one. Instead, we should just go through all registered parsers all the
    time. But this needs to be worked on separately.

    This patch makes life of MTD partitions' users a bit simpler and allows them to
    safely request parsers which have not been registered -
    'parse_mtd_partitions()' will not print a "not available" message in this
    case.

    The point is that drivers do not have to do things like this any longer:

    static const char *part_probe_types[] = { "cmdlinepart", "RedBoot",
    "afs",
    NULL };

    but can simply do like this:

    static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", "afs", NULL };

    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse

    Artem Bityutskiy
     

17 Jan, 2011

1 commit

  • 154bf89f5   mtd: mtdpart: disallow reading OOB past the end of the partition ... Browse Code »

    This patch fixes the mtdpart bug which allows users reading OOB past the
    end of the partition. This happens because 'part_read_oob()' allows reading
    multiple OOB areas in one go, and mtdparts does not validate the OOB
    length in the request.

    Although there is such check in 'nand_do_read_oob()' in nand_base.c, but
    it checks that we do not read past the flash chip, not the partition,
    because in nand_base.c we work with the whole chip (e.g., mtd->size
    in nand_base.c is the size of the whole chip). So this check cannot
    be done correctly in nand_base.c and should be instead done in mtdparts.c.

    This problem was reported by Jason Liu and reproduced
    with nandsim:

    $ modprobe nandsim first_id_byte=0x20 second_id_byte=0xaa third_id_byte=0x00 \
    fourth_id_byte=0x15 parts=0x400,0x400
    $ modprobe nandsim mtd_oobtest.ko dev=0
    $ dmesg
    = snip =
    mtd_oobtest: attempting to read past end of device
    mtd_oobtest: an error is expected...
    mtd_oobtest: error: read past end of device
    = snip =
    mtd_oobtest: finished with 2 errors

    Reported-by: Jason Liu
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse

    Artem Bityutskiy
     

06 Jan, 2011

1 commit

  • 7fa33ac0a   mtd: initialize writebufsize in the MTD object of a partition ... Browse Code »

    Propagate the writebufsize to the partition's MTD object so
    that UBI can set correct value for it's minimal I/O size
    using the writebufsize field of MTD object of the partition.

    By previous patches we added proper writebufsize field
    initialization. Next patch can now change UBI to use
    this field for setting the minimal I/O size.

    Signed-off-by: Anatolij Gustschin
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse

    Anatolij Gustschin
     

04 Dec, 2010

1 commit

  • a7e93dcd9   mtd: fix master device identification for mtd repartition ... Browse Code »

    Function mtd_has_master renamed as mtd_is_partition to follow the function logic.
    The patch fixes the problem of checking the right mtd device for partition creation.
    To delete partition checking is not needed here so as it is done in mtd_del_partition.
    By master we consider the mtd device which does not belong to any partition.

    Signed-off-by: Roman Tereshonkov
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse

    Roman Tereshonkov
     

25 Oct, 2010

1 commit

09 Aug, 2010

2 commits

02 Aug, 2010

1 commit

20 Sep, 2009

2 commits

16 Sep, 2009

1 commit

26 May, 2009

2 commits

06 Apr, 2009

1 commit

  • d8877f191   [MTD] mtdpart: Make ecc_stats more realistic. ... Browse Code »

    In the existing implementation, ecc_stats fields are incremented only by
    one, regardless of master mtd errors number. For example, if there are N
    errors were corrected by ECC, partition ecc_stats.corrected will be
    incremented by one.

    This commit changes simple increment to sum of old value and parent mtd
    error count.

    Signed-off-by: Yauhen Kharuzhy
    Signed-off-by: David Woodhouse

    Yauhen Kharuzhy
     

04 Apr, 2009

1 commit

  • 1f24b5a8e   [MTD] driver model updates ... Browse Code »

    Update driver model support in the MTD framework, so it fits
    better into the current udev-based hotplug framework:

    - Each mtd_info now has a device node. MTD drivers should set
    the dev.parent field to point to the physical device, before
    setting up partitions or otherwise declaring MTDs.

    - Those device nodes always map to /sys/class/mtdX device nodes,
    which no longer depend on MTD_CHARDEV.

    - Those mtdX sysfs nodes have a "starter set" of attributes;
    it's not yet sufficient to replace /proc/mtd.

    - Enabling MTD_CHARDEV provides /sys/class/mtdXro/ nodes and the
    /sys/class/mtd*/dev attributes (for udev, mdev, etc).

    - Include a MODULE_ALIAS_CHARDEV_MAJOR macro. It'll work with
    udev creating the /dev/mtd* nodes, not just a static rootfs.

    So the sysfs structure is pretty much what you'd expect, except
    that readonly chardev nodes are a bit quirky.

    Signed-off-by: David Brownell
    Signed-off-by: David Woodhouse

    David Brownell
     

24 Mar, 2009

1 commit

10 Dec, 2008

1 commit

  • 69423d99f   [MTD] update internal API to support 64-bit device size ... Browse Code »

    MTD internal API presently uses 32-bit values to represent
    device size. This patch updates them to 64-bits but leaves
    the external API unchanged. Extending the external API
    is a separate issue for several reasons. First, no one
    needs it at the moment. Secondly, whether the implementation
    is done with IOCTLs, sysfs or both is still debated. Thirdly
    external API changes require the internal API to be accepted
    first.

    Note that although the MTD API will be able to support 64-bit
    device sizes, existing drivers do not and are not required
    to do so, although NAND base has been updated.

    In general, changing from 32-bit to 64-bit values cause little
    or no changes to the majority of the code with the following
    exceptions:
    - printk message formats
    - division and modulus of 64-bit values
    - NAND base support
    - 32-bit local variables used by mtdpart and mtdconcat
    - naughtily assuming one structure maps to another
    in MEMERASE ioctl

    Signed-off-by: Adrian Hunter
    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse

    Adrian Hunter
     

21 Oct, 2008

1 commit

  • 2be508d84   Merge git://git.infradead.org/mtd-2.6 ... Browse Code »

    * git://git.infradead.org/mtd-2.6: (69 commits)
    Revert "[MTD] m25p80.c code cleanup"
    [MTD] [NAND] GPIO driver depends on ARM... for now.
    [MTD] [NAND] sh_flctl: fix compile error
    [MTD] [NOR] AT49BV6416 has swapped erase regions
    [MTD] [NAND] GPIO NAND flash driver
    [MTD] cmdlineparts documentation change - explain where mtd-id comes from
    [MTD] cfi_cmdset_0002.c: Add Macronix CFI V1.0 TopBottom detection
    [MTD] [NAND] Fix compilation warnings in drivers/mtd/nand/cs553x_nand.c
    [JFFS2] Write buffer offset adjustment for NOR-ECC (Sibley) flash
    [MTD] mtdoops: Fix a bug where block may not be erased
    [MTD] mtdoops: Add a magic number to logged kernel oops
    [MTD] mtdoops: Fix an off by one error
    [JFFS2] Correct parameter names of jffs2_compress() in comments
    [MTD] [NAND] sh_flctl: add support for Renesas SuperH FLCTL
    [MTD] [NAND] Bug on atmel_nand HW ECC : OOB info not correctly written
    [MTD] [MAPS] Remove unused variable after ROM API cleanup.
    [MTD] m25p80.c extended jedec support (v2)
    [MTD] remove unused mtd parameter in of_mtd_parse_partitions()
    [MTD] [NAND] remove dead Kconfig associated with !CONFIG_PPC_MERGE
    [MTD] [NAND] driver extension to support NAND on TQM85xx modules
    ...

    Linus Torvalds
     

16 Oct, 2008

1 commit

  • a65e5d782   remove CONFIG_KMOD from drivers ... Browse Code »

    Straight forward conversions to CONFIG_MODULE; many drivers
    include conditionally and then don't have any
    other conditional code so remove it from those.

    Signed-off-by: Johannes Berg
    Cc: video4linux-list@redhat.com
    Cc: David Woodhouse
    Cc: linux-ppp@vger.kernel.org
    Cc: dm-devel@redhat.com
    Signed-off-by: Rusty Russell

    Johannes Berg
     

12 Aug, 2008

1 commit

25 Jul, 2008

4 commits

05 Jun, 2008

2 commits

02 May, 2008

1 commit

  • a98889f3d   [MTD][NOR] Add physical address to point() method ... Browse Code »

    Adding the ability to get a physical address from point() in addition
    to virtual address. This physical address is required for XIP of
    userspace code from flash.

    Signed-off-by: Jared Hulbert
    Reviewed-by: Jörn Engel
    Acked-by: Nicolas Pitre
    Acked-by: Greg Ungerer
    Signed-off-by: David Woodhouse

    Jared Hulbert
     

07 Feb, 2008

1 commit

  • 388bbb09b   [MTD] Add mtd panic_write function pointer ... Browse Code »

    MTDs are well suited for logging critical data and the mtdoops driver
    allows kernel panics/oops to be written to flash in a blackbox flight
    recorder fashion allowing better debugging and analysis of crashes.

    Any kernel oops in user context can be easily handled since the kernel
    continues as normal and any queued mtd writes are scheduled. Any kernel
    oops in interrupt context results in a panic and the delayed writes will
    not be scheduled however. The existing mtd->write function cannot be
    called in interrupt context so these messages can never be written to
    flash.

    This patch adds a panic_write function pointer that drivers can
    optionally implement which can be called in interrupt context. It is
    only intended to be called when its known the kernel is about to panic
    and we need to write to succeed. Since the kernel is not going to be
    running for much longer, this function can break locks and delay to
    ensure the write succeeds (but not sleep).

    Signed-off-by: Richard Purdie
    Signed-off-by: David Woodhouse

    Richard Purdie
     

03 Aug, 2007

1 commit

  • bec494775   [MTD] Makefile fix for mtdsuper ... Browse Code »

    We want drivers/mtd/{mtdcore, mtdsuper, mtdpart}.c to be built and linked
    into the same mtd.ko module. Fix the Makefile to ensure this, and remove
    duplicate MODULE_ declarations in mtdpart.c, as mtdcore.c already has them.

    Signed-off-by: Satyam Sharma
    Signed-off-by: David Woodhouse

    Satyam Sharma
     

09 May, 2007

1 commit

08 Mar, 2007

2 commits

  • 74641d752   [MTD] Correct partition failed erase address ... Browse Code »

    If an erase operation fails, the address at which the
    failure occurred is returned by the driver. The MTD
    partition must adjust this address (by subtracting the
    partition offset) before returning to the caller.
    This was not happening, which caused JFFS2 to mark
    the wrong block bad!

    Signed-off-by: Adrian Hunter
    Signed-off-by: David Woodhouse

    Adrian Hunter
     
  • 1f92267c5   [MTD] [NAND] make oobavail public ... Browse Code »

    During the MTD rework the oobavail parameter of mtd_info structure has become
    private. This is not quite correct in terms of integrity and logic. If we have
    means to write to OOB area, then we'd like to know upfront how many bytes out
    of OOB are spare per page to be able to adapt to specific cases.
    The patch inlined adds the public oobavail parameter.

    Signed-off-by: Vitaly Wool
    Signed-off-by: David Woodhouse

    Vitaly Wool
     

09 Feb, 2007

1 commit

  • 64f607105   [MTD] remove unused ecctype,eccsize fields from struct mtd_info ... Browse Code »

    Remove unused and broken mtd->ecctype and mtd->eccsize fields
    from struct mtd_info. Do not remove them from userspace API
    data structures (don't want to breake userspace) but mark them
    as obsolete by a comment. Any userspace program which uses them
    should be half-broken anyway, so this is more about saving
    data structure size.

    Signed-off-by: Artem Bityutskiy
    Signed-off-by: David Woodhouse

    Artem Bityutskiy
     

29 Nov, 2006

3 commits

  • 29072b960   [MTD] NAND: add subpage write support ... Browse Code »

    Many SLC NANDs support up to 4 writes at one NAND page. Add support
    of this feature.

    Signed-off-by: Artem Bityutskiy

    Thomas Gleixner
     
  • 95b93a0cd   [MTD] replace kmalloc+memset with kzalloc ... Browse Code »

    Signed-off-by: Yan Burman
    Signed-off-by: David Woodhouse

    Burman Yan
     
  • 7014568ba   [MTD] [NAND] remove len/ooblen confusion. ... Browse Code »

    As was discussed between Ricard Wanderlöf, David Woodhouse, Artem
    Bityutskiy and me, the current API for reading/writing OOB is confusing.

    The thing that introduces confusion is the need to specify ops.len
    together with ops.ooblen for reads/writes that concern only OOB not data
    area. So, ops.len is overloaded: when ops.datbuf != NULL it serves to
    specify the length of the data read, and when ops.datbuf == NULL, it
    serves to specify the full OOB read length.

    The patch inlined below is the slightly updated version of the previous
    patch serving the same purpose, but with the new Artem's comments taken
    into account.

    Artem, BTW, thanks a lot for your valuable input!

    Signed-off-by: Vitaly Wool
    Signed-off-by: David Woodhouse

    Vitaly Wool
     

01 Jul, 2006

1 commit

30 May, 2006

1 commit

  • f1a28c028   [MTD] NAND Expose the new raw mode function and status info to userspace ... Browse Code »

    The raw read/write access to NAND (without ECC) has been changed in the
    NAND rework. Expose the new way - setting the file mode via ioctl - to
    userspace. Also allow to read out the ecc statistics information so userspace
    tools can see that bitflips happened and whether errors where correctable
    or not. Also expose the number of bad blocks for the partition, so nandwrite
    can check if the data fits into the parition before writing to it.

    Signed-off-by: Thomas Gleixner

    Thomas Gleixner
     

29 May, 2006

1 commit

  • 8593fbc68   [MTD] Rework the out of band handling completely ... Browse Code »
    44

    Hopefully the last iteration on this!

    The handling of out of band data on NAND was accompanied by tons of fruitless
    discussions and halfarsed patches to make it work for a particular
    problem. Sufficiently annoyed by I all those "I know it better" mails and the
    resonable amount of discarded "it solves my problem" patches, I finally decided
    to go for the big rework. After removing the _ecc variants of mtd read/write
    functions the solution to satisfy the various requirements was to refactor the
    read/write _oob functions in mtd.

    The major change is that read/write_oob now takes a pointer to an operation
    descriptor structure "struct mtd_oob_ops".instead of having a function with at
    least seven arguments.

    read/write_oob which should probably renamed to a more descriptive name, can do
    the following tasks:

    - read/write out of band data
    - read/write data content and out of band data
    - read/write raw data content and out of band data (ecc disabled)

    struct mtd_oob_ops has a mode field, which determines the oob handling mode.

    Aside of the MTD_OOB_RAW mode, which is intended to be especially for
    diagnostic purposes and some internal functions e.g. bad block table creation,
    the other two modes are for mtd clients:

    MTD_OOB_PLACE puts/gets the given oob data exactly to/from the place which is
    described by the ooboffs and ooblen fields of the mtd_oob_ops strcuture. It's
    up to the caller to make sure that the byte positions are not used by the ECC
    placement algorithms.

    MTD_OOB_AUTO puts/gets the given oob data automaticaly to/from the places in
    the out of band area which are described by the oobfree tuples in the ecclayout
    data structre which is associated to the devicee.

    The decision whether data plus oob or oob only handling is done depends on the
    setting of the datbuf member of the data structure. When datbuf == NULL then
    the internal read/write_oob functions are selected, otherwise the read/write
    data routines are invoked.

    Tested on a few platforms with all variants. Please be aware of possible
    regressions for your particular device / application scenario

    Disclaimer: Any whining will be ignored from those who just contributed "hot
    air blurb" and never sat down to tackle the underlying problem of the mess in
    the NAND driver grown over time and the big chunk of work to fix up the
    existing users. The problem was not the holiness of the existing MTD
    interfaces. The problems was the lack of time to go for the big overhaul. It's
    easy to add more mess to the existing one, but it takes alot of effort to go
    for a real solution.

    Improvements and bugfixes are welcome!

    Signed-off-by: Thomas Gleixner

    Thomas Gleixner