Eric Lee / smarc-fsl-linux-kernel

18 Jun, 2020

3 commits

  • 29195232f   crc-t10dif: clean up some more things ... Browse Code »

    - Correctly compare the algorithm name in crc_t10dif_notify().

    - Use proper NOTIFY_* status codes instead of 0.

    - Consistently use CRC_T10DIF_STRING instead of "crct10dif" directly.

    - Use a proper type for the shash_desc context.

    - Use crypto_shash_driver_name() instead of open-coding it.

    - Make crc_t10dif_transform_show() use snprintf() rather than sprintf().
    This isn't actually necessary since the buffer has size PAGE_SIZE
    and CRYPTO_MAX_ALG_NAME < PAGE_SIZE, but it's good practice.

    - Give the "transform" sysfs file mode 0444 rather than 0644,
    since it doesn't implement a setter method.

    - Adjust the module description to not be the same as crct10dif-generic.

    Cc: Martin K. Petersen
    Signed-off-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Eric Biggers
     
  • be924e0aa   crc-t10dif: use fallback in initial state ... Browse Code »

    Currently the crc-t10dif module starts out with the fallback disabled
    and crct10dif_tfm == NULL. crc_t10dif_mod_init() tries to allocate
    crct10dif_tfm, and if it fails it enables the fallback.

    This is backwards because it means that any call to crc_t10dif() prior
    to module_init (which could theoretically happen from built-in code)
    will crash rather than use the fallback as expected. Also, it means
    that if the initial tfm allocation fails, then the fallback stays
    permanently enabled even if a crct10dif implementation is loaded later.

    Change it to use the more logical solution of starting with the fallback
    enabled, and disabling the fallback when a tfm gets allocated for the
    first time. This change also ends up simplifying the code.

    Also take the opportunity to convert the code to use the new static_key
    API, which is much less confusing than the old and deprecated one.

    Cc: Martin K. Petersen
    Signed-off-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Eric Biggers
     
  • 3906f6402   crc-t10dif: Fix potential crypto notify dead-lock ... Browse Code »

    The crypto notify call occurs with a read mutex held so you must
    not do any substantial work directly. In particular, you cannot
    call crypto_alloc_* as they may trigger further notifications
    which may dead-lock in the presence of another writer.

    This patch fixes this by postponing the work into a work queue and
    taking the same lock in the module init function.

    While we're at it this patch also ensures that all RCU accesses are
    marked appropriately (tested with sparse).

    Finally this also reveals a race condition in module param show
    function as it may be called prior to the module init function.
    It's fixed by testing whether crct10dif_tfm is NULL (this is true
    iff the init function has not completed assuming fallback is false).

    Fixes: 11dcb1037f40 ("crc-t10dif: Allow current transform to be...")
    Fixes: b76377543b73 ("crc-t10dif: Pick better transform if one...")
    Signed-off-by: Herbert Xu
    Reviewed-by: Martin K. Petersen
    Reviewed-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Herbert Xu
     

19 Jun, 2019

1 commit

  • 40b0b3f8f   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230 ... Browse Code »

    Based on 2 normalized pattern(s):

    this source code is licensed under the gnu general public license
    version 2 see the file copying for more details

    this source code is licensed under general public license version 2
    see

    extracted by the scancode license scanner the SPDX license identifier

    GPL-2.0-only

    has been chosen to replace the boilerplate/reference in 52 file(s).

    Signed-off-by: Thomas Gleixner
    Reviewed-by: Enrico Weigelt
    Reviewed-by: Allison Randal
    Reviewed-by: Alexios Zavras
    Cc: linux-spdx@vger.kernel.org
    Link: https://lkml.kernel.org/r/20190602204653.449021192@linutronix.de
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

25 Apr, 2019

1 commit

  • 877b5691f   crypto: shash - remove shash_desc::flags ... Browse Code »

    The flags field in 'struct shash_desc' never actually does anything.
    The only ostensibly supported flag is CRYPTO_TFM_REQ_MAY_SLEEP.
    However, no shash algorithm ever sleeps, making this flag a no-op.

    With this being the case, inevitably some users who can't sleep wrongly
    pass MAY_SLEEP. These would all need to be fixed if any shash algorithm
    actually started sleeping. For example, the shash_ahash_*() functions,
    which wrap a shash algorithm with the ahash API, pass through MAY_SLEEP
    from the ahash API to the shash API. However, the shash functions are
    called under kmap_atomic(), so actually they're assumed to never sleep.

    Even if it turns out that some users do need preemption points while
    hashing large buffers, we could easily provide a helper function
    crypto_shash_update_large() which divides the data into smaller chunks
    and calls crypto_shash_update() and cond_resched() for each chunk. It's
    not necessary to have a flag in 'struct shash_desc', nor is it necessary
    to make individual shash algorithms aware of this at all.

    Therefore, remove shash_desc::flags, and document that the
    crypto_shash_*() functions can be called from any context.

    Signed-off-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Eric Biggers
     

14 Sep, 2018

1 commit

04 Sep, 2018

2 commits

31 May, 2015

1 commit

  • 10081fb53   lib: introduce crc_t10dif_update() ... Browse Code »

    This introduces crc_t10dif_update() which enables to calculate CRC
    for a block which straddles multiple SG elements by calling multiple
    times. This also converts crc_t10dif() to use crc_t10dif_update() as
    they are almost same.

    (remove extra function call in crc_t10dif() and crc_t10dif_update -
    Tim + Herbert)

    Signed-off-by: Akinobu Mita
    Acked-by: Martin K. Petersen
    Cc: Tim Chen
    Cc: Herbert Xu
    Cc: "David S. Miller"
    Cc: linux-crypto@vger.kernel.org
    Cc: Nicholas Bellinger
    Cc: Sagi Grimberg
    Cc: "Martin K. Petersen"
    Cc: Christoph Hellwig
    Cc: "James E.J. Bottomley"
    Cc: target-devel@vger.kernel.org
    Signed-off-by: Nicholas Bellinger

    Akinobu Mita
     

12 Sep, 2013

1 commit

  • 26052f9b9   crypto: crct10dif - Add fallback for broken initrds ... Browse Code »

    Unfortunately, even with a softdep some distros fail to include
    the necessary modules in the initrd. Therefore this patch adds
    a fallback path to restore existing behaviour where we cannot
    load the new crypto crct10dif algorithm.

    In order to do this, the underlying crct10dif has been split out
    from the crypto implementation so that it can be used on the
    fallback path.

    Signed-off-by: Herbert Xu

    Herbert Xu
     

07 Sep, 2013

1 commit

24 Jul, 2013

1 commit

  • e70308ec0   Revert "crypto: crct10dif - Wrap crc_t10dif function all to use crypto transform framework" ... Browse Code »

    This reverts commits
    67822649d7305caf3dd50ed46c27b99c94eff996
    39761214eefc6b070f29402aa1165f24d789b3f7
    0b95a7f85718adcbba36407ef88bba0a7379ed03
    31d939625a9a20b1badd2d4e6bf6fd39fa523405
    2d31e518a42828df7877bca23a958627d60408bc

    Unfortunately this change broke boot on some systems that used an
    initrd which does not include the newly created crct10dif modules.
    As these modules are required by sd_mod under certain configurations
    this is a serious problem.

    Signed-off-by: Herbert Xu

    Herbert Xu
     

05 Jun, 2013

1 commit

20 May, 2013

1 commit

12 Jul, 2008

1 commit