04 Oct, 2018

1 commit

  • This patch explains the DRM_MODE_PROP_IMMUTABLE flag a bit better
    by telling which function to call if kernel wants to update
    drm object's immutable properties.

    Suggested-by: Daniel Vetter
    Cc: Daniel Vetter
    Signed-off-by: Manasi Navare
    Reviewed-by: Daniel Vetter
    Link: https://patchwork.freedesktop.org/patch/msgid/20181002215055.8652-1-manasi.d.navare@intel.com

    Manasi Navare
     

09 Sep, 2018

1 commit

  • Just a bit of missing includes and pre declarations.

    v2: Compiles now, with drm/drm_util.h extracted.

    v3: Rebase

    v3: Fix up commit message (Sam Ravnborg)

    Reviewed-by: Sean Paul
    Signed-off-by: Daniel Vetter
    Link: https://patchwork.freedesktop.org/patch/msgid/20180905135711.28370-3-daniel.vetter@ffwll.ch

    Daniel Vetter
     

14 Jul, 2018

1 commit


27 Apr, 2018

1 commit

  • drm_property_add_enum() can calculate the index itself just fine,
    so no point in having the caller pass it in.

    Cc: Patrik Jakobsson
    Cc: Ben Skeggs
    Cc: nouveau@lists.freedesktop.org
    Signed-off-by: Ville Syrjälä
    Link: https://patchwork.freedesktop.org/patch/msgid/20180316190420.26734-1-ville.syrjala@linux.intel.com
    Reviewed-by: Stanislav Lisovskiy

    Ville Syrjälä
     

22 Mar, 2018

1 commit

  • This patch remove the compatibility aliases
    drm_property_{reference/unreference}_blob of
    drm_property_blob_{get/put} since all callers have been converted to the
    prefered _{get/put}.

    Remove the helpers from the semantic patch drm-get-put-cocci.

    Signed-off-by: Haneen Mohammed
    Signed-off-by: Sean Paul
    Link: https://patchwork.freedesktop.org/patch/msgid/20180320133749.GA11695@haneen-VirtualBox

    Haneen Mohammed
     

16 Mar, 2018

1 commit

  • Using a flexible array for the blob data was a mistake by me. It
    forces all users of the blob data to cast blob->data to something
    else. void* is clearly superior so let's go back to the original
    scheme.

    Not a clean revert as the code has moved.

    This reverts commit d63f5e6bf6f2a1573ea39c9937cdf5ab0b3a4b77.

    Signed-off-by: Ville Syrjälä
    Link: https://patchwork.freedesktop.org/patch/msgid/20180223192506.29992-1-ville.syrjala@linux.intel.com
    Reviewed-by: Shashank Sharma
    Reviewed-by: Daniel Vetter

    Ville Syrjälä
     

08 Mar, 2018

1 commit

  • The property flags are part of the uabi and we have 32 bits for them.
    Pass them around as u32 internally as well, instead of a signed int.

    Signed-off-by: Ville Syrjälä
    Link: https://patchwork.freedesktop.org/patch/msgid/20180306164849.2862-5-ville.syrjala@linux.intel.com
    Reviewed-by: Daniel Vetter

    Ville Syrjälä
     

10 Nov, 2017

1 commit


12 Oct, 2017

1 commit


14 Jul, 2017

1 commit

  • The function has little to do with atomic, it's just where it has so
    far been needed. So, rename it to drm_property_replace_blob, move it
    to drm_property.c and export it.

    Change the semantics to return whether the blob was replaced instead
    of using an extra argument for that.

    Signed-off-by: Peter Rosin
    Signed-off-by: Daniel Vetter
    Link: http://patchwork.freedesktop.org/patch/msgid/20170713162538.22788-2-peda@axentia.se

    Peter Rosin
     

09 Jun, 2017

1 commit

  • There is no reason why the name field should not be const, but
    several why it should. The struct should only be used by
    drm_property_create_enum() and there the name-field from the struct
    is passed to drm_property_add_enum(), which takes a const char * as
    a parameter.

    Signed-off-by: Jyri Sarha
    Signed-off-by: Ville Syrjälä
    Link: http://patchwork.freedesktop.org/patch/msgid/5dd3b6a1e20452bd8abdcbc55d1e8d7f56262266.1496161066.git.jsarha@ti.com

    Jyri Sarha
     

28 Feb, 2017

1 commit

  • For consistency with other reference counting APIs in the kernel, add
    drm_property_blob_get() and drm_property_blob_put() to reference count
    DRM blob properties.

    Compatibility aliases are added to keep existing code working. To help
    speed up the transition, all the instances of the old functions in the
    DRM core are already replaced in this commit.

    A semantic patch is provided that can be used to convert all drivers to
    the new helpers.

    Reviewed-by: Sean Paul
    Acked-by: Christian König
    Signed-off-by: Thierry Reding
    Link: http://patchwork.freedesktop.org/patch/msgid/20170228144643.5668-7-thierry.reding@gmail.com

    Thierry Reding
     

25 Jan, 2017

1 commit

  • I just learned that &struct_name.member_name works and looks pretty
    even. It doesn't (yet) link to the member directly though, which would
    be really good for big structures or vfunc tables (where the
    per-member kerneldoc tends to be long).

    Also some minor drive-by polish where it makes sense, I read a lot
    of docs ...

    v2: Review from Eric.

    Cc: Jani Nikula
    Cc: Chris Wilson
    Reviewed-by: Eric Engestrom
    Signed-off-by: Daniel Vetter
    Link: http://patchwork.freedesktop.org/patch/msgid/20170125062657.19270-4-daniel.vetter@ffwll.ch

    Daniel Vetter
     

19 Sep, 2016

1 commit

  • Now that there's less stuff in there I noticed that I overlooked them.
    Sprinkle some docs over them while at it.

    Reviewed-by: Sean Paul
    Signed-off-by: Daniel Vetter
    Link: http://patchwork.freedesktop.org/patch/msgid/20160831160913.12991-2-daniel.vetter@ffwll.ch

    Daniel Vetter
     

29 Aug, 2016

2 commits

  • - remove kerneldoc for drm-internal functions
    - drm_property_replace_global_blob isn't actually atomic, and doesn't
    need to be. Update docs&comments to match
    - document all the types and try to link things a bit better
    - nits all over

    v2: Appease checkpatch in the moved code (Archit)

    Reviewed-by: Archit Taneja
    Signed-off-by: Daniel Vetter
    Link: http://patchwork.freedesktop.org/patch/msgid/20160829082757.17913-9-daniel.vetter@ffwll.ch

    Daniel Vetter
     
  • This just contains the base property classes and all the code to
    handle blobs. I think for any kind of standardized/shared properties
    it's better to have separate files - this is fairly big already as-is.

    v2: resurrect misplaced hunk (Daniel Stone)

    Cc: Daniel Stone
    Reviewed-by: Archit Taneja
    Signed-off-by: Daniel Vetter
    Link: http://patchwork.freedesktop.org/patch/msgid/20160829082757.17913-7-daniel.vetter@ffwll.ch

    Daniel Vetter