Eric Lee / smarc-fsl-linux-kernel

13 Jun, 2019

1 commit

  • d6ebf5286   crypto: make all generic algorithms set cra_driver_name ... Browse Code »

    Most generic crypto algorithms declare a driver name ending in
    "-generic". The rest don't declare a driver name and instead rely on
    the crypto API automagically appending "-generic" upon registration.

    Having multiple conventions is unnecessarily confusing and makes it
    harder to grep for all generic algorithms in the kernel source tree.
    But also, allowing NULL driver names is problematic because sometimes
    people fail to set it, e.g. the case fixed by commit 417980364300
    ("crypto: cavium/zip - fix collision with generic cra_driver_name").

    Of course, people can also incorrectly name their drivers "-generic".
    But that's much easier to notice / grep for.

    Therefore, let's make cra_driver_name mandatory. In preparation for
    this, this patch makes all generic algorithms set cra_driver_name.

    Signed-off-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Eric Biggers
     

18 Apr, 2019

1 commit

  • c4741b230   crypto: run initcalls for generic implementations earlier ... Browse Code »

    Use subsys_initcall for registration of all templates and generic
    algorithm implementations, rather than module_init. Then change
    cryptomgr to use arch_initcall, to place it before the subsys_initcalls.

    This is needed so that when both a generic and optimized implementation
    of an algorithm are built into the kernel (not loadable modules), the
    generic implementation is registered before the optimized one.
    Otherwise, the self-tests for the optimized implementation are unable to
    allocate the generic implementation for the new comparison fuzz tests.

    Note that on arm, a side effect of this change is that self-tests for
    generic implementations may run before the unaligned access handler has
    been installed. So, unaligned accesses will crash the kernel. This is
    arguably a good thing as it makes it easier to detect that type of bug.

    Signed-off-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Eric Biggers
     

24 Nov, 2014

1 commit

02 Sep, 2013

1 commit

  • 06e710bd5   crypto: fcrypt - Fix bitoperation for compilation with clang ... Browse Code »

    v2: Fix bug in statement as pointed out by Herbert Xu. Kudos to pipacs.

    Author: PaX Team
    ML-Post: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20120507/142707.html
    URL: http://llvm.linuxfoundation.org

    Merge: Jan-Simon Möller

    Description:

    Fix for warning:
    linux/crypto/fcrypt.c:143:47: warning: signed shift result (0x598000000) requires 36 bits to
    represent, but 'int' only has 32 bits [-Wshift-overflow]
    Z(0xef), Z(0x70), Z(0xcf), Z(0xc2), Z(0x2a), Z(0xb3), Z(0x61), Z(0xad),
    ^~~~~~~
    linux/crypto/fcrypt.c:113:29: note: expanded from macro 'Z'
    ^ ~~
    linux/include/uapi/linux/byteorder/little_endian.h:38:53: note: expanded from macro
    '__cpu_to_be32'
    ^
    linux/include/uapi/linux/swab.h:116:21: note: expanded from macro '__swab32'
    ___constant_swab32(x) : \
    ^
    linux/include/uapi/linux/swab.h:18:12: note: expanded from macro '___constant_swab32'
    (((__u32)(x) & (__u32)0x0000ff00UL) << 8) | \
    ^

    Solution - make sure we don't exceed the 32 bit range.
    #define Z(x) cpu_to_be32(((x & 0x1f) << 27) | (x >> 5))

    Signed-off-by: Jan-Simon Möller
    CC: pageexec@freemail.hu
    CC: llvmlinux@lists.linuxfoundation.org
    CC: behanw@converseincode.com
    CC: herbert@gondor.apana.org.au
    CC: davem@davemloft.net
    CC: linux-crypto@vger.kernel.org
    CC: linux-kernel@vger.kernel.org
    Signed-off-by: Herbert Xu

    Jan-Simon Möller
     

01 Aug, 2012

1 commit

  • 77ec2e734   crypto: cleanup - remove unneeded crypto_alg.cra_list initializations ... Browse Code »

    Initialization of cra_list is currently mixed, most ciphers initialize this
    field and most shashes do not. Initialization however is not needed at all
    since cra_list is initialized/overwritten in __crypto_register_alg() with
    list_add(). Therefore perform cleanup to remove all unneeded initializations
    of this field in 'crypto/'.

    Signed-off-by: Jussi Kivilinna
    Signed-off-by: Herbert Xu

    Jussi Kivilinna
     

16 Feb, 2010

1 commit

25 Dec, 2008

1 commit

21 Apr, 2008

1 commit

  • 3af5b90bd   [CRYPTO] all: Clean up init()/fini() ... Browse Code »

    On Thu, Mar 27, 2008 at 03:40:36PM +0100, Bodo Eggert wrote:
    > Kamalesh Babulal wrote:
    >
    > > This patch cleanups the crypto code, replaces the init() and fini()
    > > with the _init/_fini
    >
    > This part ist OK.
    >
    > > or init/fini_ (if the
    > > _init/_fini exist)
    >
    > Having init_foo and foo_init won't be a good thing, will it? I'd start
    > confusing them.
    >
    > What about foo_modinit instead?

    Thanks for the suggestion, the init() is replaced with

    _mod_init ()

    and fini () is replaced with _mod_fini.

    Signed-off-by: Kamalesh Babulal
    Signed-off-by: Herbert Xu

    Kamalesh Babulal
     

06 Dec, 2007

1 commit

20 Oct, 2007

1 commit

07 Feb, 2007

1 commit