Eric Lee / smarc-fsl-linux-kernel

15 Aug, 2019

1 commit

  • 440dc9aab   crypto: streebog - remove two unused variables ... Browse Code »

    crypto/streebog_generic.c:162:17: warning:
    Pi defined but not used [-Wunused-const-variable=]
    crypto/streebog_generic.c:151:17: warning:
    Tau defined but not used [-Wunused-const-variable=]

    They are never used, so can be removed.

    Reported-by: Hulk Robot
    Signed-off-by: YueHaibing
    Reviewed-by: Vitaly Chikunov
    Signed-off-by: Herbert Xu

    YueHaibing
     

18 Apr, 2019

1 commit

  • c4741b230   crypto: run initcalls for generic implementations earlier ... Browse Code »

    Use subsys_initcall for registration of all templates and generic
    algorithm implementations, rather than module_init. Then change
    cryptomgr to use arch_initcall, to place it before the subsys_initcalls.

    This is needed so that when both a generic and optimized implementation
    of an algorithm are built into the kernel (not loadable modules), the
    generic implementation is registered before the optimized one.
    Otherwise, the self-tests for the optimized implementation are unable to
    allocate the generic implementation for the new comparison fuzz tests.

    Note that on arm, a side effect of this change is that self-tests for
    generic implementations may run before the unaligned access handler has
    been installed. So, unaligned accesses will crash the kernel. This is
    arguably a good thing as it makes it easier to detect that type of bug.

    Signed-off-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Eric Biggers
     

08 Apr, 2019

1 commit

18 Jan, 2019

1 commit

  • 73381da5f   crypto: streebog - use correct endianness type ... Browse Code »

    streebog_uint512::qword needs to be __le64, not u64. This fixes a large
    number of sparse warnings:

    crypto/streebog_generic.c:25:9: warning: incorrect type in initializer (different base types)
    crypto/streebog_generic.c:25:9: expected unsigned long long
    crypto/streebog_generic.c:25:9: got restricted __le64 [usertype]
    [omitted many similar warnings]

    No actual change in behavior.

    Cc: Vitaly Chikunov
    Signed-off-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Eric Biggers
     

16 Nov, 2018

1 commit