23 Oct, 2020
1 commit
-
The Varmilo VA104M Keyboard (04b4:07b1, reported as Varmilo Z104M)
exposes media control hotkeys as a USB HID consumer control device, but
these keys do not work in the current (5.8-rc1) kernel due to the
incorrect HID report descriptor. Fix the problem by modifying the
internal HID report descriptor.More specifically, the keyboard report descriptor specifies the
logical boundary as 572~10754 (0x023c ~ 0x2a02) while the usage
boundary is specified as 0~10754 (0x00 ~ 0x2a02). This results in an
incorrect interpretation of input reports, causing inputs to be ignored.
By setting the Logical Minimum to zero, we align the logical boundary
with the Usage ID boundary.Some notes:
* There seem to be multiple variants of the VA104M keyboard. This
patch specifically targets 04b4:07b1 variant.* The device works out-of-the-box on Windows platform with the generic
consumer control device driver (hidserv.inf). This suggests that
Windows either ignores the Logical Minimum/Logical Maximum or
interprets the Usage ID assignment differently from the linux
implementation; Maybe there are other devices out there that only
works on Windows due to this problem?Signed-off-by: Frank Yang
Signed-off-by: Jiri Kosina
31 May, 2019
1 commit
-
Based on 1 normalized pattern(s):
this program is free software you can redistribute it and or modify
it under the terms of the gnu general public license as published by
the free software foundation either version 2 of the license or at
your option any later versionextracted by the scancode license scanner the SPDX license identifier
GPL-2.0-or-later
has been chosen to replace the boilerplate/reference in 3029 file(s).
Signed-off-by: Thomas Gleixner
Reviewed-by: Allison Randal
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de
Signed-off-by: Greg Kroah-Hartman
06 Jan, 2017
1 commit
-
Make sure we have enough of a report structure to validate before
looking at it.Reported-by: Benoit Camredon
Tested-by: Benoit Camredon
Cc: stable
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Jiri Kosina
18 Jun, 2015
1 commit
-
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick
Signed-off-by: Jiri Kosina
03 Jan, 2013
1 commit
-
Use the new module_hid_driver macro in all HID drivers that have
a simple register/unregister init/exit.This also converts the hid drivers that test for a failure of
hid_register_driver() and report the failure. Using module_hid_driver
in those drivers removes the failure message.Signed-off-by: H Hartley Sweeten
Signed-off-by: Jiri Kosina
05 Sep, 2012
1 commit
-
Paul Walmsley has implemented dynamic quirk handling back in 2007 through
commits:2eb5dc30eb ("USB HID: encapsulate quirk handling into hid-quirks.c")
8222fbe67c ("USB HID: clarify static quirk handling as squirks")
8cef908235 ("USB HID: add support for dynamically-created quirks")
876b9276b9 ("USB HID: add 'quirks' module parameter")and as such, his copyright rightly belongs to
drivers/hid/usbhid/hid-quirks.c file.However when generic HID code has been converted to bus and individual
quirks separated out to individual drivers on the bus, the copyright has
been blindly transfered into all the tiny drivers, which actually don't
contain any of Pauls' copyrighted code.Remove the copyright from those sub-drivers.
Signed-off-by: Jiri Kosina
Acked-by: Paul Walmsley
22 Jul, 2012
1 commit
-
Add yet another device to the list of Cypress barcode scanners
needing the CP_RDESC_SWAPPED_MIN_MAX quirk.Signed-off-by: Lionel Vaux (iouri)
Signed-off-by: Jiri Kosina
10 Dec, 2010
1 commit
-
Neaten current uses of dev_ by adding and using
hid specific hid_ macros.Convert existing uses of dev_ uses to hid_.
Convert hid-pidff printk uses to hid_.Remove err_hid and use hid_err instead.
Add missing newlines to logging messages where necessary.
Coalesce format strings.Add and use pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Other miscellaneous changes:
Add const struct hid_device * argument to hid-core functions
extract() and implement() so hid_ can be used by them.
Fix bad indentation in hid-core hid_input_field function
that calls extract() function above.Signed-off-by: Joe Perches
Signed-off-by: Jiri Kosina
10 Aug, 2010
1 commit
-
Update hid_driver's report_fixup prototype to allow changing report
descriptor size and/or returning completely different report descriptor.
Update existing usage accordingly.This is to give more freedom in descriptor fixup and to allow having a whole
fixed descriptor in the code for the sake of readability.Signed-off-by: Nikolai Kondrashov
Signed-off-by: Jiri Kosina
03 Dec, 2009
1 commit
-
Acan FG-8100 barcode reader (0x04b4/0xbca1) has vendor ID of
cypress and requires the same MIN/MAX swap descriptor quirk
as other barcode readers from cypress.Reported-by: Stijn Ghesquiere
Signed-off-by: Jiri Kosina
23 Jul, 2009
1 commit
-
Trivial patch which adds the __init and __exit macros to the module_init /
module_exit functions of several HID drivers from drivers/hid/Signed-off-by: Peter Huewe
Signed-off-by: Jiri Kosina
30 Mar, 2009
1 commit
-
This removal was scheduled and there is no problem with later
distros to adapt for the new bus, thanks to aliases.module-init-tools map files are deprecated nowadays, so that
the patch which introduced hid ones into the m-i-t won't be
accepted and hence there is no reason for leaving compat stuff in.Signed-off-by: Jiri Slaby
Cc: Jiri Kosina
Signed-off-by: Jiri Kosina
15 Oct, 2008
2 commits
-
Move connecting from usbhid to the hid layer and fix also hidp in
that manner.
This removes all the ignore/force hidinput/hiddev connecting quirks.Signed-off-by: Jiri Slaby
Signed-off-by: Jiri Kosina -
Signed-off-by: Jiri Slaby
Signed-off-by: Jiri Kosina