24 Aug, 2020
1 commit
-
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva
19 Dec, 2018
1 commit
-
There is no such limitation in the protocol or implementation, so
remove it.Signed-off-by: Christoph Hellwig
Reviewed-by: Juergen Gross
Signed-off-by: Martin K. Petersen
29 Nov, 2018
1 commit
-
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.Notice that, in this particular case, I replaced "Missed the backend's
Closing state -- fallthrough" with "fall through - Missed the backend's
Closing state", which contains the "fall through" annotation at the
beginnig of the code comment, which is what GCC is expecting to find.Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Juergen Gross
Signed-off-by: Martin K. Petersen
19 Jun, 2018
1 commit
-
When xenbus_printf fails, the lack of error-handling code may
cause unexpected results.This patch adds error-handling code after calling xenbus_printf.
Signed-off-by: Zhouyang Jia
Reviewed-by: Juergen Gross
Signed-off-by: Juergen Gross
13 Jun, 2017
1 commit
-
Since the SCSI core zeroes driver-private command data, remove
that code from the xen-scsifront driver.Signed-off-by: Bart Van Assche
Reviewed-by: Hannes Reinecke
Reviewed-by: Juergen Gross
Reviewed-by: Christoph Hellwig
Cc: xen-devel@lists.xenproject.org
Cc: Johannes Thumshirn
Signed-off-by: Martin K. Petersen
02 May, 2017
1 commit
-
Use offset_in_page() macro instead of open-coding.
Signed-off-by: Geliang Tang
Reviewed-by: Juergen Gross
Signed-off-by: Juergen Gross
09 Dec, 2016
1 commit
-
Instead of requesting a new slot on the ring to the backend early, do
so only after all has been setup for the request to be sent. This
makes error handling easier as we don't need to undo the request id
allocation and ring slot allocation.Suggested-by: Jan Beulich
Signed-off-by: Juergen Gross
Reviewed-by: Boris Ostrovsky
Signed-off-by: Juergen Gross
24 Nov, 2016
1 commit
-
Most error branches following the call to kmalloc contain
a call to kfree. This patch add these calls where they are
missing.This issue was found with Hector.
Signed-off-by: Quentin Lambert
Reviewed-by: Juergen Gross
Signed-off-by: Juergen Gross
07 Nov, 2016
1 commit
-
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible.
Signed-off-by: Juergen Gross
Acked-by: David Vrabel
09 Sep, 2015
1 commit
-
Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN
is meant, I suspect this is because the first support for Xen was for
PV. This resulted in some misimplementation of helpers on ARM and
confused developers about the expected behavior.For instance, with pfn_to_mfn, we expect to get an MFN based on the name.
Although, if we look at the implementation on x86, it's returning a GFN.For clarity and avoid new confusion, replace any reference to mfn with
gfn in any helpers used by PV drivers. The x86 code will still keep some
reference of pfn_to_mfn which may be used by all kind of guests
No changes as been made in the hypercall field, even
though they may be invalid, in order to keep the same as the defintion
in xen repo.Note that page_to_mfn has been renamed to xen_page_to_gfn to avoid a
name to close to the KVM function gfn_to_page.Take also the opportunity to simplify simple construction such
as pfn_to_mfn(page_to_pfn(page)) into xen_page_to_gfn. More complex clean up
will come in follow-up patches.[1] http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb
Signed-off-by: Julien Grall
Reviewed-by: Stefano Stabellini
Acked-by: Dmitry Torokhov
Acked-by: Wei Liu
Signed-off-by: David Vrabel
15 Apr, 2015
1 commit
-
Originally Xen PV drivers only use single-page ring to pass along
information. This might limit the throughput between frontend and
backend.The patch extends Xenbus driver to support multi-page ring, which in
general should improve throughput if ring is the bottleneck. Changes to
various frontend / backend to adapt to the new interface are also
included.Affected Xen drivers:
* blkfront/back
* netfront/back
* pcifront/back
* scsifront/back
* vtpmfrontThe interface is documented, as before, in xenbus_client.c.
Signed-off-by: Wei Liu
Signed-off-by: Paul Durrant
Signed-off-by: Bob Liu
Cc: Konrad Wilk
Cc: Boris Ostrovsky
Signed-off-by: David Vrabel
16 Mar, 2015
1 commit
-
Up to now the pvscsi frontend hasn't supported domain suspend and
resume. When a domain with an assigned pvscsi device was suspended
and resumed again, it was not able to use the device any more: trying
to do so resulted in hanging processes.Support suspend and resume of pvscsi devices.
Signed-off-by: Juergen Gross
Signed-off-by: David Vrabel
06 Oct, 2014
1 commit
-
The DEFINE_XENBUS_DRIVER() macro looks a bit weird and causes sparse
errors.Replace the uses with standard structure definitions instead. This is
similar to pci and usb device registration.Signed-off-by: David Vrabel
03 Oct, 2014
1 commit
-
scsifront_action_handler() will deadlock on host->host_lock, if the
ring is full and it has to wait for entries to become available.Signed-off-by: David Vrabel
Reviewed-by: Juergen Gross
23 Sep, 2014
2 commits
-
This function is only called with a spin_lock held and IRQs disabled.
The allocation is not allowed to sleep and NOIO is not sufficient, it
has to be ATOMIC.Signed-off-by: Dan Carpenter
Reviewed-by: Juergen Gross
Signed-off-by: David Vrabel -
Introduces the Xen pvSCSI frontend. With pvSCSI it is possible for a
Xen domU to issue SCSI commands to a SCSI LUN assigned to that
domU. The SCSI commands are passed to the pvSCSI backend in a driver
domain (usually Dom0) which is owner of the physical device. This
allows e.g. to use SCSI tape drives in a Xen domU.The code is taken from the pvSCSI implementation in Xen done by
Fujitsu based on Linux kernel 2.6.18.Changes from the original version are:
- port to upstream kernel
- put all code in just one source file
- move module to appropriate location in kernel tree
- adapt to Linux style guide
- some minor code simplifications
- replace constants with defines
- remove not used defines
- add support for larger SG lists by putting them in a granted pageSigned-off-by: Juergen Gross
Acked-by: Christoph Hellwig
Signed-off-by: David Vrabel