19 Jun, 2020

4 commits

  • Add tlen field into struct tso_t, and change tso_start()
    to return skb_transport_offset(skb) + tso->tlen

    This removes from callers the need to use tcp_hdrlen(skb) and
    will ease UDP segmentation offload addition.

    v2: calls tso_start() earlier in otx2_sq_append_tso() [Jakub]

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • skb argument of tso_count_descs(), tso_build_hdr() and tso_build_data() can be const.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • size field can be an int, no need for size_t

    Removes a 32bit hole on 64bit kernels.

    And align fields for better readability.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • Transport header size could be 60 bytes, and network header
    size can also be 60 bytes. Add the Ethernet header and we
    are above 128 bytes.

    Since drivers using net/core/tso.c usually allocates
    one DMA coherent piece of memory per TX queue, this patch
    might cause issues if a driver was using too many slots.

    For 1024 slots, we would need 256 KB of physically
    contiguous memory instead of 128 KB.

    Alternative fix would be to add checks in the fast path,
    but this involves more work in all drivers using net/core/tso.c.

    Fixes: f9cbe9a556af ("net: define the TSO header size in net/tso.h")
    Signed-off-by: Eric Dumazet
    Cc: Antoine Tenart
    Signed-off-by: David S. Miller

    Eric Dumazet
     

02 Nov, 2017

1 commit

  • Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

24 Aug, 2017

1 commit


27 Oct, 2015

1 commit

  • Adding IPv6 for the TSO helper API is trivial:
    * Don't play with the id (which doesn't exist in IPv6)
    * Correctly update the payload_len (don't include the
    length of the IP header itself)

    Signed-off-by: Emmanuel Grumbach
    Acked-by: Eric Dumazet
    Signed-off-by: David S. Miller

    emmanuel.grumbach@intel.com
     

23 May, 2014

1 commit