Eric Lee / smarc-fsl-linux-kernel

27 Aug, 2008

5 commits

  • 157439fa4   dccp: Toggle debug output without module unloading ... Browse Code »

    This sets the sysfs permissions so that root can toggle the `debug'
    parameter available for nearly every DCCP module. This is useful
    since there are various module inter-dependencies. The debug flag
    can now be toggled at runtime using

    echo 1 > /sys/module/dccp/parameters/dccp_debug
    echo 1 > /sys/module/dccp_ccid2/parameters/ccid2_debug
    echo 1 > /sys/module/dccp_ccid3/parameters/ccid3_debug
    echo 1 > /sys/module/dccp_tfrc_lib/parameters/tfrc_debug

    The last is not very useful yet, since no code at the moment calls
    the tfrc_debug() macro.

    Signed-off-by: Gerrit Renker

    Gerrit Renker
     
  • b569d5a13   dccp: Empty the write queue when disconnecting ... Browse Code »

    dccp_disconnect() can be called due to several reasons:

    1. when the connection setup failed (inet_stream_connect());
    2. when shutting down (inet_shutdown(), inet_csk_listen_stop());
    3. when aborting the connection (dccp_close() with 0 linger time).

    In case (1) the write queue is empty. This patch empties the write queue,
    if in case (2) or (3) it was not yet empty.

    This avoids triggering the write-queue BUG_TRAP in sk_stream_kill_queues()
    later on.

    It also seems natural to do: when breaking an association, to delete all
    packets that were originally intended for the soon-disconnected end (compare
    with call to tcp_write_queue_purge in tcp_disconnect()).

    Signed-off-by: Gerrit Renker

    Gerrit Renker
     
  • 5a056417e   dccp: Fill in the Data fields for "Option Error" Resets ... Browse Code »

    This updates the use of the `out_invalid_option' label, which produces a
    Reset (code 5, "Option Error"), to fill in the Data1...Data3 fields as
    specified in RFC 4340, 5.6.

    Signed-off-by: Gerrit Renker

    Gerrit Renker
     
  • 1efa6bbac   dccp: Silently ignore options with nonsensical lengths ... Browse Code »

    This updates the option-parsing code with regard to RFC 4340, 5.8:
    "[..] options with nonsensical lengths (length byte less than two or more
    than the remaining space in the options portion of the header) MUST be
    ignored, and any option space following an option with nonsensical length
    MUST likewise be ignored."

    Hence in the following cases erratic options will be ignored:
    1. The type byte of a multi-byte option is the last byte of the header
    options (i.e. effective option length of 1).
    2. The value of the length byte is less than the minimum 2. This has been
    changed from previously 3: although no multi-byte option with a length
    less than 3 yet exists (cf. table 3 in 5.8), a length of 2 is valid.
    (The switch-statement in dccp_parse has further per-option length checks.)
    3. The option length exceeds the length of the remaining option space.

    Signed-off-by: Gerrit Renker

    Gerrit Renker
     
  • 33c449675   dccp: Always generate a Reset in response to option errors ... Browse Code »

    RFC4340 states that if a packet is received with an option error (such as a
    Mandatory Option as the last byte of the option list), the endpoint should
    repond with a Reset.

    In the LISTEN and RESPOND states, the endpoint correctly reponds with Reset,
    while in the REQUEST/OPEN states, packets with option errors are just ignored.

    The packet sequence is as follows:

    Case 1:

    Endpoint A Endpoint B
    (CLOSED) (CLOSED)

    (*1)
    (with invalid option)
    (*2)
    (with invalid option)

    Acked-by: Arnaldo Carvalho de Melo
    Acked-by: Gerrit Renker

    Wei Yongjun
     

23 Aug, 2008

35 commits