04 Jan, 2012
1 commit
-
Signed-off-by: Al Viro
29 Oct, 2010
1 commit
-
We can mark normal_i2c const. Almost all drivers do that already, so
fix the 3 remaining ones before they are used as (bad) examples for
new drivers.Signed-off-by: Jean Delvare
Cc: George Joseph
Reviewed-by: Guenter Roeck
03 Jun, 2010
1 commit
-
I2C drivers can use the clientdata-pointer to point to private data. As I2C
devices are not really unregistered, but merely detached from their driver, it
used to be the drivers obligation to clear this pointer during remove() or a
failed probe(). As a couple of drivers forgot to do this, it was agreed that it
was cleaner if the i2c-core does this clearance when appropriate, as there is
no guarantee for the lifetime of the clientdata-pointer after remove() anyhow.
This feature was added to the core with commit
e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers.As there is no need anymore to clear the clientdata-pointer, remove all current
occurrences in the drivers to simplify the code and prevent confusion.Signed-off-by: Wolfram Sang
Acked-by: Mark Brown
Acked-by: Greg Kroah-Hartman
Acked-by: Richard Purdie
Acked-by: Dmitry Torokhov
Signed-off-by: Jean Delvare
06 Mar, 2010
3 commits
-
Recent changes on the I2C front have left off-by-one array indexes in
3 hwmon drivers. Fix them.Faulty commit:
e5e9f44c2 i2c: Drop I2C_CLIENT_INSMOD_2 to 8Reported-by: Dan Carpenter
Signed-off-by: Jean Delvare
Cc: Hans de Goede
Cc: Andre Prendel
Cc: stable@kernel.org -
The low bits of temperature registers are status bits, they must be
masked out before converting the register values to temperatures.Signed-off-by: Jean Delvare
Tested-by: Andre Prendel
Cc: stable@kernel.org -
An off-by-one error caused some inputs to not be created by the driver
when they should. TMP421 gets only one input instead of two, TMP422
gets two instead of three, etc. Fix the bug by listing explicitly the
number of inputs each device has.Signed-off-by: Jean Delvare
Tested-by: Andre Prendel
Cc: stable@kernel.org
15 Dec, 2009
3 commits
-
These macros simply declare an enum, so drivers might as well declare
it themselves. This puts an end to the arbitrary limit of 8 chip types
per i2c driver.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang -
Struct i2c_client_address_data only contains one field at this point,
which makes its usefulness questionable. Get rid of it and pass simple
address lists around instead.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang -
The "kind" parameter always has value -1, and nobody is using it any
longer, so we can remove it.Signed-off-by: Jean Delvare
Tested-by: Wolfram Sang
10 Dec, 2009
1 commit
-
As kind is now hard-coded to -1, there is room for code clean-ups.
Signed-off-by: Jean Delvare
Acked-by: Andre Prendel
15 Sep, 2009
1 commit
-
Add support for Texas Instruments TMP421/422/423 temperature sensor IC.
TI's TMP421/422/423 are I2C temperature sensor chips. These chips are
similar to TI's TMP401/411 chips, but with reduced functionality (only
temperature measurement). The chips have one local sensor and up to
three (TMP423) remote sensors.Signed-off-by: Andre Prendel
Acked-by: Hans de Goede
Signed-off-by: Jean Delvare
