Eric Lee / smarc-fsl-linux-kernel

30 Apr, 2011

1 commit

18 Dec, 2010

1 commit

31 Jul, 2010

1 commit

08 Jul, 2010

1 commit

  • 43a9aa64a   NFSD: Fill in WCC data for REMOVE, RMDIR, MKNOD, and MKDIR ... Browse Code »

    Some well-known NFSv3 clients drop their directory entry caches when
    they receive replies with no WCC data. Without this data, they
    employ extra READ, LOOKUP, and GETATTR requests to ensure their
    directory entry caches are up to date, causing performance to suffer
    needlessly.

    In order to return WCC data, our server has to have both the pre-op
    and the post-op attribute data on hand when a reply is XDR encoded.
    The pre-op data is filled in when the incoming fh is locked, and the
    post-op data is filled in when the fh is unlocked.

    Unfortunately, for REMOVE, RMDIR, MKNOD, and MKDIR, the directory fh
    is not unlocked until well after the reply has been XDR encoded. This
    means that encode_wcc_data() does not have wcc_data for the parent
    directory, so none is returned to the client after these operations
    complete.

    By unlocking the parent directory fh immediately after the internal
    operations for each NFS procedure is complete, the post-op data is
    filled in before XDR encoding starts, so it can be returned to the
    client properly.

    Signed-off-by: Chuck Lever
    Signed-off-by: J. Bruce Fields

    Chuck Lever
     

16 Dec, 2009

1 commit

15 Dec, 2009

2 commits

14 Nov, 2009

1 commit

16 Jun, 2009

1 commit

  • b9081d90f   NFS: kill off complicated macro 'PROC' ... Browse Code »

    kill off obscure macro 'PROC' of NFSv2&3 in order to make the code more clear.

    Among other things, this makes it simpler to grep for callers of these
    functions--something which has frequently caused confusion among nfs
    developers.

    Signed-off-by: Yu Zhiguo
    Signed-off-by: J. Bruce Fields

    Yu Zhiguo
     

19 Mar, 2009

2 commits

  • 31dec2538   Short write in nfsd becomes a full write to the client ... Browse Code »

    If a filesystem being written to via NFS returns a short write count
    (as opposed to an error) to nfsd, nfsd treats that as a success for
    the entire write, rather than the short count that actually succeeded.

    For example, given a 8192 byte write, if the underlying filesystem
    only writes 4096 bytes, nfsd will ack back to the nfs client that all
    8192 bytes were written. The nfs client does have retry logic for
    short writes, but this is never called as the client is told the
    complete write succeeded.

    There are probably other ways it could happen, but in my case it
    happened with a fuse (filesystem in userspace) filesystem which can
    rather easily have a partial write.

    Here is a patch to properly return the short write count to the
    client.

    Signed-off-by: David Shaw
    Signed-off-by: J. Bruce Fields

    David Shaw
     
  • 12214cb78   NFSD: cleanup for nfs3proc.c ... Browse Code »

    MSDOS_SUPER_MAGIC is defined in ,
    so use MSDOS_SUPER_MAGIC directly.

    Signed-off-by: Qinghuang Feng
    Signed-off-by: J. Bruce Fields

    Qinghuang Feng
     

30 Sep, 2008

1 commit

  • 04716e662   nfsd: permit unauthenticated stat of export root ... Browse Code »

    RFC 2623 section 2.3.2 permits the server to bypass gss authentication
    checks for certain operations that a client may perform when mounting.
    In the case of a client that doesn't have some form of credentials
    available to it on boot, this allows it to perform the mount unattended.
    (Presumably real file access won't be needed until a user with
    credentials logs in.)

    Being slightly more lenient allows lots of old clients to access
    krb5-only exports, with the only loss being a small amount of
    information leaked about the root directory of the export.

    This affects only v2 and v3; v4 still requires authentication for all
    access.

    Thanks to Peter Staubach testing against a Solaris client, which
    suggesting addition of v3 getattr, to the list, and to Trond for noting
    that doing so exposes no additional information.

    Signed-off-by: J. Bruce Fields
    Cc: Peter Staubach
    Cc: Trond Myklebust

    J. Bruce Fields
     

24 Jun, 2008

1 commit

  • 8837abcab   nfsd: rename MAY_ flags ... Browse Code »

    Rename nfsd_permission() specific MAY_* flags to NFSD_MAY_* to make it
    clear, that these are not used outside nfsd, and to avoid name and
    number space conflicts with the VFS.

    [comment from hch: rename MAY_READ, MAY_WRITE and MAY_EXEC as well]

    Signed-off-by: Miklos Szeredi
    Signed-off-by: J. Bruce Fields

    Miklos Szeredi
     

15 Feb, 2008

1 commit

  • 547754916   Use struct path in struct svc_export ... Browse Code »

    I'm embedding struct path into struct svc_export.

    [akpm@linux-foundation.org: coding-style fixes]
    [ezk@cs.sunysb.edu: NFSD: fix wrong mnt_writer count in rename]
    Signed-off-by: Jan Blunck
    Acked-by: J. Bruce Fields
    Acked-by: Christoph Hellwig
    Cc: Al Viro
    Cc: "J. Bruce Fields"
    Cc: Neil Brown
    Cc: Trond Myklebust
    Signed-off-by: Erez Zadok
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Blunck
     

10 May, 2007

1 commit

  • cd123012d   RPC: add wrapper for svc_reserve to account for checksum ... Browse Code »

    When the kernel calls svc_reserve to downsize the expected size of an RPC
    reply, it fails to account for the possibility of a checksum at the end of
    the packet. If a client mounts a NFSv2/3 with sec=krb5i/p, and does I/O
    then you'll generally see messages similar to this in the server's ring
    buffer:

    RPC request reserved 164 but used 208

    While I was never able to verify it, I suspect that this problem is also
    the root cause of some oopses I've seen under these conditions:

    https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227726

    This is probably also a problem for other sec= types and for NFSv4. The
    large reserved size for NFSv4 compound packets seems to generally paper
    over the problem, however.

    This patch adds a wrapper for svc_reserve that accounts for the possibility
    of a checksum. It also fixes up the appropriate callers of svc_reserve to
    call the wrapper. For now, it just uses a hardcoded value that I
    determined via testing. That value may need to be revised upward as things
    change, or we may want to eventually add a new auth_op that attempts to
    calculate this somehow.

    Unfortunately, there doesn't seem to be a good way to reliably determine
    the expected checksum length prior to actually calculating it, particularly
    with schemes like spkm3.

    Signed-off-by: Jeff Layton
    Acked-by: Neil Brown
    Cc: Trond Myklebust
    Acked-by: J. Bruce Fields
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Layton
     

09 Nov, 2006

1 commit

  • 81ac95c55   [PATCH] nfsd4: fix open-create permissions ... Browse Code »

    In the case where an open creates the file, we shouldn't be rechecking
    permissions to open the file; the open succeeds regardless of what the new
    file's mode bits say.

    This patch fixes the problem, but only by introducing yet another parameter
    to nfsd_create_v3. This is ugly. This will be fixed by later patches.

    Signed-off-by: J. Bruce Fields
    Acked-by: Neil Brown
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    J. Bruce Fields
     

21 Oct, 2006

2 commits

04 Oct, 2006

2 commits

  • 7adae489f   [PATCH] knfsd: Prepare knfsd for support of rsize/wsize of up to 1MB, over TCP ... Browse Code »

    The limit over UDP remains at 32K. Also, make some of the apparently
    arbitrary sizing constants clearer.

    The biggest change here involves replacing NFSSVC_MAXBLKSIZE by a function of
    the rqstp. This allows it to be different for different protocols (udp/tcp)
    and also allows it to depend on the servers declared sv_bufsiz.

    Note that we don't actually increase sv_bufsz for nfs yet. That comes next.

    Signed-off-by: Greg Banks
    Signed-off-by: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Greg Banks
     
  • 3cc03b164   [PATCH] knfsd: Avoid excess stack usage in svc_tcp_recvfrom ... Browse Code »

    .. by allocating the array of 'kvec' in 'struct svc_rqst'.

    As we plan to increase RPCSVC_MAXPAGES from 8 upto 256, we can no longer
    allocate an array of this size on the stack. So we allocate it in 'struct
    svc_rqst'.

    However svc_rqst contains (indirectly) an array of the same type and size
    (actually several, but they are in a union). So rather than waste space, we
    move those arrays out of the separately allocated union and into svc_rqst to
    share with the kvec moved out of svc_tcp_recvfrom (various arrays are used at
    different times, so there is no conflict).

    Signed-off-by: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    NeilBrown
     

11 Apr, 2006

1 commit

  • 7775f4c85   [PATCH] knfsd: Correct reserved reply space for read requests. ... Browse Code »

    NFSd makes sure there is enough space to hold the maximum possible reply
    before accepting a request. The units for this maximum is (4byte) words.
    However in three places, particularly for read request, the number given is
    a number of bytes.

    This means too much space is reserved which is slightly wasteful.

    This is the sort of patch that could uncover a deeper bug, and it is not
    critical, so it would be best for it to spend a while in -mm before going
    in to mainline.

    (akpm: target 2.6.17-rc2, 2.6.16.3 (approx))

    Discovered-by: "Eivind Sarto"
    Signed-off-by: Neil Brown
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    NeilBrown
     

07 Jan, 2006

1 commit

  • a334de286   [PATCH] knfsd: check error status from vfs_getattr and i_op->fsync ... Browse Code »

    Both vfs_getattr and i_op->fsync return error statuses which nfsd was
    largely ignoring. This as noticed when exporting directories using fuse.

    This patch cleans up most of the offences, which involves moving the call
    to vfs_getattr out of the xdr encoding routines (where it is too late to
    report an error) into the main NFS procedure handling routines.

    There is still a called to vfs_gettattr (related to the ACL code) where the
    status is ignored, and called to nfsd_sync_dir don't check return status
    either.

    Signed-off-by: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Shaw
     

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds