08 Jul, 2019

1 commit


06 May, 2019

2 commits

  • Use watchdog_stop_on_unregister() in probe instead of calling
    tegra_wdt_stop() in the remove function. Also introduce local variable
    'struct device *dev' and use it instead of dereferencing it repeatedly.
    Finally, drop the now empty remove function.

    The conversion was done automatically with coccinelle using the
    following semantic patches. The semantic patches and the scripts
    used to generate this commit log are available at
    https://github.com/groeck/coccinelle-patches

    Cc: Thierry Reding
    Cc: Jonathan Hunter
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Guenter Roeck
     
  • Use devm_platform_ioremap_resource to reduce source code size,
    improve readability, and reduce the likelyhood of bugs.

    The conversion was done automatically with coccinelle using the
    following semantic patch.

    @r@
    identifier res, pdev;
    expression a;
    expression index;
    expression e;
    @@

    @depends on r@
    identifier r.res;
    @@
    - struct resource *res;
    ... when != res

    @@
    identifier res, pdev;
    expression index;
    expression a;
    @@
    - struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, index);
    - a = devm_ioremap_resource(&pdev->dev, res);
    + a = devm_platform_ioremap_resource(pdev, index);

    Cc: Joel Stanley
    Cc: Nicolas Ferre
    Cc: Alexandre Belloni
    Cc: Florian Fainelli
    Cc: Linus Walleij
    Cc: Baruch Siach
    Cc: Keguang Zhang
    Cc: Vladimir Zapolskiy
    Cc: Kevin Hilman
    Cc: Matthias Brugger
    Cc: Avi Fishman
    Cc: Nancy Yuen
    Cc: Brendan Higgins
    Cc: Wan ZongShun
    Cc: Michal Simek
    Cc: Sylvain Lemieux
    Cc: Kukjin Kim
    Cc: Barry Song
    Cc: Orson Zhai
    Cc: Patrice Chotard
    Cc: Maxime Coquelin
    Cc: Maxime Ripard
    Cc: Chen-Yu Tsai
    Cc: Marc Gonzalez
    Cc: Thierry Reding
    Cc: Shawn Guo
    Signed-off-by: Guenter Roeck
    Acked-by: Alexandre Belloni
    Tested-by: Alexandre Belloni
    Acked-by: Joel Stanley
    Reviewed-by: Linus Walleij
    Acked-by: Maxime Ripard
    Acked-by: Michal Simek (cadence/xilinx wdts)
    Acked-by: Thierry Reding
    Reviewed-by: Florian Fainelli
    Acked-by: Patrice Chotard
    Acked-by: Vladimir Zapolskiy
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Guenter Roeck
     

24 Mar, 2018

1 commit

  • - Add SPDX identifier
    - Remove boiler plate license text
    - If MODULE_LICENSE and boiler plate does not match, go for boiler plate
    license

    Signed-off-by: Marcus Folkesson
    Acked-by: Adam Thomson
    Acked-by: Baruch Siach
    Acked-by: Charles Keepax
    Acked-by: Keiji Hayashibara
    Acked-by: Johannes Thumshirn
    Acked-by: Florian Fainelli
    Acked-by: Mans Rullgard
    Acked-by: Matthias Brugger
    Acked-by: Michal Simek
    Acked-by: Neil Armstrong
    Acked-by: Nicolas Ferre
    Acked-by: Thierry Reding
    Acked-by: Tomas Winkler
    Acked-by: Patrice Chotard
    Acked-by: William Breathitt Gray
    Reviewed-by: Eric Anholt
    Reviewed-by: Guenter Roeck
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Marcus Folkesson
     

25 Feb, 2017

1 commit

  • Use device managed functions to simplify error handling, reduce
    source code size, improve readability, and reduce the likelyhood of bugs.

    The conversion was done automatically with coccinelle using the
    following semantic patches. The semantic patches and the scripts used
    to generate this commit log are available at
    https://github.com/groeck/coccinelle-patches

    - Use devm_watchdog_register_driver() to register watchdog device

    Cc: Stephen Warren
    Cc: Thierry Reding
    Cc: Alexandre Courbot
    Signed-off-by: Guenter Roeck
    Acked-by: Thierry Reding
    Signed-off-by: Guenter Roeck

    Guenter Roeck
     

24 Sep, 2016

1 commit

  • Check for watchdog_ops structures that are only stored in the ops field of
    a watchdog_device structure. This field is declared const, so watchdog_ops
    structures that have this property can be declared as const also.

    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r disable optional_qualifier@
    identifier i;
    position p;
    @@
    static struct watchdog_ops i@p = { ... };

    @ok@
    identifier r.i;
    struct watchdog_device e;
    position p;
    @@
    e.ops = &i@p;

    @bad@
    position p != {r.p,ok.p};
    identifier r.i;
    struct watchdog_ops e;
    @@
    e@i@p

    @depends on !bad disable optional_qualifier@
    identifier r.i;
    @@
    static
    +const
    struct watchdog_ops i = { ... };
    //

    Signed-off-by: Julia Lawall
    Acked-by: Thierry Reding
    Reviewed-by: Guenter Roeck
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Julia Lawall
     

23 Nov, 2015

1 commit

  • If we need to restart the watchdog due to someone changing the timeout
    interval, stop the watchdog before restarting it. Otherwise, the new
    timeout doesn't seem to take.

    Signed-off-by: Andrew Chew
    Reviewed-by: Thierry Reding
    Reviewed-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Andrew Chew
     

10 Sep, 2015

1 commit

  • /sys/class/watchdog/watchdogn/device/modalias can help to identify the
    driver/module for a given watchdog node. However, many wdt devices do not
    set their parent and so, we do not see an entry for device in sysfs for
    such devices.

    This patch fixes parent of watchdog_device so that
    /sys/class/watchdog/watchdogn/device is populated.

    Exceptions: booke, diag288, octeon, softdog and w83627hf -- They do not
    have any parent. Not sure, how we can identify driver for these devices.

    Signed-off-by: Pratyush Anand
    Reviewed-by: Johannes Thumshirn
    Acked-by: Guenter Roeck
    Acked-by: H Hartley Sweeten
    Acked-by: Lee Jones
    Acked-by: Lubomir Rintel
    Acked-by: Maxime Coquelin
    Acked-by: Thierry Reding
    Acked-by: Viresh Kumar
    Acked-by: Linus Walleij
    Signed-off-by: Wim Van Sebroeck

    Pratyush Anand
     

20 Oct, 2014

1 commit


31 Mar, 2014

1 commit

  • Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30 and
    later). This driver will configure one watchdog timer that will reset the
    system in the case of a watchdog timeout.

    This driver binds to the nvidia,tegra30-timer device node and gets its
    register base from there.

    Signed-off-by: Andrew Chew
    Reviewed-by: Guenter Roeck
    Tested-by: Stephen Warren
    Reviewed-by: Stephen Warren
    Signed-off-by: Wim Van Sebroeck

    Andrew Chew