03 May, 2010
12 commits
-
Move the code accessing the qdio sbales and zfcp_qdio_req struct to
the zfcp_qdio files and provide helper functions for accessing the
qdio related parts.Reviewed-by: Swen Schillig
Signed-off-by: Christof Schmitt
Signed-off-by: James Bottomley -
Instead of dealing with large segments in the scatter-gather lists in
zfcp_qdio.c, report the limits to the upper layers. With these limits
in place, the code for mapping large data blocks to multiple sbales
can be removed.Reviewed-by: Swen Schillig
Signed-off-by: Christof Schmitt
Signed-off-by: James Bottomley -
Signed-off-by: Ravi Anand
Signed-off-by: James Bottomley -
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
* Handles SCSI command aborts.
* Serialization srb between error handler and command
completion path.Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
used cmd->host_scribble to store iocb command handle.
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Per RFC 3720, Login Response Status Code 0x02 should not be retried.
Condensed connection error checking code to a single routine, and
added check for status class 0x02.Signed-off-by: Karen Higgins
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Updated firmware ready timeout algorithm to prevent
long delays and use jiffies to time out instead of
counter. Also use msleep_interruptible instead of msleep.Signed-off-by: Karen Higgins
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Karen Higgins
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Link Down -> Mark all devices missing
Previously, the driver took no action on a Link Down,
and waited for the I/O on a dead connection to timeout
in the firmware before marking the DDB missing.Link Up -> Mark all devices online
F/W will do auto login to all the devices only once.
After that its the responsibility of the driver to
relogin to devices whenever there is :
* Any sort of connection failure or
* KATO expires indicating target has logged out or
* I/O times out etc.Signed-off-by: Vikas Chaudhary
Signed-off-by: Karen Higgins
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Signed-off-by: Karen Higgins
Signed-off-by: Vikas Chaudhary
Signed-off-by: Ravi Anand
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
If cxgb3i_pdu_init() fails, then it appears that cxgb3i_iscsi_init()
will not be cleaned up, leading to the iscsi transport being left
registered. Fix this by adding a call to cxgb3i_iscsi_cleanup() on the
error path.Signed-off-by: Roland Dreier
Reviewed-by: Mike Christie
Cc: Karen Xie
Signed-off-by: James Bottomley
02 May, 2010
8 commits
-
The scsi/scsi.h header is normally provided by the libc (and was not
exported by the kernel since 2.6.24) and has been until it was
re-exported with 2.6.31. The kernel version is not userspace clean and
does not appear to provide anything useable in userland over the
(e)glibc version.Signed-off-by: Tom Rini
Signed-off-by: James Bottomley -
In the original code we dereferenced "pm8001_dev" before checking if it
was null. This patch moves the dereference inside the condition.This was found by a static checker (smatch). I looked, but I couldn't
tell if "pm8001_dev" dev was ever actually null. The approach in this
patch seemed like the safest response.Signed-off-by: Dan Carpenter
Acked-by: Jack Wang
Signed-off-by: James Bottomley -
If a command times out resulting in EH getting invoked, we wait for the
aborted commands to come back after sending the abort. Shorten
the amount of time we wait for these responses, to ensure we don't
get stuck in EH for several minutes.Signed-off-by: Brian King
Signed-off-by: James Bottomley -
Commands which are completed by the VIOS are placed on a CRQ
in kernel memory for the ibmvfc driver to process. Each CRQ
entry is 16 bytes. The ibmvfc driver reads the first 8 bytes
to check if the entry is valid, then reads the next 8 bytes to get
the handle, which is a pointer the completed command. This fixes
an issue seen on Power 7 where the processor reordered the
loads from memory, resulting in processing command completion
with a stale handle. This could result in command timeouts,
and also early completion of commands.Signed-off-by: Brian King
Signed-off-by: James Bottomley -
This patch removes unnecessary #define's from hpsa. The SCSI midlayer
handles all this for us.Signed-off-by: Mike Miller
Signed-off-by: James Bottomley -
This patch fixes sdev_rw_attr() macro for scsi device sysfs entries.
It seems there is no such function snscanf in the current linux kernel,
so it fails to compile scsi driver when someone try to add a new rw entry.
This has been unfixed for a long time probably because current scsi device
has no rw entries.# grep snscanf . -rn
./drivers/scsi/scsi_sysfs.c:489: snscanf (buf, 20, format_string, &sdev->field); \Signed-off-by: Tomohiro Kusumi
Signed-off-by: James Bottomley -
Fix the compilation warning in powerpc. The same change also fixes endian
issue we found in powerpc test. This patch has been tested in x86 and
powerpc platform. it is created using scsi-misc-2.6.Signed-off-by: Jing Huang
Signed-off-by: James Bottomley -
Enhanced the driver to support new FCoE host bus adapter.
Signed-off-by: Giridhar Malavali
Signed-off-by: James Bottomley
01 May, 2010
5 commits
-
Various SCSI trace enhancements:
- Display data and protection information scatterlist lengths in the
trace output- Add support for VERIFY and WRITE SAME commands and decode the UNMAP
bit if applicable- Add decoding of the PROTECT field for READ/VERIFY/WRITE/WRITE SAME
commands as well as the EXPECTED INITIAL REFERENCE TAG field for
their 32-byte variants- Decode READ CAPACITY(16), GET LBA STATUS, and UNMAP
Signed-off-by: Martin K. Petersen
Signed-off-by: James Bottomley -
Signed-off-by: Xiao Guangrong
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Kei Tokunaga
Signed-off-by: James Bottomley -
__print_hex() prints values in an array in hex (w/o '0x') (space separated)
EX) 92 33 32 f3 ee 4dSigned-off-by: Li Zefan
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Kei Tokunaga
Acked-by: Steven Rostedt
Signed-off-by: James Bottomley -
Add definitions for VERIFY(12) and VERIFY(32).
Signed-off-by: Martin K. Petersen
Signed-off-by: James Bottomley -
Add a few clarifying comments in the B0 page function and allow the
optimal transfer length field to be specified on the command line using
opt_blks=N.Signed-off-by: Martin K. Petersen
Signed-off-by: James Bottomley
12 Apr, 2010
15 commits
-
This patch adds a bunch of fixes
1. Reduce sg table size to 64 (SG_MX) instead of default SG_ALL
2. clear task lists on phy down events
3. release all tasks on port deformation
4. release current task for device gone notification
5. Add sata abort handing
6. Add 10ms delay to each port reset (currently done serially and with
interrupts disabled)[jejb: whitespace fixes and clean ups plus added description
added dummy 94xx_clear_srs_irq function just to prevent the
mismatch in the mvs_dispatch structure killing 94xx cards]
Signed-off-by: Srinivas
Cc: Andy Yan
Cc: qswang@marvell.com
Cc: jfeng@marvell.com
Signed-off-by: James Bottomley -
iscsi_conn is not used so remove it from iscsi_sw_tcp_conn.
Signed-off-by: Avi Kaplan
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
This patch changes the arguments to iscsi_sw_tcp_conn_restore_callbacks,
so that it works like the function to set the callbacks and because
in upcoming patches we need a iscsi_conn.Signed-off-by: Avi Kaplan
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
blk_get_request sets the cmd_flags, so we should not and do not
need to set them. If we did set them to a different value then
it can cause a oops in the elevator code.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
This change is basically a clean up.
datadgst_en is an int which comes from the user. I didn't see anything
limiting it to 1 and 0 although obviously that's what it's supposed to
be. If the user passed in 2 this test would fail.This same if condition is repeated in another function and it uses &&
there.Signed-off-by: Dan Carpenter
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
Print all world wide node names (node, port and fabric) with the same
format specifier of "%16.16llx". That makes sure they all print as a
16 character hex string, with lower case letters, no 0x prefix, and
without stripping off any leading 0s.Signed-off-by: Chris Leech
Signed-off-by: Robert Love
Signed-off-by: James Bottomley -
Most of the prints of fabric IDs were specified as %6x, which will not
print any leading 0s. It's nice to see leading 0s for identifiers
like this, which are a fixed length. This patch sets the precision
modifier as well, making the specifier %6.6x, which forces the
printing of leading 0s.Signed-off-by: Chris Leech
Signed-off-by: Robert Love
Signed-off-by: James Bottomley -
fc_fcp_resp is assuming when FCP_SNS_LEN_VAL is set, the FCP_RSP_LEN_VAL
is not, which is not true. This leads to not copying the sense data and
error out a valid FCP_RSP.Signed-off-by: Yi Zou
Signed-off-by: Robert Love
Signed-off-by: James Bottomley -
No reason to restrict CDB size to 12 bytes in fcoe, so
increased to 16 so that 16 bytes SCSI CDB doesn't fail.Uses common define to set max_cmd_len for fcoe and fnic,
fnic is already setting max_cmd_len to 16.sg_readcap -l fails without this fix.
Signed-off-by: Vasu Dev
Signed-off-by: Robert Love
Signed-off-by: James Bottomley -
Signed-off-by: Vasu Dev
Signed-off-by: Robert Love
Signed-off-by: James Bottomley -
fnic_flush_tx() is used to send frames held while fabric login
is in progress. The frames are held in tx_queue, but
fnic_flush_tx() was incorrectly flushing from recv_queue which
is used for received frames.Signed-off-by: Brian Uchino
Signed-off-by: Abhijeet Joglekar
Signed-off-by: Robert Love
Signed-off-by: James Bottomley -
New fnic version to mark inclusion of tx_flush bugfix.
Signed-off-by: Brian Uchino
Signed-off-by: Abhijeet Joglekar
Signed-off-by: Robert Love
Signed-off-by: James Bottomley -
hton24(p + 3, value) would fail to compile because
p + 3[0] is not a valid expression.Went ahead and converted hton24 and ntoh24 to inline
functions, which is better because the parameters
are evalutated only once.Signed-off-by: Joe Eykholt
Signed-off-by: Robert Love
Signed-off-by: James Bottomley -
fc_exch_recv_req has variables eof, sof, and f_ctl,
which are set but never used. Delete them.Signed-off-by: Joe Eykholt
Signed-off-by: Robert Love
Signed-off-by: James Bottomley -
Allow for dormant states while link configuration completes.
In the default link mode, this is equivalent to the old check.Signed-off-by: Chris Leech
Signed-off-by: Robert Love
Signed-off-by: James Bottomley
