05 Jan, 2012

1 commit

  • rmu needs to be freed before leaving the function in an error case.

    A simplified version of the semantic match that finds the problem is as
    follows: (http://coccinelle.lip6.fr)

    //
    @r exists@
    local idexpression x;
    statement S;
    identifier f1;
    position p1,p2;
    expression *ptr != NULL;
    @@

    x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
    ...
    if (x == NULL) S
    }
    x->f1
    ...>
    (
    return \(0\|\|ptr\);
    |
    return@p2 ...;
    )

    @script:python@
    p1 << r.p1;
    p2 << r.p2;
    @@

    print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Kumar Gala

    Julia Lawall
     

24 Nov, 2011

2 commits

  • Usually, freescale rapidio endpoint can support one or two 1x or 4X
    LP-Serial link interfaces, and rapidio message transactions can be
    implemented by two message units. This adds the support of two
    rapidio ports and initializes message unit 0 and message unit 1. And
    these ports and message units can work simultaneously.

    Signed-off-by: Li Yang
    Signed-off-by: Jin Qing
    Signed-off-by: Liu Gang
    Acked-by: Alexandre Bounine
    Signed-off-by: Kumar Gala

    Liu Gang
     
  • The Freescale PowerPC RapidIO controller consists of a RapidIO endpoint and
    a RapidIO message unit(RMU). Or use RapidIO message manager(RMan) to
    replace the RMU in DPAA architecture. Therefore, we should split the code
    into two function modules according to the hardware architecture. Add new
    struct for RMU module, and new initialization function to set up RMU
    module. This policy is very conducive to adding new module like RMan, or
    adding multi-ports or message units support.

    Signed-off-by: Lian Minghuan
    Signed-off-by: Liu Gang
    Acked-by: Alexandre Bounine
    Signed-off-by: Kumar Gala

    Liu Gang