12 Jul, 2010

3 commits

  • This saves runtime memory and fixes lots of sparse warnings like this:

    CHECK arch/powerpc/sysdev/micropatch.c
    arch/powerpc/sysdev/micropatch.c:27:6: warning: symbol 'patch_2000'
    was not declared. Should it be static?
    arch/powerpc/sysdev/micropatch.c:146:6: warning: symbol 'patch_2f00'
    was not declared. Should it be static?
    ...

    Signed-off-by: Anton Vorontsov
    Signed-off-by: Kumar Gala

    Anton Vorontsov
     
  • Warnings are treated as errors for arch/powerpc code, so build fails
    with CONFIG_I2C_SPI_UCODE_PATCH=y:

    CC arch/powerpc/sysdev/micropatch.o
    cc1: warnings being treated as errors
    arch/powerpc/sysdev/micropatch.c: In function 'cpm_load_patch':
    arch/powerpc/sysdev/micropatch.c:630: warning: unused variable 'smp'
    make[1]: *** [arch/powerpc/sysdev/micropatch.o] Error 1

    And with CONFIG_USB_SOF_UCODE_PATCH=y:

    CC arch/powerpc/sysdev/micropatch.o
    cc1: warnings being treated as errors
    arch/powerpc/sysdev/micropatch.c: In function 'cpm_load_patch':
    arch/powerpc/sysdev/micropatch.c:629: warning: unused variable 'spp'
    arch/powerpc/sysdev/micropatch.c:628: warning: unused variable 'iip'
    make[1]: *** [arch/powerpc/sysdev/micropatch.o] Error 1

    This patch fixes these issues by introducing proper #ifdefs.

    Cc: [ .33, .34 ]
    Signed-off-by: Anton Vorontsov
    Signed-off-by: Kumar Gala

    Anton Vorontsov
     
  • spi_t was removed in commit 644b2a680ccc51a9ec4d6beb12e9d47d2dee98e2
    ("powerpc/cpm: Remove SPI defines and spi structs"), the commit assumed
    that spi_t isn't used anywhere outside of the spi_mpc8xxx driver. But
    it appears that the struct is needed for micropatch code. So, let's
    reintroduce the struct.

    Fixes the following build issue:

    CC arch/powerpc/sysdev/micropatch.o
    micropatch.c: In function 'cpm_load_patch':
    micropatch.c:629: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token
    micropatch.c:629: error: 'spp' undeclared (first use in this function)
    micropatch.c:629: error: (Each undeclared identifier is reported only once
    micropatch.c:629: error: for each function it appears in.)

    Reported-by: LEROY Christophe
    Reported-by: Tony Breeds
    Cc: [ .33, .34 ]
    Signed-off-by: Anton Vorontsov
    Signed-off-by: Kumar Gala

    Anton Vorontsov
     

28 Jan, 2008

1 commit


07 Feb, 2007

1 commit

  • This covers common CPM access functions, CPM interrupt controller code,
    micropatch and a few compatibility things to kee the same driver base
    working with arch/ppc. This version is refined with all the comments
    (mostly PIC-related) addressed.

    Signed-off-by: Vitaly Bordug
    Signed-off-by: Paul Mackerras

    Vitaly Bordug