Eric Lee / smarc-fsl-linux-kernel

17 Nov, 2011

2 commits

  • bd59d3a44   KVM: s390: handle SIGP sense running intercepts ... Browse Code »

    SIGP sense running may cause an intercept on higher level
    virtualization, so handle it by checking the CPUSTAT_RUNNING flag.

    Signed-off-by: Cornelia Huck
    Signed-off-by: Carsten Otte
    Signed-off-by: Avi Kivity

    Cornelia Huck
     
  • 9e6dabeff   KVM: s390: Fix RUNNING flag misinterpretation ... Browse Code »

    CPUSTAT_RUNNING was implemented signifying that a vcpu is not stopped.
    This is not, however, what the architecture says: RUNNING should be
    set when the host is acting on the behalf of the guest operating
    system.

    CPUSTAT_RUNNING has been changed to be set in kvm_arch_vcpu_load()
    and to be unset in kvm_arch_vcpu_put().

    For signifying stopped state of a vcpu, a host-controlled bit has
    been used and is set/unset basically on the reverse as the old
    CPUSTAT_RUNNING bit (including pushing it down into stop handling
    proper in handle_stop()).

    Cc: stable@kernel.org
    Signed-off-by: Cornelia Huck
    Signed-off-by: Carsten Otte
    Signed-off-by: Avi Kivity

    Cornelia Huck
     

30 Oct, 2011

1 commit

  • 7697e71f7   KVM: s390: implement sigp external call ... Browse Code »

    Implement sigp external call, which might be required for guests that
    issue an external call instead of an emergency signal for IPI.

    This fixes an issue with "KVM: unknown SIGP: 0x02" when booting
    such an SMP guest.

    Signed-off-by: Christian Ehrhardt
    Signed-off-by: Christian Borntraeger
    Signed-off-by: Marcelo Tosatti

    Christian Ehrhardt
     

24 Jul, 2011

1 commit

  • 092670cd9   [S390] Use gmap translation for accessing guest memory ... Browse Code »

    This patch removes kvm-s390 internal assumption of a linear mapping
    of guest address space to user space. Previously, guest memory was
    translated to user addresses using a fixed offset (gmsor). The new
    code uses gmap_fault to resolve guest addresses.

    Signed-off-by: Carsten Otte
    Signed-off-by: Martin Schwidefsky

    Carsten Otte
     

09 Jun, 2010

1 commit

  • 9940fa80c   [S390] arch/s390/kvm: Use GFP_ATOMIC when a lock is held ... Browse Code »

    The containing function is called from several places. At one of them, in
    the function __sigp_stop, the spin lock &fi->lock is held.

    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @gfp exists@
    identifier fn;
    position p;
    @@

    fn(...) {
    ... when != spin_unlock
    when any
    GFP_KERNEL@p
    ... when any
    }

    @locked@
    identifier gfp.fn;
    @@

    spin_lock(...)
    ... when != spin_unlock
    fn(...)

    @depends on locked@
    position gfp.p;
    @@

    - GFP_KERNEL@p
    + GFP_ATOMIC
    //

    Signed-off-by: Julia Lawall
    Acked-by: Christian Borntraeger
    Signed-off-by: Martin Schwidefsky

    Julia Lawall
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

27 Feb, 2010

1 commit

03 Dec, 2009

1 commit

  • f50146bd7   KVM: s390: Fix prefix register checking in arch/s390/kvm/sigp.c ... Browse Code »

    This patch corrects the checking of the new address for the prefix register.
    On s390, the prefix register is used to address the cpu's lowcore (address
    0...8k). This check is supposed to verify that the memory is readable and
    present.
    copy_from_guest is a helper function, that can be used to read from guest
    memory. It applies prefixing, adds the start address of the guest memory in
    user, and then calls copy_from_user. Previous code was obviously broken for
    two reasons:
    - prefixing should not be applied here. The current prefix register is
    going to be updated soon, and the address we're looking for will be
    0..8k after we've updated the register
    - we're adding the guest origin (gmsor) twice: once in subject code
    and once in copy_from_guest

    With kuli, we did not hit this problem because (a) we were lucky with
    previous prefix register content, and (b) our guest memory was mmaped
    very low into user address space.

    Cc: stable@kernel.org
    Signed-off-by: Carsten Otte
    Reported-by: Alexander Graf
    Signed-off-by: Avi Kivity

    Carsten Otte
     

10 Sep, 2009

2 commits

  • 628eb9b8a   KVM: s390: streamline memslot handling ... Browse Code »

    This patch relocates the variables kvm-s390 uses to track guest mem addr/size.
    As discussed dropping the variables at struct kvm_arch level allows to use the
    common vcpu->request based mechanism to reload guest memory if e.g. changes
    via set_memory_region.

    The kick mechanism introduced in this series is used to ensure running vcpus
    leave guest state to catch the update.

    Signed-off-by: Christian Ehrhardt
    Signed-off-by: Avi Kivity

    Christian Ehrhardt
     
  • 9ace903d1   KVM: s390: infrastructure to kick vcpus out of guest state ... Browse Code »

    To ensure vcpu's come out of guest context in certain cases this patch adds a
    s390 specific way to kick them out of guest context. Currently it kicks them
    out to rerun the vcpu_run path in the s390 code, but the mechanism itself is
    expandable and with a new flag we could also add e.g. kicks to userspace etc.

    Signed-off-by: Christian Ehrhardt
    Signed-off-by: Avi Kivity

    Christian Ehrhardt
     

07 Aug, 2009

1 commit

10 Jun, 2009

1 commit

24 Mar, 2009

1 commit

  • 2c411b48a   KVM: s390: Fix printk on SIGP set arch ... Browse Code »

    KVM on s390 does not support the ESA/390 architecture. We refuse to
    change the architecture mode and print a warning. This patch removes
    the printk for several reasons:

    o A malicious guest can flood host dmesg
    o The old message had no newline
    o there is no connection between the message and the failing guest

    This patch simply removes the printk. We already set the condition
    code to 3 - the guest knows that something went wrong.

    Reported-by: Heiko Carstens
    Signed-off-by: Christian Borntraeger
    Signed-off-by: Avi Kivity

    Christian Borntraeger
     

23 Nov, 2008

1 commit

27 Jul, 2008

1 commit

20 Jul, 2008

1 commit

  • 180c12fb2   KVM: s390: rename private structures ... Browse Code »

    While doing some tests with our lcrash implementation I have seen a
    naming conflict with prefix_info in kvm_host.h vs. addrconf.h

    To avoid future conflicts lets rename private definitions in
    asm/kvm_host.h by adding the kvm_s390 prefix.

    Signed-off-by: Christian Borntraeger
    Signed-off-by: Carsten Otte
    Signed-off-by: Avi Kivity

    Christian Borntraeger
     

27 Apr, 2008

1 commit

  • 5288fbf0e   KVM: s390: interprocessor communication via sigp ... Browse Code »

    This patch introduces in-kernel handling of _some_ sigp interprocessor
    signals (similar to ipi).
    kvm_s390_handle_sigp() decodes the sigp instruction and calls individual
    handlers depending on the operation requested:
    - sigp sense tries to retrieve information such as existence or running state
    of the remote cpu
    - sigp emergency sends an external interrupt to the remove cpu
    - sigp stop stops a remove cpu
    - sigp stop store status stops a remote cpu, and stores its entire internal
    state to the cpus lowcore
    - sigp set arch sets the architecture mode of the remote cpu. setting to
    ESAME (s390x 64bit) is accepted, setting to ESA/S390 (s390, 31 or 24 bit) is
    denied, all others are passed to userland
    - sigp set prefix sets the prefix register of a remote cpu

    For implementation of this, the stop intercept indication starts to get reused
    on purpose: a set of action bits defines what to do once a cpu gets stopped:
    ACTION_STOP_ON_STOP really stops the cpu when a stop intercept is recognized
    ACTION_STORE_ON_STOP stores the cpu status to lowcore when a stop intercept is
    recognized

    Acked-by: Martin Schwidefsky
    Signed-off-by: Christian Borntraeger
    Signed-off-by: Carsten Otte
    Signed-off-by: Carsten Otte
    Signed-off-by: Avi Kivity

    Christian Borntraeger