07 Oct, 2010

1 commit

• df9ee2927   Fix IRQ flag handling naming ... Browse Code »

  Fix the IRQ flag handling naming. In linux/irqflags.h under one configuration,
  it maps:

  local_irq_enable() -> raw_local_irq_enable()
  local_irq_disable() -> raw_local_irq_disable()
  local_irq_save() -> raw_local_irq_save()
  ...

  and under the other configuration, it maps:

  raw_local_irq_enable() -> local_irq_enable()
  raw_local_irq_disable() -> local_irq_disable()
  raw_local_irq_save() -> local_irq_save()
  ...

  This is quite confusing. There should be one set of names expected of the
  arch, and this should be wrapped to give another set of names that are expected
  by users of this facility.

  Change this to have the arch provide:

  flags = arch_local_save_flags()
  flags = arch_local_irq_save()
  arch_local_irq_restore(flags)
  arch_local_irq_disable()
  arch_local_irq_enable()
  arch_irqs_disabled_flags(flags)
  arch_irqs_disabled()
  arch_safe_halt()

  Then linux/irqflags.h wraps these to provide:

  raw_local_save_flags(flags)
  raw_local_irq_save(flags)
  raw_local_irq_restore(flags)
  raw_local_irq_disable()
  raw_local_irq_enable()
  raw_irqs_disabled_flags(flags)
  raw_irqs_disabled()
  raw_safe_halt()

  with type checking on the flags 'arguments', and then wraps those to provide:

  local_save_flags(flags)
  local_irq_save(flags)
  local_irq_restore(flags)
  local_irq_disable()
  local_irq_enable()
  irqs_disabled_flags(flags)
  irqs_disabled()
  safe_halt()

  with tracing included if enabled.

  The arch functions can now all be inline functions rather than some of them
  having to be macros.

  Signed-off-by: David Howells [X86, FRV, MN10300]
  Signed-off-by: Chris Metcalf [Tile]
  Signed-off-by: Michal Simek [Microblaze]
  Tested-by: Catalin Marinas [ARM]
  Acked-by: Thomas Gleixner
  Acked-by: Haavard Skinnemoen [AVR]
  Acked-by: Tony Luck [IA-64]
  Acked-by: Hirokazu Takata [M32R]
  Acked-by: Greg Ungerer [M68K/M68KNOMMU]
  Acked-by: Ralf Baechle [MIPS]
  Acked-by: Kyle McMartin [PA-RISC]
  Acked-by: Paul Mackerras [PowerPC]
  Acked-by: Martin Schwidefsky [S390]
  Acked-by: Chen Liqin [Score]
  Acked-by: Matt Fleming [SH]
  Acked-by: David S. Miller [Sparc]
  Acked-by: Chris Zankel [Xtensa]
  Reviewed-by: Richard Henderson [Alpha]
  Reviewed-by: Yoshinori Sato [H8300]
  Cc: starvik@axis.com [CRIS]
  Cc: jesper.nilsson@axis.com [CRIS]
  Cc: linux-cris-kernel@axis.com

  David Howells

  2010-10-07 21:08:55 +0800  

12 Jun, 2009

1 commit

• aafe4dbed   asm-generic: add generic versions of common headers ... Browse Code »

  These are all kernel internal interfaces that get copied
  around a lot. In most cases, architectures can provide
  their own optimized versions, but these generic versions
  can work as well.

  I have tried to use the most common contents of each
  header to allow existing architectures to migrate easily.

  Thanks to Remis for suggesting a number of cleanups.

  Signed-off-by: Remis Lima Baima
  Signed-off-by: Arnd Bergmann

  Arnd Bergmann

  2009-06-12 03:02:37 +0800