Eric Lee / smarc-fsl-linux-kernel

03 Dec, 2010

1 commit

  • a1087ef6a   scripts/coccinelle: update for compatability with Coccinelle 0.2.4 ... Browse Code »

    For doubleinit.cocci, Coccinelle 0.2.4 requires a comma after ... in a
    field list. Coccinelle also now behaves gracefully when a definition is
    provided for a virtual that doesn't exist, so there is no need for the
    semantic patch code to check for this case.

    Updated the documentation to reflect the fact that the best results will
    now be obtained with Coccinelle version 0.2.4 or later.

    Signed-off-by: Julia Lawall

    Julia Lawall
     

28 Oct, 2010

2 commits

13 Oct, 2010

1 commit

31 Aug, 2010

18 commits

  • 49ab7a391   Coccinelle: Add misc/ifcol.cocci ... Browse Code »

    Find confusingly indented code in or after an if. An if branch should
    be indented. The code following an if should not be indented.
    Sometimes, code after an if that is indented is actually intended to be
    part of the if branch.

    This has a high rate of false positives, because Coccinelle's column
    calculation does not distinguish between spaces and tabs, so code that
    is not visually aligned may be considered to be in the same column.

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 033456e2c   Coccinelle: Add misc/doubleinit.cocci ... Browse Code »

    Find duplicate field initializations. This has a high rate of false
    positives due to #ifdefs, which Coccinelle is not aware of in a structure
    initialization.

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • be8fe9d45   Coccinelle: Move alloc directory into api directory ... Browse Code »

    alloc contains various semantic patches related
    to the allocation APIs

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 77c272fb2   Coccinelle: Move resource_size.cocci to the api directory ... Browse Code »

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 99d653d4b   Coccinelle: Move err_cast.cocci to the api directory ... Browse Code »

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 034174598   Coccinelle: Add api/memdup_user ... Browse Code »

    Use kmemdup_user rather than duplicating its implementation
    This is a little bit restricted to reduce false positives

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 0426a97c4   Coccinelle: Add api/memdup.cocci ... Browse Code »

    Use kmemdup rather than duplicating its implementation

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 998f55232   Coccinelle: Add api/kstrdup.cocci ... Browse Code »

    Use kstrdup rather than duplicating its implementation

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 43ba21b57   Coccinelle: Add free/kfree.cocci ... Browse Code »

    Find a use after free. Values of variables may imply that some
    execution paths are not possible, resulting in false positives.
    Another source of false positives are macros such as
    SCTP_DBG_OBJCNT_DEC that do not actually evaluate their argument

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 5c3405018   Coccinelle: Add iterators/list_entry_update.cocci ... Browse Code »

    list_for_each_entry uses its first argument to get from one element of
    the list to the next, so it is usually not a good idea to reassign it.
    The first rule finds such a reassignment and the second rule checks
    that there is a path from the reassignment back to the top of the loop.

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • afc48a82f   Coccinelle: Add iterators/itnull.cocci ... Browse Code »

    Many iterators have the property that the first argument is always bound
    to a real list element, never NULL. False positives arise for some
    iterators that do not have this property, or in cases when the loop
    cursor is reassigned. The latter should only happen when the matched
    code is on the way to a loop exit (break, goto, or return).

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 404515925   Coccinelle: Add iterators/fen.cocci ... Browse Code »

    for_each_node iterators only exit normally when the loop cursor is
    NULL, so there is no point to call of_node_put on the final value.

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 54c056280   Coccinelle: Add locks/mini_lock.cocci ... Browse Code »

    Find missing unlocks. This semantic match considers the specific case
    where the unlock is missing from an if branch, and there is a lock
    before the if and an unlock after the if. False positives are due to
    cases where the if branch represents a case where the function is
    supposed to exit with the lock held, or where there is some preceding
    function call that releases the lock.

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 8aa627310   Coccinelle: Add locks/double_lock.cocci ... Browse Code »

    Find double locks. False positives may occur when some paths cannot
    occur at execution, due to the values of variables, and when there is
    an intervening function call that releases the lock.

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • e105007c1   Coccinelle: Add locks/call_kern.cocci ... Browse Code »

    Find functions that refer to GFP_KERNEL but are called with locks held.
    The proposed change of converting the GFP_KERNEL is not necessarily the
    correct one. It may be desired to unlock the lock, or to not call the
    function under the lock in the first place.

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 7703692ef   Coccinelle: Move deref_null.cocci to a more appropriate directory ... Browse Code »

    deref_null.cocci is moved to the 'null' directory
    which contains other null related rules.

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • 2e1e1605f   Coccinelle: Add null/kmerr.cocci ... Browse Code »

    This semantic patch looks for kmalloc etc that are not followed by a
    NULL check. It only gives a report in the case where there is some
    error handling code later in the function, which may be helpful
    in determining what the error handling code for the call to kmalloc etc
    should be.

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     
  • c75b81bff   Coccinelle: Add null/eno.cocci ... Browse Code »

    The various basic memory allocation functions don't return ERR_PTR

    Signed-off-by: Nicolas Palix
    Signed-off-by: Julia Lawall
    Signed-off-by: Michal Marek

    Nicolas Palix
     

12 Jun, 2010

5 commits