31 Aug, 2011

1 commit

  • On PowerPC we use _GLOBAL throughout the assembly to define symbols, but
    currently these symbols are missing from the tags generated with
    ARCH=powerpc make tags. This patch modifies the tags.sh script to
    recognise _GLOBAL(.*) so that these symbols will be in the tags.

    This is almost (but not quite) PowerPC specific and this change should
    not affect anyone else:

    $ git grep -E '^_GLOBAL\(([^)]*)\).*' |sed 's/^\([^/]*\/[^/]*\)\/.*$/\1/'|uniq -c
    627 arch/powerpc
    2 arch/um

    Signed-off-by: Ian Munsie
    Signed-off-by: Michal Marek

    Ian Munsie
     

26 May, 2011

2 commits

  • Seems that Peter Zijlstra treats us emacs users as second class
    citizens and the commit:

    commit 15664125f7cadcb6d725cb2d9b90f9715397848d
    Author: Peter Zijlstra
    scripts/tags.sh: Add magic for trace-events

    only updated ctags (for vim) and did not do the work to let us
    lowly emacs users benefit from such a change.

    Cc: Peter Zijlstra
    Signed-off-by: Steven Rostedt

    Steven Rostedt
     
  • The regex to handle DEFINE_EVENT() should not be the same as
    the TRACE_EVENT() as the first parameter in DEFINE_EVENT is the
    template name, not the event name. We need the second parameter
    as that is what the trace_... will use.

    Tested-by: Peter Zijlstra
    Signed-off-by: Steven Rostedt

    Steven Rostedt
     

21 Mar, 2011

1 commit


15 Jan, 2011

1 commit


11 Jan, 2011

1 commit

  • * 'misc' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6:
    Documentation/kbuild: add info that 'choice' can have a symbol name
    kbuild: add numeric --set-val option to scripts/config
    headers_check: Fix warning text
    headers_check: better search for functions in headers
    scripts/coccinelle: update for compatability with Coccinelle 0.2.4
    tags: put function prototypes back!
    Kconfig: fix single letter command in scripts/config
    gitignore: add scripts/recordmcount

    Linus Torvalds
     

02 Dec, 2010

2 commits

  • Make tags find the trace-event definitions

    Acked-by: WANG Cong
    Signed-off-by: Peter Zijlstra
    LKML-Reference:
    Signed-off-by: Steven Rostedt

    Peter Zijlstra
     
  • Commit 7db86dc (ctags: usability fix) removed function prototypes from
    tags file claiming "It makes no real sense to include function
    prototypes".
    But it is useful for quickly determining which header file developer
    needs to include to fix compilation.

    Now if someone wants to remove forward declarations (which I agree are
    baggage), write a postprocessing script.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Michal Marek

    Uwe Kleine-König
     

08 Mar, 2010

1 commit

  • This reverts commit eb8f844c0a41c4529a7d06b7801296eca9ae67aa. Ian
    Campbell writes:
    > I keep my kernel source tree on a more powerful build box where I run my
    > builds etc (including "make cscope") but run my editor from my
    > workstation with an NFS mount to the source. This worked fine for me
    > using relative paths for cscope. Using absolute paths in cscope breaks
    > this previously working setup because the root path is not the same on
    > both systems. I guess this is similar to moving the source tree around.
    >
    > Without wanting to start a flamewar it really sounds to me like we are
    > working around a vim (or cscope) bug here, emacs with cscope bindings
    > works fine in this configuration.

    Given that absolute paths can be forced by make O=. cscope, change the
    default back to relative paths.

    Ian Campbell
    Cc: Daniel Vetter
    Signed-off-by: Michal Marek

    Michal Marek
     

03 Mar, 2010

2 commits


22 Feb, 2010

1 commit

  • $ make mrproper
    $ make tags
    GEN tags
    find: `arch/x86_64/': No such file or directory

    Caused by commit f81b1be (tags: include headers before source files)

    Cc: Guennadi Liakhovetski
    Acked-by: WANG Cong
    Signed-off-by: Michal Marek

    Michal Marek
     

17 Feb, 2010

1 commit

  • Currently looking up a structure definition in TAGS / tags takes one to
    one of multiple "static struct X" definitions in arch sources, which makes
    it for many structs practically impossible to get to the required header.
    This patch changes the order of sources being tagged to first scan
    architecture includes, then the top-level include/ directory, and only
    then the rest. It also takes into account, that many architectures have
    more than one include directory, i.e., not only arch/$ARCH/include, but
    also arch/$ARCH/mach-X/include etc.

    Signed-off-by: Guennadi Liakhovetski
    Reviewed-by: WANG Cong
    [mmarek@suse.cz: fix 'var+=text' bashism]
    Signed-off-by: Michal Marek

    Guennadi Liakhovetski
     

12 Dec, 2009

1 commit

  • Cscope doesn't hadle relative paths when cscope.out is not in $PWD. Use
    absolute paths when generating cscope.files, which seems to be the
    recommended way to generate cscope.out, anyway (at least according to
    cscope.sf.net). The speed and size differences are minimal, the only
    drawback is that the database needs to be regenerated if the source
    directory is moved.

    [mmarek: fixed for O= builds, modified changelog]

    Signed-off-by: Daniel Vetter
    Signed-off-by: Michal Marek

    Daniel Vetter
     

20 Sep, 2009

1 commit

  • The tag file generated by the tags.sh script has some issue.

    First:
    The identifier-list miss the
    DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL
    special handling, which can result in a wrong tag, not to jump to the
    right variable definition or function implementation.

    Second:
    It makes no real sense to include function prototypes and external and
    forward variable declarations, because jumping to a tag will sometimes
    go to this and not to the real definition and implementation. The information
    about the declaration is still there at the definition and implementation
    place.

    So this patch make it lot easier to navigate through the kernel source
    tree using vi.

    Signed-off-by: Stefani Seibold
    Acked-by: WANG Cong
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Stefani Seibold
     

01 May, 2009

1 commit


15 Feb, 2009

2 commits

  • Currently, it is no longer possible to use the tags file to jump to
    system call function definitions with sys_foo, because the definitions
    are obscured by use of the SYSCALL_DEFINE* macros.

    This patch adds the appropriate option to ctags to make it see through
    the macro. Also, it adds the ENTRY() work already done for Exuberant
    to Emacs too.

    Signed-off-by: Rabin Vincent
    Signed-off-by: Sam Ravnborg

    Rabin Vincent
     
  • commit 4f628248a578585472e19e4cba2c604643af8c6c aka "kbuild: reintroduce
    ALLSOURCE_ARCHS support for tags/cscope" breaks tags generation for
    Kconfig symbols.

    Steps to reproduce:

    make tags
    vi -t PROC_FS

    It should jump to 'config PROC_FS' line.

    Signed-off-by: Alexey Dobriyan
    Tested-by: Pete Wyckoff
    Signed-off-by: Andrew Morton
    Signed-off-by: Sam Ravnborg

    Alexey Dobriyan
     

08 Jan, 2009

1 commit

  • This patch reintroduce the ALLSOURCE_ARCHS support for tags/TAGS/
    cscope targets. The Kbuild previously has this feature, but after
    moving the targets into scripts/tags.sh, ALLSOURCE_ARCHS disappears.

    It's something like this:

    $ make ALLSOURCE_ARCHS="x86 mips arm" tags cscope

    Signed-off-by: Jike Song
    Signed-off-by: Sam Ravnborg

    Jike Song
     

03 Jan, 2009

1 commit


14 Dec, 2008

2 commits


04 Dec, 2008

1 commit

  • as they do not benefit from the make functionality.

    Moving the support to a shell script has several benefits:
    - The readability of the code has increased a lot
    - More people is able to extend the tags support
    - We see less changes to the top-level Makefile

    The shell script version includes improvements from:
    Alexey Dobriyan (jump to kconfig symbols)
    Alexey Dobriyan (drop ./ in paths)
    Ian Campbell (simplified find algorithms)

    This version has a few caveats:
    => It does not support ALLSOURCE_ARCHS
    - it is easy to add if it is really used
    => It assumes all archs have moved to arch/$ARCH/include
    - until that happens we have a few additional hits in the archs

    Signed-off-by: Sam Ravnborg
    Cc: Alexey Dobriyan
    Tested-by: Ian Campbell

    Sam Ravnborg