19 Dec, 2011

1 commit

  • module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

01 Nov, 2011

1 commit


22 Sep, 2011

1 commit

  • Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
    We run all interrupt handlers with interrupts disabled
    and we even check and yell when an interrupt handler
    returns with interrupts enabled (see commit [b738a50a:
    genirq: Warn when handler enables interrupts]).

    So now this flag is a NOOP and can be removed.

    Signed-off-by: Yong Zhang
    Acked-by: Peter Ujfalusi
    Acked-by: Mark Brown
    Signed-off-by: Takashi Iwai

    Yong Zhang
     

14 Sep, 2011

1 commit

  • The semantics of snd_mpu401_uart_new()'s interrupt parameters are
    somewhat counterintuitive: To prevent the function from allocating its
    own interrupt, either the irq number must be invalid, or the irq_flags
    parameter must be zero. At the same time, the irq parameter being
    invalid specifies that the mpu401 code has to work without an interrupt
    allocated by the caller. This implies that, if there is an interrupt
    and it is allocated by the caller, the irq parameter must be set to
    a valid-looking number which then isn't actually used.

    With the removal of IRQF_DISABLED, zero becomes a valid irq_flags value,
    which forces us to handle the parameters differently.

    This patch introduces a new flag MPU401_INFO_IRQ_HOOK for when the
    device interrupt is handled by the caller, and makes the allocation of
    the interrupt to depend only on the irq parameter. As suggested by
    Takashi, the irq_flags parameter was dropped because, when used, it had
    the constant value IRQF_DISABLED.

    Signed-off-by: Clemens Ladisch
    Signed-off-by: Takashi Iwai

    Clemens Ladisch
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

04 Dec, 2009

1 commit


08 Nov, 2009

1 commit

  • 1. Set the third argument of the snd_device_new to not NULL, so there is
    no warning about bug during chip detection. The third argument is not
    used in this driver. It was changed in my previous patch.

    2. Remove the fm_port and mpu_port fields from the snd_es18xx structure.
    They can be converted to function arguments.

    3. Remove the dmaN_size fields from the snd_es18xx structure. These
    values are used only in pointer functions and can be easily calculated.

    4. Remove the ctrl_lock spinlock which is used only in one read function
    which is called once during chip initialization. There are many
    writes to the same register and they are not protected on purpose
    (see the comment ina the snd_es18xx_config_write()).

    5. Use the first part of the text5Sources string table as the text4Soruces
    table (they are the same).

    6. Merge the same cases for the ES1887 and ES1888 when setting chip's caps.

    7. Move the snd_es18xx_reset() to __devinit section.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai

    Krzysztof Helt
     

05 Nov, 2009

1 commit

  • To avoid confusion in control names for the standard analog PC Beep generator
    using a small Internal PC Speaker, rename all related "PC Speaker" and "PC
    Beep" controls to "Beep" only. This name is more universal and can be also
    used on more platforms without confusion.

    Introduce also "Internal Speaker" in ControlNames.txt for systems with
    full-featured build-in internal speaker.

    Signed-off-by: Jaroslav Kysela
    Signed-off-by: Takashi Iwai

    Jaroslav Kysela
     

30 Oct, 2009

2 commits


12 Jan, 2009

2 commits


01 Feb, 2008

4 commits

  • This header file exists only for some hacks to adapt alsa-driver
    tree. It's useless for building in the kernel. Let's move a few
    lines in it to sound/core.h and remove it.
    With this patch, sound/driver.h isn't removed but has just a single
    compile warning to include it. This should be really killed in
    future.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • This patch enables wavetable chips ES689/ES69X connected to
    ESS ES18xx chips. The wavetable chip uses FM DAC if the clock signal
    from the wavetable is active.
    It has no effect if there is no ESS wavetable chip present.

    Signed-off-by: Krzysztof Helt
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Krzysztof Helt
     
  • Signed-off-by: Joe Perches
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Joe Perches
     
  • This removes the pnp_resource_change use from the ALSA ISAPnP drivers. In
    2.4 these were useful in providing an easy path to setting the resources,
    but in 2.6 they retain function as a layering violation only.
    This makes for a nice cleanup (-550 lines) of ALSA but moreover, ALSA is the
    only remaining user of pnp_init_resource_table(), pnp_resource_change() and
    pnp_manual_config_dev() (and, in fact, of 'struct pnp_resource_table') in
    the tree outide of drivers/pnp itself meaning it makes for more cleanup
    potential inside the PnP layer.
    Thomas Renninger acked their removal from that side, you did from the ALSA
    side (CC list just copied from that thread).
    Against current alsa-kernel HG. Many more potential cleanups in there, but
    this _only_ removes the pnp_resource_change code. Compile tested against
    current alsa-kernel HG and compile- and use-tested against 2.6.23.x (few
    offsets).
    Cc: Thomas Renninger

    Signed-off-by: Rene Herman
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Rene Herman
     

20 Oct, 2007

1 commit


16 Oct, 2007

2 commits


16 May, 2007

1 commit


11 May, 2007

2 commits


07 Oct, 2006

1 commit


05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

23 Sep, 2006

1 commit

  • This patch adds PnP BIOS support to es18xx driver. It allows ESS ES18xx sound
    chips integrated in some notebooks (such as DTK FortisPro TOP-5A) that don't
    appear as ISA cards (they aren't recognized by ISA PnP, only by PnP BIOS)
    to 'just work' automatically.

    Signed-off-by: Ondrej Zary
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Ondrej Zary
     

03 Jul, 2006

1 commit


28 Jun, 2006

1 commit


22 May, 2006

1 commit

  • sound/isa/es18xx.c: In function `snd_es18xx_identify':
    sound/isa/es18xx.c:1606: warning: implicit declaration of function `udelay'

    Cc: Jaroslav Kysela
    Cc: Takashi Iwai
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     

12 Apr, 2006

2 commits


28 Mar, 2006

1 commit


22 Mar, 2006

6 commits

  • Modules: Generic drivers,ES18xx driver,CS46xx driver

    This patch fixes two memory leaks spotted by the Coverity checker.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Takashi Iwai

    Adrian Bunk
     
  • Fix the check of enable module option in probe of platform_device drivers.
    It shouldn't break the loop but just ignore if enable[i] is false.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • Modules: ES18xx driver

    Forth of 4 es18xx.c patches culminating in Zoom Video support.

    This patch adds Zoom Video support for those chipsets that support it.

    Testing:
    This work was initially done on the source from the Debian Sarge ALSA
    package, then tested
    on an ES1879. I could not test the Zoom Video function for an ES1878 or
    ES1869.
    Patches were created against the Sarge code and then edited to apply
    correctly to the
    ALSA cvs code. Lastly the patched ALSA cvs code was test for successful
    compilation.
    No additional testing was done on the ALSA cvs version.

    One quirk (noted in my comments below) is that apparently the datasheet
    is wrong
    for one of the ES1879 Zoom Video 'enable' bits, because
    1) if you set this bit it messes up PCM playback (speaker_test play a
    lower frequency)
    2) even if you don't set this bit Zoom Video still works.
    I added a control to toggle the bit on just in case there might be a
    version of the
    ES1879 that requires it, but I expect noone will need it.

    Signed-off-by: Mark Salazar
    Signed-off-by: Takashi Iwai

    Mark Salazar
     
  • Modules: ES18xx driver

    Third of 4 es18xx.c patches culminating in Zoom Video support.

    This patch changes the Hardware Volume support to reflect the fact that
    not all of the
    supported chipsets have seperate registers dedicated to the Hardware
    Volume inputs. Although
    all the chipsets can generate an HWV interrupt whenever a Hardware
    Volume input is received
    only those with seperate HWV registers can split the HWV registers from
    the Master volume
    registers.

    Testing:
    This work was initially done on the source from the Debian Sarge ALSA
    package, then tested
    on an ES1879 and an ES1878 machine. Patches were created against the
    Sarge code and then edited
    to apply correctly to the ALSA cvs code. Lastly the patched ALSA cvs
    code was test for
    successful compilation. No additional testing was done on the ALSA cvs
    version.

    Signed-off-by: Mark Salazar
    Signed-off-by: Takashi Iwai

    Mark Salazar
     
  • Modules: ES18xx driver

    Second of 4 es18xx.c patches culminating in Zoom Video support.

    This patch changes the 'record source' mux routines to reflect the fact
    that not all of the
    supported chipsets have 8 possible inputs. Some have 4 and some have 5.

    Testing:
    This work was initially done on the source from the Debian Sarge ALSA
    package, then tested
    on an ES1879 and an ES1878 machine. Patches were created against the
    Sarge code and then edited
    to apply correctly to the ALSA cvs code. Lastly the patched ALSA cvs
    code was test for
    successful compilation. No additional testing was done on the ALSA cvs
    version.

    Signed-off-by: Mark Salazar
    Signed-off-by: Takashi Iwai

    Mark Salazar
     
  • Modules: ES18xx driver

    First of 4 es18xx.c patches culminating in Zoom Video support.
    While adding support for Zoom Video to the es18xx driver I found some of
    the mixer controls
    were wrong. Since you guys went to the trouble of supplying the
    datasheets for the supported
    chipsets I did a review of all of them and tried to get es18xx.c to
    accurately reflect the
    proper mixer controls for each chipset. If the datasheets are wrong then
    so are my patches.

    This first patch moves some controls from the common-to-all-chipsets array
    'snd_es18xx_base_controls' to a chipset-specific array and adds code to
    manage that new array.
    Also while testing on my ES1878 test machine I discovered it needed a
    couple of udelays in
    the identify function so those are in this patch as well.

    Testing:
    This work was initially done on the source from the Debian Sarge ALSA
    package, then tested
    on an ES1879 and an ES1878 machine. Patches were created against the
    Sarge code and then edited
    to apply correctly to the ALSA cvs code. Lastly the patched ALSA cvs
    code was test for
    successful compilation. No additional testing was done on the ALSA cvs
    version.

    Signed-off-by: Mark Salazar
    Signed-off-by: Takashi Iwai

    Mark Salazar
     

22 Jan, 2006

1 commit


03 Jan, 2006

2 commits