Eric Lee / smarc-fsl-linux-kernel

19 Dec, 2011

1 commit

  • a67ff6a54   ALSA: module_param: make bool parameters really bool ... Browse Code »

    module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

01 Nov, 2011

1 commit

10 Jun, 2011

2 commits

  • 934c2b6d0   ALSA: use KBUILD_MODNAME for request_irq argument in sound/pci/* ... Browse Code »

    The name argument of request_irq() appears in /proc/interrupts, and
    it's quite ugly when the name entry contains a space or special letters.
    In general, it's simpler and more readable when the module name appears
    there, so let's replace all entries with KBUILD_MODNAME.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • 3733e424c   ALSA: Use KBUILD_MODNAME for pci_driver.name entries ... Browse Code »

    The convention for pci_driver.name entry in kernel drivers seem to be
    the module name or equivalent ones. But, so far, almost all PCI sound
    drivers use more verbose name like "ABC Xyz (12)", and these are fairly
    confusing when appearing as a file name.

    This patch converts the all pci_driver.name entries in sound/pci/* to
    use KBUILD_MODNAME for more unified appearance.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

09 Feb, 2010

1 commit

30 Oct, 2009

1 commit

  • 4b3be6afa   ALSA: sound: Move dereference after NULL test and drop unnecessary NULL tests ... Browse Code »

    In pcm.c, if the NULL test on pcm is needed, then the dereference should be
    after the NULL test.

    In dummy.c and ali5451.c, the context of the calls to
    snd_card_dummy_new_mixer and snd_ali_free_voice show that dummy and pvoice,
    respectively cannot be NULL.

    A simplified version of the semantic match that detects this problem is as
    follows (http://coccinelle.lip6.fr/):

    //
    @match exists@
    expression x, E;
    identifier fld;
    @@

    * x->fld
    ... when != \(x = E\|&x\)
    * x == NULL
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Takashi Iwai

    Julia Lawall
     

24 Aug, 2009

2 commits

07 Apr, 2009

1 commit

24 Mar, 2009

1 commit

20 Mar, 2009

1 commit

12 Jan, 2009

1 commit

24 Apr, 2008

2 commits

  • f000fd809   [ALSA] Fix synchronize_irq() bugs, redundancies ... Browse Code »

    free_irq() calls synchronize_irq() for you, so there is no need for
    drivers to manually do the same thing (again). Thus, calls where
    sync-irq immediately precedes free-irq can be simplified.

    However, during this audit several bugs were noticed, where free-irq is
    preceded by a "irq >= 0" check... but the sync-irq call is not covered
    by the same check.

    So, where sync-irq could not be eliminated completely, the missing check
    was added.

    Signed-off-by: Jeff Garzik
    Signed-off-by: Takashi Iwai

    Jeff Garzik
     
  • c74056d43   [ALSA] sound: ali5451.c fix shadowed variable warnings ... Browse Code »

    enable is used to test for whether or not spdif should be enabled,
    change to spdif_enable.

    sound/pci/ali5451/ali5451.c:1812:15: warning: symbol 'enable' shadows an earlier one
    sound/pci/ali5451/ali5451.c:63:12: originally declared here
    sound/pci/ali5451/ali5451.c:1840:27: warning: symbol 'enable' shadows an earlier one
    sound/pci/ali5451/ali5451.c:63:12: originally declared here

    Signed-off-by: Harvey Harrison
    Signed-off-by: Takashi Iwai

    Harvey Harrison
     

01 Feb, 2008

1 commit

  • 9004acc70   [ALSA] Remove sound/driver.h ... Browse Code »

    This header file exists only for some hacks to adapt alsa-driver
    tree. It's useless for building in the kernel. Let's move a few
    lines in it to sound/core.h and remove it.
    With this patch, sound/driver.h isn't removed but has just a single
    compile warning to include it. This should be really killed in
    future.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

16 Oct, 2007

2 commits

20 Jul, 2007

2 commits

12 Jul, 2007

1 commit

  • 44c10138f   PCI: Change all drivers to use pci_device->revision ... Browse Code »
    86

    Instead of all drivers reading pci config space to get the revision
    ID, they can now use the pci_device->revision member.

    This exposes some issues where drivers where reading a word or a dword
    for the revision number, and adding useless error-handling around the
    read. Some drivers even just read it for no purpose of all.

    In devices where the revision ID is being copied over and used in what
    appears to be the equivalent of hotpath, I have left the copy code
    and the cached copy as not to influence the driver's performance.

    Compile tested with make all{yes,mod}config on x86_64 and i386.

    Signed-off-by: Auke Kok
    Acked-by: Dave Jones
    Signed-off-by: Greg Kroah-Hartman

    Auke Kok
     

31 May, 2007

1 commit

11 May, 2007

2 commits

  • f9ab2b1c3   [ALSA] ali5451 - Code clean up, irq handler fix ... Browse Code »

    - Clean up ali5451.c, following the standard coding style, unneeded codes
    reduced, and removal of redundant variable initializations.
    Hungarian notation isn't fixed yet ;)
    - Fix irq handler to return IRQ_NONE properly for shared irqs.
    Also check the hardware availability in irq handler to avoid possible
    initialization races at loading the driver.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • ef991b95a   [ALSA] Add snd_pcm_group_for_each_entry() for code cleanup ... Browse Code »

    Added a new macro snd_pcm_group_for_each_entry() just for code cleanup.
    Old macros, snd_pcm_group_for_each() and snd_pcm_group_substream_entry(),
    are removed.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

06 Mar, 2007

1 commit

20 Dec, 2006

1 commit

  • 437a5a460   [ALSA] Remove IRQF_DISABLED for shared PCI irqs ... Browse Code »

    Fix IRQ flags for PCI devices.
    The shared IRQs for PCI devices shouldn't be allocated with
    IRQF_DISABLED. Also, when MSI is enabled, IRQF_SHARED shouldn't
    be used.
    The patch removes unnecessary cast in request_irq and free_irq,
    too.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

22 Oct, 2006

1 commit

  • 30b35399c   [ALSA] Various fixes for suspend/resume of ALSA PCI drivers ... Browse Code »

    - Check the return value of pci_enable_device() and request_irq()
    in the suspend. If any error occurs there, disable the device
    using snd_card_disconnect().
    - Call pci_set_power_state() properly with pci_choose_state().
    - Fix the order to call pci_set_power_state().
    - Removed obsolete house-made PM codes in some drivers.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

13 Jul, 2006

1 commit

03 Jul, 2006

1 commit

23 Jun, 2006

2 commits

28 Apr, 2006

1 commit

29 Mar, 2006

1 commit

22 Jan, 2006

1 commit

03 Jan, 2006

3 commits

11 Nov, 2005

1 commit

04 Nov, 2005

2 commits