Eric Lee / smarc-fsl-linux-kernel

19 Dec, 2011

1 commit

  • a67ff6a54   ALSA: module_param: make bool parameters really bool ... Browse Code »

    module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

01 Nov, 2011

2 commits

10 Jun, 2011

2 commits

  • 934c2b6d0   ALSA: use KBUILD_MODNAME for request_irq argument in sound/pci/* ... Browse Code »

    The name argument of request_irq() appears in /proc/interrupts, and
    it's quite ugly when the name entry contains a space or special letters.
    In general, it's simpler and more readable when the module name appears
    there, so let's replace all entries with KBUILD_MODNAME.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • 3733e424c   ALSA: Use KBUILD_MODNAME for pci_driver.name entries ... Browse Code »

    The convention for pci_driver.name entry in kernel drivers seem to be
    the module name or equivalent ones. But, so far, almost all PCI sound
    drivers use more verbose name like "ABC Xyz (12)", and these are fairly
    confusing when appearing as a file name.

    This patch converts the all pci_driver.name entries in sound/pci/* to
    use KBUILD_MODNAME for more unified appearance.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

31 Mar, 2011

1 commit

11 Nov, 2010

1 commit

13 Apr, 2010

3 commits

07 Apr, 2010

2 commits

  • 84db18bbe   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6 ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
    ALSA: mixart: range checking proc file
    ALSA: hda - Fix a wrong array range check in patch_realtek.c
    ALSA: ASoC: move dma_data from snd_soc_dai to snd_soc_pcm_stream
    ALSA: hda - Enable amplifiers on Acer Inspire 6530G
    ASoC: Only do WM8994 bias off transition from standby
    ASoC: Don't use DCS_DATAPATH_BUSY for WM hubs devices
    ASoC: Don't do runtime wm_hubs DC servo updates if using offset correction
    ASoC: Support second DC servo readback method for wm_hubs
    ASoC: Avoid wraparound in wm_hubs DC servo correction
    ALSA: echoaudio - Eliminate use after free
    ALSA: i2c: cleanup: change parameter to pointer
    ALSA: hda - Add MSI blacklist for Aopen MZ915-M
    ASoC: OMAP: Fix capture pointer handling for OMAP1510 to work correctly with recent ALSA PCM code
    ALSA: hda - Update document about MSI and interrupts
    ALSA: hda: Fix 0 dB offset for Lenovo Thinkpad models using AD1981
    ALSA: hda - Add missing printk argument in previous patch
    ASoC: Fix passing platform_data to ac97 bus users and fix a leak
    ALSA: hda - Fix ADC/MUX assignment of ALC269 codec
    ALSA: hda - Fix invalid bit values passed to snd_hda_codec_amp_stereo()
    ASoC: wm8994: playback => capture

    Linus Torvalds
     
  • b0cc58a25   ALSA: mixart: range checking proc file ... Browse Code »

    The original code doesn't take into consideration that the value of
    MIXART_BA0_SIZE - pos can be less than zero which would lead to a large
    unsigned value for "count".

    Also I moved the check that read size is a multiple of 4 bytes below
    the code that adjusts "count".

    Signed-off-by: Dan Carpenter
    Cc:
    Acked-by: Linus Torvalds
    Signed-off-by: Takashi Iwai

    Dan Carpenter
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

09 Feb, 2010

1 commit

25 Jun, 2009

1 commit

07 Apr, 2009

1 commit

24 Mar, 2009

3 commits

18 Mar, 2009

1 commit

05 Feb, 2009

2 commits

12 Jan, 2009

1 commit

25 Dec, 2008

1 commit

21 Dec, 2008

1 commit

18 Dec, 2008

1 commit

27 Nov, 2008

1 commit

  • 73f6a12ed   ALSA: sound/pci/mixart/mixart.c: Add missing snd_card_free ... Browse Code »

    The function snd_mixart_create creates a link between mgr and card that
    allows snd_mixart_free to free card as well. But if snd_mixart_create
    fails, then the link has not been created and card has to be freed explicitly.

    The semantic match that finds the problem is as follows:
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @r exists@
    local idexpression x;
    statement S,S1;
    position p1,p2,p3;
    expression E,E1;
    type T,T1;
    expression *ptr != NULL;
    @@

    (
    if ((x@p1 = snd_card_new(...)) == NULL) S
    |
    x@p1 = snd_card_new(...);
    )
    ... when != snd_card_free(...,(T)x,...)
    when != if (...) { }
    when != true x == NULL || ...
    when != x = E
    when != E = (T)x
    when any
    (
    if (x == NULL || ...) S1
    |
    if@p2 (...) {
    ... when != snd_card_free(...,(T1)x,...)
    when != if (...) { }
    when != x = E1
    when != E1 = (T1)x
    (
    return \(0\|\|ptr\);
    |
    return@p3 ...;
    )
    }
    )

    @ script:python @
    p1 << r.p1;
    p3 << r.p3;
    @@

    print "* file: %s snd_card_new: %s return: %s" % (p1[0].file,p1[0].line,p3[0].line)

    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Takashi Iwai

    Julia Lawall
     

21 Oct, 2008

1 commit

  • 2f5ad54ea   pci: use pci_ioremap_bar() in sound/ ... Browse Code »

    Use the newly introduced pci_ioremap_bar() function in sound/.
    pci_ioremap_bar() just takes a pci device and a bar number, with the goal
    of making it really hard to get wrong, while also having a central place
    to stick sanity checks.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Takashi Iwai

    Arjan van de Ven
     

13 Aug, 2008

1 commit

10 Jul, 2008

1 commit

  • fd4f80de4   Fix a const pointer usage warning in the Digigram miXart soundcard driver ... Browse Code »

    Fix a const pointer usage warning in the Digigram miXart soundcard driver. A
    const pointer is being passed to copy_from_user() to load the firmware into.
    This is okay in this case because the function has allocated the firmware
    struct itself, but the const qualifier is part of the firmware struct - so the
    patch casts the const away.

    Signed-off-by: David Howells
    Signed-off-by: David Woodhouse

    David Howells
     

01 Feb, 2008

2 commits

  • 9004acc70   [ALSA] Remove sound/driver.h ... Browse Code »

    This header file exists only for some hacks to adapt alsa-driver
    tree. It's useless for building in the kernel. Let's move a few
    lines in it to sound/core.h and remove it.
    With this patch, sound/driver.h isn't removed but has just a single
    compile warning to include it. This should be really killed in
    future.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • ab2dac2bd   [ALSA] mixart - Check value range in ctl callbacks ... Browse Code »

    Check the value ranges in ctl put callbacks properly.
    Also fixed some coding style issues around that.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

16 Oct, 2007

4 commits

18 Jul, 2007

1 commit

  • 44052e0d9   mixart: Add missing vmalloc.h include ... Browse Code »

    Fixes the following build error:
    CC sound/pci/mixart/mixart_hwdep.o
    sound/pci/mixart/mixart_hwdep.c: In function ‘mixart_hwdep_dsp_load’:
    sound/pci/mixart/mixart_hwdep.c:610: error: implicit declaration of function ‘vmalloc’
    sound/pci/mixart/mixart_hwdep.c:617: error: implicit declaration of function ‘vfree’

    Signed-off-by: Frank Lichtenheld
    Signed-off-by: Linus Torvalds

    Frank Lichtenheld
     

11 May, 2007

1 commit

09 May, 2007

1 commit

09 Feb, 2007

1 commit