24 Jun, 2007
5 commits
-
Having walked through the entire skbuff, skb_seq_read would leave the
last fragment mapped. As a consequence, the unwary caller would leak
kmaps, and proceed with preempt_count off by one. The only (kind of
non-intuitive) workaround is to use skb_seq_read_abort.This patch makes sure skb_seq_read always unmaps frag_data after
having cycled through the skb's paged part.Signed-off-by: Olaf Kirch
Signed-off-by: David S. Miller -
This moves the local_irq_enable() call in net_rx_action() to before
calling the CONFIG_NET_DMA's dma_async_memcpy_issue_pending() rather
than after. This shortens the irq disabled window and allows for DMA
drivers that need to do their own irq hold.Signed-off-by: Shannon Nelson
Signed-off-by: David S. Miller -
tcp_read_sock() currently assumes that the recv_actor() only returns
number of bytes copied. For network splice receive, we may have to
return an error in some cases. So allow the actor to return a negative
error value.Signed-off-by: Jens Axboe
Signed-off-by: David S. Miller -
The tipc netlink config handler uses the nlmsg_pid from the
request header as destination for its reply. If the application
initialized nlmsg_pid to 0, the reply is looped back to the kernel,
causing hangup. Fix: use nlmsg_pid of the skb that triggered the
request.Signed-off-by: Florian Westphal
Signed-off-by: David S. Miller -
secmark doesn't depend on CONFIG_NET_SCHED.
Signed-off-by: Patrick McHardy
Acked-by: James Morris
Signed-off-by: David S. Miller
23 Jun, 2007
3 commits
-
Bug reported by Haruhito Watanabe .
Signed-off-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller -
There is no realistic situation to change helper (Who wants IRC helper to
track FTP traffic ?). Moreover, if we want to do that, we need to fix race
issue by nfctnetlink and running helper. That will add overhead to packet
processing. It wouldn't pay. So this rejects the request to change
helper. The requests to add or remove helper are accepted as ever.Signed-off-by: Yasuyuki Kozakai
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
Signed-off-by: Jerome Borsboom
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller
19 Jun, 2007
3 commits
-
Return the number of bytes buffered in rxrpc_send_data().
Signed-off-by: David Howells
Signed-off-by: David S. Miller -
ip_vs currently fails to reset its ip_vs_sync_state variable if the
sync thread fails to start properly. The result is that the kernel
will report a running daemon when their actuall is none.If you issue the following commands:
1. ipvsadm --start-daemon master --mcast-interface bla
2. ipvsadm -L --daemon
3. ipvsadm --stop-daemon masterAssuming that bla is not an actual interface, step 2 should return no
data, but instead returns:$ ipvsadm -L --daemon
master sync daemon (mcast=bla, syncid=0)Signed-off-by: Neil Horman
Signed-off-by: David S. Miller -
My IPsec MTU optimization patch introduced a regression in MTU calculation
for non-ESP SAs, the SA's header_len needs to be subtracted from the MTU if
the transform doesn't provide a ->get_mtu() function.Reported-and-tested-by: Marco Berizzi
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller
16 Jun, 2007
3 commits
-
This patch fixes a NULL dereference spotted by the Coverity checker.
Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
Commit 6f74651ae626ec672028587bc700538076dfbefb is found guilty
of breaking DSACK counting, which should be done only for the
SACK block reported by the DSACK instead of every SACK block
that is received along with DSACK information.Signed-off-by: Ilpo Järvinen
Signed-off-by: David S. Miller -
Commit 164891aadf1721fca4dce473bb0e0998181537c6 broke RTT
sampling of congestion control modules. Inaccurate timestamps
could be fed to them without providing any way for them to
identify such cases. Previously RTT sampler was called only if
FLAG_RETRANS_DATA_ACKED was not set filtering inaccurate
timestamps nicely. In addition, the new behavior could give an
invalid timestamp (zero) to RTT sampler if only skbs with
TCPCB_RETRANS were ACKed. This solves both problems.Signed-off-by: Ilpo Järvinen
Signed-off-by: David S. Miller
15 Jun, 2007
3 commits
-
The recent patch that added ipv6_hwtype is broken on tuntap tunnels.
Indeed, it's broken on any device that does not pass the ipv6_hwtype
test.The reason is that the original test only applies to autoconfiguration,
not IPv6 support. IPv6 support is allowed on any device. In fact,
even with the ipv6_hwtype patch applied you can still add IPv6 addresses
to any interface that doesn't pass thw ipv6_hwtype test provided that
they have a sufficiently large MTU. This is a serious problem because
come deregistration time these devices won't be cleaned up properly.I've gone back and looked at the rationale for the patch. It appears
that the real problem is that we were creating IPv6 devices even if the
MTU was too small. So here's a patch which fixes that and reverts the
ipv6_hwtype stuff.Thanks to Kanru Chen for reporting this issue.
Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
This flaw does not affect any behavior (currently).
Signed-off-by: Ilpo Järvinen
Signed-off-by: David S. Miller
14 Jun, 2007
6 commits
-
Right now, when we receive a mtu estimate smaller then minim
threshold in the ICMP message, we disable the path mtu discovery
on the transport. This leads to the never increasing sctp fragmentation
point even when the real path mtu has increased.Signed-off-by: Vlad Yasevich
-
Currently, if the socket is owned by the user, we drop the ICMP
message. As a result SCTP forgets that path MTU changed and
never adjusting it's estimate. This causes all subsequent
packets to be fragmented. With this patch, we'll flag the association
that it needs to udpate it's estimate based on the already updated
routing information.Signed-off-by: Vlad Yasevich
Acked-by: Sridhar Samudrala -
Introduce new function sctp_transport_update_pmtu that updates
the transports and destination caches view of the path mtu.Signed-off-by: Vlad Yasevich
Acked-by: Sridhar Samudrala -
If the copy_to_user or copy_user calls fail in sctp_getsockopt_local_addrs(),
the function should free locally allocated storage before returning error.
Spotted by Coverity.Signed-off-by: Vlad Yasevich
Acked-by: Sridhar Samudrala -
Allow sctp_bindx() to accept multiple address with
unspecified port. In this case, all addresses inherit
the first bound port. We still catch full mis-matches.Signed-off-by: Vlad Yasevich
Acked-by: Sridhar Samudrala -
During peeloff of AF_INET6 socket, the inet6_sk(sk)->daddr
wasn't set correctly since the code was assuming IPv4 only.
Now we use a correct call to set the destination address.Signed-off-by: Vlad Yasevich
Acked-by: Sridhar Samudrala
13 Jun, 2007
4 commits
-
Because of the current default of 100, Cubic and BIC perform very
poorly compared to standard Reno.In the worst case, this change makes Cubic and BIC as aggressive as
Reno. So this change should be very safe.Signed-off-by: David S. Miller
-
Without FRTO, the tcp_try_to_open is never called with
lost_out > 0 (see tcp_time_to_recover). However, when FRTO is
enabled, the !tp->lost condition is not used until end of FRTO
because that way TCP avoids premature entry to fast recovery
during FRTO.Signed-off-by: Ilpo Järvinen
Signed-off-by: David S. Miller -
Signed-off-by: David S. Miller
12 Jun, 2007
3 commits
-
mac80211 stops the tx queues during scans. This is wrong with respect
to the master deivce tx queue, since stopping it prevents any probes
from being sent during the scan. Instead, they accumulate in the queue
and are only sent after the scan is finished, which is obviously
wrong.Signed-off-by: Mattias Nissler
Signed-off-by: John W. Linville -
This patch fixes a typo in mac80211's debugfs.c.
Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
Fix signedness mixup making mac addresses show up strangely
(like 00:11:22:33:44:ffffffaa) in /sys/class/ieee80211/*/macaddress.Signed-off-by: David Lamparter
Acked-by: Johannes Berg
Signed-off-by: John W. Linville
09 Jun, 2007
5 commits
-
Jean II was right: you have to re-charge the final timer when
resending rejected frames. Otherwise it triggers at a wrong time and
can break the currently running communication. Reproducible under
rt-preempt.Signed-off-by: G. Liakhovetski
Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller -
From: G. Liakhovetski
We need to switch to NRM _before_ sending the final packet otherwise
we might hit a race condition where we get the first packet from the
peer while we're still in LAP_XMIT_P.Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller -
IPv4 options are not very well aligned within the packet and the
format of a CIPSO option is even worse. The result is that the CIPSO
engine in the kernel does a few unaligned accesses when parsing and
validating incoming packets with CIPSO options attached which generate
error messages on certain alignment sensitive platforms. This patch
fixes this by marking these unaligned accesses with the
get_unaliagned() macro.Signed-off-by: Paul Moore
Acked-by: James Morris
Signed-off-by: David S. Miller -
The current NetLabel code has some redundant APIs which allow both
"struct socket" and "struct sock" types to be used; this may have made
sense at some point but it is wasteful now. Remove the functions that
operate on sockets and convert the callers. Not only does this make
the code smaller and more consistent but it pushes the locking burden
up to the caller which can be more intelligent about the locks. Also,
perform the same conversion (socket to sock) on the SELinux/NetLabel
glue code where it make sense.Signed-off-by: Paul Moore
Acked-by: James Morris
Signed-off-by: David S. Miller -
Now that we create idev before addresses are added, it no longer makes
sense to remove them when addresses are all deleted.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller
08 Jun, 2007
5 commits
-
Currently we check for permission before deleting entries from SAD and
SPD, (see security_xfrm_policy_delete() security_xfrm_state_delete())
However we are not checking for authorization when flushing the SPD and
the SAD completely. It was perhaps missed in the original security hooks
patch.This patch adds a security check when flushing entries from the SAD and
SPD. It runs the entire database and checks each entry for a denial.
If the process attempting the flush is unable to remove all of the
entries a denial is logged the the flush function returns an error
without removing anything.This is particularly useful when a process may need to create or delete
its own xfrm entries used for things like labeled networking but that
same process should not be able to delete other entries or flush the
entire database.Signed-off-by: Joy Latten
Signed-off-by: Eric Paris
Signed-off-by: James Morris -
cbq and atm destroy their filters twice when destroying inner classes
during qdisc destruction.Reported-and-tested-by: Strobl Anton
Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller -
When changing the link state from userspace not affecting any other
flags. Two duplicate notification are being sent, once as action
in the NETDEV_UP/NETDEV_DOWN notification chain and a second time
when comparing old and new device flags after the change has been
completed. Although harmless, the duplicates should be avoided.Signed-off-by: Thomas Graf
Signed-off-by: David S. Miller -
This reverts changesets:
6aaf47fa48d3c44280810b1b470261d340e4ed87
b7b5f487ab39bc10ed0694af35651a03d9cb97ff
de34ed91c4ffa4727964a832c46e624dd1495cf5
fc038410b4b1643766f8033f4940bcdb1dace633There are still some correctness issues recently
discovered which do not have a known fix that doesn't
involve doing a full hash table scan on port bind.So revert for now.
Signed-off-by: David S. Miller
-
A recv() on an AF_UNIX, SOCK_STREAM socket can race with a
send()+close() on the peer, causing recv() to return zero, even though
the sent data should be received.This happens if the send() and the close() is performed between
skb_dequeue() and checking sk->sk_shutdown in unix_stream_recvmsg():process A skb_dequeue() returns NULL, there's no data in the socket queue
process B new data is inserted onto the queue by unix_stream_sendmsg()
process B sk->sk_shutdown is set to SHUTDOWN_MASK by unix_release_sock()
process A sk->sk_shutdown is checked, unix_release_sock() returns zeroI'm surprised nobody noticed this, it's not hard to trigger. Maybe
it's just (un)luck with the timing.It's possible to work around this bug in userspace, by retrying the
recv() once in case of a zero return value.Signed-off-by: Miklos Szeredi
Signed-off-by: David S. Miller
