25 Jun, 2009

1 commit


29 May, 2009

2 commits


07 Apr, 2009

1 commit


24 Mar, 2009

1 commit


17 Feb, 2009

1 commit


05 Feb, 2009

1 commit


12 Jan, 2009

1 commit


21 Oct, 2008

1 commit

  • Use the newly introduced pci_ioremap_bar() function in sound/.
    pci_ioremap_bar() just takes a pci device and a bar number, with the goal
    of making it really hard to get wrong, while also having a central place
    to stick sanity checks.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Takashi Iwai

    Arjan van de Ven
     

25 Aug, 2008

1 commit


13 Aug, 2008

1 commit


27 May, 2008

1 commit


24 Apr, 2008

2 commits

  • free_irq() calls synchronize_irq() for you, so there is no need for
    drivers to manually do the same thing (again). Thus, calls where
    sync-irq immediately precedes free-irq can be simplified.

    However, during this audit several bugs were noticed, where free-irq is
    preceded by a "irq >= 0" check... but the sync-irq call is not covered
    by the same check.

    So, where sync-irq could not be eliminated completely, the missing check
    was added.

    Signed-off-by: Jeff Garzik
    Signed-off-by: Takashi Iwai

    Jeff Garzik
     
  • sound/pci/au88x0/au88x0_pcm.c:508:15: warning: Using plain integer as NULL pointer

    Also some small codingstyle fixes.

    Signed-off-by: Harvey Harrison
    Signed-off-by: Takashi Iwai

    Harvey Harrison
     

01 Feb, 2008

2 commits

  • This header file exists only for some hacks to adapt alsa-driver
    tree. It's useless for building in the kernel. Let's move a few
    lines in it to sound/core.h and remove it.
    With this patch, sound/driver.h isn't removed but has just a single
    compile warning to include it. This should be really killed in
    future.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     
  • Signed-off-by: Joe Perches
    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Joe Perches
     

20 Oct, 2007

1 commit


16 Oct, 2007

4 commits


12 Jul, 2007

1 commit

  • Instead of all drivers reading pci config space to get the revision
    ID, they can now use the pci_device->revision member.

    This exposes some issues where drivers where reading a word or a dword
    for the revision number, and adding useless error-handling around the
    read. Some drivers even just read it for no purpose of all.

    In devices where the revision ID is being copied over and used in what
    appears to be the equivalent of hotpath, I have left the copy code
    and the cached copy as not to influence the driver's performance.

    Compile tested with make all{yes,mod}config on x86_64 and i386.

    Signed-off-by: Auke Kok
    Acked-by: Dave Jones
    Signed-off-by: Greg Kroah-Hartman

    Auke Kok
     

11 May, 2007

1 commit


20 Dec, 2006

1 commit

  • Fix IRQ flags for PCI devices.
    The shared IRQs for PCI devices shouldn't be allocated with
    IRQF_DISABLED. Also, when MSI is enabled, IRQF_SHARED shouldn't
    be used.
    The patch removes unnecessary cast in request_irq and free_irq,
    too.

    Signed-off-by: Takashi Iwai
    Signed-off-by: Jaroslav Kysela

    Takashi Iwai
     

07 Oct, 2006

1 commit


05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

13 Jul, 2006

1 commit


03 Jul, 2006

1 commit


23 Jun, 2006

5 commits


28 Apr, 2006

1 commit


12 Apr, 2006

2 commits

  • Modules: au88x0 driver

    since idx is used as an index for vortex_pcm_prettyname[VORTEX_PCM_LAST],
    it should not be equal to VORTEX_PCM_LAST. This fixes coverity bug id #572

    Signed-off-by: Eric Sesterhenn
    Signed-off-by: Takashi Iwai

    Eric Sesterhenn
     
  • Modules: au88x0 driver

    Removed all use of __devinit/__devexit and init.h from headers. Any
    attributes given in the prototype but not in the function definition have
    been moved to the definition.

    An exception is vortex_eq_free: I removed the __devexit attribute because
    vortex_eq_free is called from vortex_core_shutdown, and
    vortex_core_shutdown may be called from __devinit snd_vortex_create.

    Compile tested with allyesconfig and allmodconfig.

    Signed-off-by: Dale Sedivec
    Signed-off-by: Takashi Iwai

    Dale Sedivec
     

22 Mar, 2006

2 commits


22 Jan, 2006

1 commit


03 Jan, 2006

1 commit

  • Modules: au88x0 driver

    pci_dma_supported() is called right before pci_set_dma_mask() which already
    calls pci_dma_supported(). The attached patch removes the unneeded call to
    pci_dma_supported()

    Additionally the custom VORTEX_DMA_MASK macro is replaced by DMA_32BIT_MASK
    from linux/dma-mapping.h

    Signed-off-by: Tobias Klauser
    Signed-off-by: Andrew Morton
    Signed-off-by: Takashi Iwai

    Tobias Klauser