09 Feb, 2018

2 commits

  • Pull nfsd update from Bruce Fields:
    "A fairly small update this time around. Some cleanup, RDMA fixes,
    overlayfs fixes, and a fix for an NFSv4 state bug.

    The bigger deal for nfsd this time around was Jeff Layton's
    already-merged i_version patches"

    * tag 'nfsd-4.16' of git://linux-nfs.org/~bfields/linux:
    svcrdma: Fix Read chunk round-up
    NFSD: hide unused svcxdr_dupstr()
    nfsd: store stat times in fill_pre_wcc() instead of inode times
    nfsd: encode stat->mtime for getattr instead of inode->i_mtime
    nfsd: return RESOURCE not GARBAGE_ARGS on too many ops
    nfsd4: don't set lock stateid's sc_type to CLOSED
    nfsd: Detect unhashed stids in nfsd4_verify_open_stid()
    sunrpc: remove dead code in svc_sock_setbufsize
    svcrdma: Post Receives in the Receive completion handler
    nfsd4: permit layoutget of executable-only files
    lockd: convert nlm_rqst.a_count from atomic_t to refcount_t
    lockd: convert nlm_lockowner.count from atomic_t to refcount_t
    lockd: convert nsm_handle.sm_count from atomic_t to refcount_t

    Linus Torvalds
     
  • The time values in stat and inode may differ for overlayfs and stat time
    values are the correct ones to use. This is also consistent with the fact
    that fill_post_wcc() also stores stat time values.

    This means introducing a stat call that could fail, where previously we
    were just copying values out of the inode. To be conservative about
    changing behavior, we fall back to copying values out of the inode in
    the error case. It might be better just to clear fh_pre_saved (though
    note the BUG_ON in set_change_info).

    Signed-off-by: Amir Goldstein
    Signed-off-by: J. Bruce Fields

    Amir Goldstein
     

29 Jan, 2018

1 commit


02 Nov, 2017

1 commit

  • Many source files in the tree are missing licensing information, which
    makes it harder for compliance tools to determine the correct license.

    By default all files without license information are under the default
    license of the kernel, which is GPL version 2.

    Update the files which contain no license information with the 'GPL-2.0'
    SPDX license identifier. The SPDX identifier is a legally binding
    shorthand, which can be used instead of the full boiler plate text.

    This patch is based on work done by Thomas Gleixner and Kate Stewart and
    Philippe Ombredanne.

    How this work was done:

    Patches were generated and checked against linux-4.14-rc6 for a subset of
    the use cases:
    - file had no licensing information it it.
    - file was a */uapi/* one with no licensing information in it,
    - file was a */uapi/* one with existing licensing information,

    Further patches will be generated in subsequent months to fix up cases
    where non-standard license headers were used, and references to license
    had to be inferred by heuristics based on keywords.

    The analysis to determine which SPDX License Identifier to be applied to
    a file was done in a spreadsheet of side by side results from of the
    output of two independent scanners (ScanCode & Windriver) producing SPDX
    tag:value files created by Philippe Ombredanne. Philippe prepared the
    base worksheet, and did an initial spot review of a few 1000 files.

    The 4.13 kernel was the starting point of the analysis with 60,537 files
    assessed. Kate Stewart did a file by file comparison of the scanner
    results in the spreadsheet to determine which SPDX license identifier(s)
    to be applied to the file. She confirmed any determination that was not
    immediately clear with lawyers working with the Linux Foundation.

    Criteria used to select files for SPDX license identifier tagging was:
    - Files considered eligible had to be source code files.
    - Make and config files were included as candidates if they contained >5
    lines of source
    - File already had some variant of a license header in it (even if
    Reviewed-by: Philippe Ombredanne
    Reviewed-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

13 Jul, 2017

1 commit

  • Factoring ctime into the nfsv4 change attribute gives us better
    properties than just i_version alone.

    Eventually we'll likely also expose this (as opposed to raw i_version)
    to userspace, at which point we'll want to move it to a common helper,
    called from either userspace or individual filesystems. For now, nfsd
    is the only user.

    Signed-off-by: J. Bruce Fields

    J. Bruce Fields
     

23 Jan, 2016

1 commit

  • parallel to mutex_{lock,unlock,trylock,is_locked,lock_nested},
    inode_foo(inode) being mutex_foo(&inode->i_mutex).

    Please, use those for access to ->i_mutex; over the coming cycle
    ->i_mutex will become rwsem, with ->lookup() done with it held
    only shared.

    Signed-off-by: Al Viro

    Al Viro
     

15 Jan, 2016

1 commit

  • Add some new tracepoints in the nfsd read/write codepaths. The idea
    is that this will give us the ability to measure how long each phase of
    a read or write operation takes.

    Signed-off-by: Jeff Layton
    Signed-off-by: J. Bruce Fields

    Jeff Layton
     

13 Oct, 2015

2 commits


16 Apr, 2015

1 commit


13 Feb, 2015

1 commit

  • We're supposed to be testing that the fh_fsid's match but because the
    parenthesis are in the wrong place, then we only check the first
    byte.

    Fixes: 9558f2500a20 ('nfsd: add fh_fsid_match helper')
    Signed-off-by: Dan Carpenter
    Signed-off-by: J. Bruce Fields

    Dan Carpenter
     

03 Feb, 2015

2 commits


23 Jun, 2014

1 commit


07 May, 2014

1 commit

  • The only real user of this header is fs/nfsd/nfsfh.h, so merge the
    two. Various lockѕ source files used it to indirectly get other
    sunrpc or nfs headers, so fix those up.

    Signed-off-by: Christoph Hellwig
    Signed-off-by: J. Bruce Fields

    Christoph Hellwig
     

30 Mar, 2014

1 commit

  • Testing NFS4.0 by pynfs, I got some messeages as,
    "nfsd: inode locked twice during operation."

    When one compound RPC contains two or more ops that locks
    the filehandle,the second op will cause the message.

    As two SETATTR ops, after the first SETATTR, nfsd will not call
    fh_put() to release current filehandle, it means filehandle have
    unlocked with fh_post_saved = 1.
    The second SETATTR find fh_post_saved = 1, and printk the message.

    v2: introduce helper fh_clear_wcc().

    Signed-off-by: Kinglong Mee
    Signed-off-by: J. Bruce Fields

    Kinglong Mee
     

25 Oct, 2013

1 commit


04 Jan, 2012

1 commit


14 Oct, 2010

1 commit

  • As of commit 43a9aa64a2f4330a9cb59aaf5c5636566bce067c "NFSD:
    Fill in WCC data for REMOVE, RMDIR, MKNOD, and MKDIR", we sometimes call
    fh_unlock on a filehandle that isn't fully initialized.

    We should fix up the callers, but as a quick fix it is also sufficient
    just to remove this assertion.

    Reported-by: Marius Tolzmann
    Cc: Chuck Lever
    Signed-off-by: J. Bruce Fields

    J. Bruce Fields
     

16 Dec, 2009

1 commit