Eric Lee / smarc-fsl-linux-kernel

11 Feb, 2017

1 commit

  • db91af0fb   crypto: algapi - make crypto_xor() and crypto_inc() alignment agnostic ... Browse Code »

    Instead of unconditionally forcing 4 byte alignment for all generic
    chaining modes that rely on crypto_xor() or crypto_inc() (which may
    result in unnecessary copying of data when the underlying hardware
    can perform unaligned accesses efficiently), make those functions
    deal with unaligned input explicitly, but only if the Kconfig symbol
    HAVE_EFFICIENT_UNALIGNED_ACCESS is set. This will allow us to drop
    the alignmasks from the CBC, CMAC, CTR, CTS, PCBC and SEQIV drivers.

    For crypto_inc(), this simply involves making the 4-byte stride
    conditional on HAVE_EFFICIENT_UNALIGNED_ACCESS being set, given that
    it typically operates on 16 byte buffers.

    For crypto_xor(), an algorithm is implemented that simply runs through
    the input using the largest strides possible if unaligned accesses are
    allowed. If they are not, an optimal sequence of memory accesses is
    emitted that takes the relative alignment of the input buffers into
    account, e.g., if the relative misalignment of dst and src is 4 bytes,
    the entire xor operation will be completed using 4 byte loads and stores
    (modulo unaligned bits at the start and end). Note that all expressions
    involving misalign are simply eliminated by the compiler when
    HAVE_EFFICIENT_UNALIGNED_ACCESS is defined.

    Signed-off-by: Ard Biesheuvel
    Signed-off-by: Herbert Xu

    Ard Biesheuvel
     

21 Oct, 2016

2 commits

  • f16743e0c   crypto: cmac - fix alignment of 'consts' ... Browse Code »

    The per-transform 'consts' array is accessed as __be64 in
    crypto_cmac_digest_setkey() but was only guaranteed to be aligned to
    __alignof__(long). Fix this by aligning it to __alignof__(__be64).

    Signed-off-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Eric Biggers
     
  • 48ee41bf5   crypto: cmac - return -EINVAL if block size is unsupported ... Browse Code »

    cmac_create() previously returned 0 if a cipher with a block size other
    than 8 or 16 bytes was specified. It should return -EINVAL instead.
    Granted, this doesn't actually change any behavior because cryptomgr
    currently ignores any return value other than -EAGAIN from template
    ->create() functions.

    Signed-off-by: Eric Biggers
    Signed-off-by: Herbert Xu

    Eric Biggers
     

26 Nov, 2014

1 commit

  • 4943ba16b   crypto: include crypto- module prefix in template ... Browse Code »

    This adds the module loading prefix "crypto-" to the template lookup
    as well.

    For example, attempting to load 'vfat(blowfish)' via AF_ALG now correctly
    includes the "crypto-" prefix at every level, correctly rejecting "vfat":

    net-pf-38
    algif-hash
    crypto-vfat(blowfish)
    crypto-vfat(blowfish)-all
    crypto-vfat

    Reported-by: Mathias Krause
    Signed-off-by: Kees Cook
    Acked-by: Mathias Krause
    Signed-off-by: Herbert Xu

    Kees Cook
     

25 Apr, 2013

1 commit

  • 93b5e86a6   crypto: add CMAC support to CryptoAPI ... Browse Code »

    Patch adds support for NIST recommended block cipher mode CMAC to CryptoAPI.

    This work is based on Tom St Denis' earlier patch,
    http://marc.info/?l=linux-crypto-vger&m=135877306305466&w=2

    Cc: Tom St Denis
    Signed-off-by: Jussi Kivilinna
    Acked-by: David S. Miller
    Signed-off-by: Herbert Xu

    Jussi Kivilinna