Eric Lee / smarc-fsl-linux-kernel

05 Oct, 2006

1 commit

  • 7d12e780e   IRQ: Maintain regs pointer globally rather than passing to IRQ handlers ... Browse Code »

    Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

25 Sep, 2006

1 commit

  • a319a2773   Merge branch 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6 ... Browse Code »

    * 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6: (217 commits)
    net/ieee80211: fix more crypto-related build breakage
    [PATCH] Spidernet: add ethtool -S (show statistics)
    [NET] GT96100: Delete bitrotting ethernet driver
    [PATCH] mv643xx_eth: restrict to 32-bit PPC_MULTIPLATFORM
    [PATCH] Cirrus Logic ep93xx ethernet driver
    r8169: the MMIO region of the 8167 stands behin BAR#1
    e1000, ixgb: Remove pointless wrappers
    [PATCH] Remove powerpc specific parts of 3c509 driver
    [PATCH] s2io: Switch to pci_get_device
    [PATCH] gt96100: move to pci_get_device API
    [PATCH] ehea: bugfix for register access functions
    [PATCH] e1000 disable device on PCI error
    drivers/net/phy/fixed: #if 0 some incomplete code
    drivers/net: const-ify ethtool_ops declarations
    [PATCH] ethtool: allow const ethtool_ops
    [PATCH] sky2: big endian
    [PATCH] sky2: fiber support
    [PATCH] sky2: tx pause bug fix
    drivers/net: Trim trailing whitespace
    [PATCH] ehea: IBM eHEA Ethernet Device Driver
    ...

    Manually resolved conflicts in drivers/net/ixgb/ixgb_main.c and
    drivers/net/sky2.c related to CHECKSUM_HW/CHECKSUM_PARTIAL changes by
    commit 84fa7933a33f806bbbaae6775e87459b1ec584c0 that just happened to be
    next to unrelated changes in this update.

    Linus Torvalds
     

23 Sep, 2006

1 commit

14 Sep, 2006

1 commit

13 Sep, 2006

2 commits

12 Sep, 2006

2 commits

01 Sep, 2006

7 commits

20 Aug, 2006

1 commit

13 Jul, 2006

1 commit

  • 4626dd46f   [PATCH] 8139cp.c printk fix ... Browse Code »

    drivers/net/8139cp.c: In function 'cp_init_one':
    drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'resource_size_t'
    drivers/net/8139cp.c:1919: warning: format '%lx' expects type 'long unsigned int', but argument 5 has type 'resource_size_t'

    Signed-off-by: Andrew Morton
    Signed-off-by: Jeff Garzik

    Andrew Morton
     

06 Jul, 2006

2 commits

03 Jul, 2006

1 commit

01 Jul, 2006

1 commit

28 Jun, 2006

2 commits

23 Jun, 2006

3 commits

  • 7967168ce   [NET]: Merge TSO/UFO fields in sk_buff ... Browse Code »

    Having separate fields in sk_buff for TSO/UFO (tso_size/ufo_size) is not
    going to scale if we add any more segmentation methods (e.g., DCCP). So
    let's merge them.

    They were used to tell the protocol of a packet. This function has been
    subsumed by the new gso_type field. This is essentially a set of netdev
    feature bits (shifted by 16 bits) that are required to process a specific
    skb. As such it's easy to tell whether a given device can process a GSO
    skb: you just have to and the gso_type field and the netdev's features
    field.

    I've made gso_type a conjunction. The idea is that you have a base type
    (e.g., SKB_GSO_TCPV4) that can be modified further to support new features.
    For example, if we add a hardware TSO type that supports ECN, they would
    declare NETIF_F_TSO | NETIF_F_TSO_ECN. All TSO packets with CWR set would
    have a gso_type of SKB_GSO_TCPV4 | SKB_GSO_TCPV4_ECN while all other TSO
    packets would be SKB_GSO_TCPV4. This means that only the CWR packets need
    to be emulated in software.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     
  • 722fdb335   [PATCH] 8139cp: add ethtool eeprom support ... Browse Code »

    Implement the ethtool eeprom operations for the 8139cp driver.
    Tested on x86 and big-endian ARM.

    Signed-off-by: Philip Craig
    Signed-off-by: Jeff Garzik

    Philip Craig
     
  • d73f1e3c3   [PATCH] 8139cp: fix eeprom read command length ... Browse Code »

    The read command for the 93C46/93C56 EEPROMS should be 3 bits plus
    the address. This doesn't appear to affect the operation of the
    read command, but similar errors for write commands do cause failures.

    Signed-off-by: Philip Craig
    Signed-off-by: Jeff Garzik

    Philip Craig
     

27 May, 2006

1 commit

02 Apr, 2006

1 commit

04 Mar, 2006

1 commit

28 Feb, 2006

1 commit

  • 576cfa934   8139cp: fix broken suspend/resume ... Browse Code »

    - check that the device is up before it is enabled again;
    - the descriptor ring indexes must be set to zero before
    cp_init_hw() is issued. Add a nice comment to remember
    that skb allocation failure is still not handled.

    Fixes http://bugzilla.kernel.org/show_bug.cgi?id=5681

    Signed-off-by: Francois Romieu

    Francois Romieu
     

22 Sep, 2005

1 commit

16 Sep, 2005

1 commit

14 Sep, 2005

2 commits

19 Aug, 2005

1 commit

29 Jun, 2005

1 commit

  • 689be4394   [NET]: Remove gratuitous use of skb->tail in network drivers. ... Browse Code »

    Many drivers use skb->tail unnecessarily.

    In these situations, the code roughly looks like:

    dev = dev_alloc_skb(...);

    [optional] skb_reserve(skb, ...);

    ... skb->tail ...

    But even if the skb_reserve() happens, skb->data equals
    skb->tail. So it doesn't make any sense to use anything
    other than skb->data in these cases.

    Another case was the s2io.c driver directly mucking with
    the skb->data and skb->tail pointers. It really just wanted
    to do an skb_reserve(), so that's what the code was changed
    to do instead.

    Another reason I'm making this change as it allows some SKB
    cleanups I have planned simpler to merge. In those cleanups,
    skb->head, skb->tail, and skb->end pointers are removed, and
    replaced with skb->head_room and skb->tail_room integers.

    Signed-off-by: David S. Miller
    Acked-by: Jeff Garzik

    David S. Miller
     

27 Jun, 2005

2 commits

13 May, 2005

2 commits