02 Dec, 2006

1 commit

  • etherh and a handful of other odd drivers use different macros when building
    8390.c. Since we generate a single 8390.o and then link with it, in any
    config with both oddball and normal 8390-based driver we will end up with
    breakage in at least one of them. Solution: take most of 8390.c into
    lib8390.c and have 8390.c, etherh.c and the rest of oddballs #include it.
    Helper macros are taken from 8390.h to whoever includes lib8390.c. That
    way odd drivers get separate instances of compiled 8390 stuff and stop
    stepping on each other's toes. 8390.h gets cleaned up - we don't have
    the cascade of ifdefs in there and are left with the stuff that can be
    used by any 8390-based driver. Current problems are exactly because of
    that cascade - we attempt to choose the set of helpers by looking at config
    and that, of course, doesn't work well when we have several sets needed
    by various drivers in our config.

    Signed-off-by: Al Viro
    Signed-off-by: Jeff Garzik

    Al Viro
     

07 Oct, 2006

1 commit


05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

30 Sep, 2006

1 commit

  • Introduce the disable_irq_nosync_lockdep_irqsave() and
    enable_irq_lockdep_irqrestore() APIs. These are needed for NE2000; basically
    NE2000 calls disable_irq and enable_irq as locking against the IRQ handler,
    but both in cases where interrupts are on and off. This means that lockdep
    needs to track the old state of the virtual irq flags on disable_irq, and
    restore these at enable_irq time.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Ingo Molnar
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

14 Sep, 2006

1 commit


20 Jul, 2006

1 commit


04 Jul, 2006

1 commit

  • 8390.c knows that ei_local->page_lock can only be used by an irq context that
    it disabled - and can hence take the ->page_lock without disabling hardirqs.
    Teach lockdep about this.

    Has no effect on non-lockdep kernels.

    Signed-off-by: Ingo Molnar
    Cc: Arjan van de Ven
    Cc: Jeff Garzik
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     

23 Jun, 2006

1 commit

  • Ar Iau, 2006-06-22 am 21:29 +1000, ysgrifennodd Herbert Xu:
    > Alan Cox wrote:
    > >
    > > The 8390 change (corrected version) also makes 8390.c faster so should
    > > be applied anyway, and the orinoco one fixes some code that isn't even
    > > needed and someone forgot to remove long ago. Otherwise the skb_padto
    >
    > Yeah I agree totally. However, I haven't actually seen the fixed 8390
    > version being posted yet or at least not to netdev :)

    Ah the resounding clang of a subtle hint ;)

    Signed-off-by: Alan Cox

    - Return 8390.c to the old way of handling short packets (which is also
    faster)

    - Remove the skb_padto from orinoco. This got left in when the padding bad
    write patch was added and is actually not needed. This is fixing a merge
    error way back when.

    - Wavelan can also use the stack based buffer trick if you want
    Signed-off-by: Jeff Garzik

    Alan Cox
     

23 Sep, 2005

1 commit

  • While this is true, E8390_CMD is zero on i386, and thus there should be no
    effect for these machines. Machines like Mac, Amiga etc. which use Alan's
    clever register mapping may have a non-zero E8390_CMD and result in bogus
    "transmitter busy" type messages from this bug.

    Fixes BUG# 3991.

    Paul Gortmaker
     

22 Jun, 2005

1 commit

  • This patch removes an obsolete header file include/asm-m32r/m32102peri.h.
    In this header, there are some undesirable single character types, like V.
    And the header is almost no longer used.

    Signed-off-by: Hayato Fujiwara
    Signed-off-by: Hirokazu Takata
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Hirokazu Takata
     

17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds