05 Dec, 2006

2 commits

  • struct pcmcia_device *p_dev->conf.ConfigBase and .Present are set in almost
    all PCMICA driver right at the beginning, using the same calls but slightly
    different implementations. Unfiy this in the PCMCIA core.

    Includes a small bugfix ("drivers/net/pcmcia/xirc2ps_cs.c: remove unused
    label") from and Signed-off-by Adrian Bunk

    Signed-off-by: Dominik Brodowski

    Dominik Brodowski
     
  • As we read out the manufactor and card_id from the PCMCIA device in the
    PCMCIA core, and device drivers can access those reliably in struct
    pcmcia_device's fields manf_id and card_id, remove additional (and partly
    broken) manf_id and card_id detection logic from PCMCIA device drivers.

    Signed-off-by: Dominik Brodowski

    Dominik Brodowski
     

02 Dec, 2006

1 commit


05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

14 Sep, 2006

1 commit


09 Aug, 2006

1 commit


03 Jul, 2006

1 commit


24 May, 2006

2 commits


22 Apr, 2006

1 commit


31 Mar, 2006

8 commits


04 Mar, 2006

3 commits


06 Jan, 2006

4 commits


29 Oct, 2005

1 commit


28 Jul, 2005

1 commit

  • If the product-id-string contains the '+' , '&' ,'_', it was not converted
    properly from the /etc/pcmcia/config(pcmcia-cs config file).

    Signed-off-by: Dominik Brodowski
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Komuro
     

08 Jul, 2005

2 commits


28 Jun, 2005

2 commits


27 Jun, 2005

1 commit

  • During some performance diagnostics I stumbled on this slightly wasteful
    code in pcnet_cs.c which I made the patch included at the bottom for (two
    minor comment fixes included).

    Improvement:
    instead of *always* calculating
    lea 0x2c0(%edx),%ebx
    and then additionally doing the
    mov %edx,0xc0(%ebx)
    addition *if we need it*,

    we now do the *whole* calculation of
    mov %edx,0x380(%ebx)
    *only* if we need it.
    This even manages to save us a whole 16-byte alignment buffer loss
    in this compilation case.

    Result: slightly improves IRQ handler performance in both shared and
    non-shared IRQ case, which should make my rusty P3/700 a slight bit happier.

    Thank you for your support,

    Andreas Mohr

    old asm result (using gcc 3.3.5):

    000015a0 :
    15a0: 55 push %ebp
    15a1: 89 e5 mov %esp,%ebp
    15a3: 53 push %ebx
    15a4: 8d 9a c0 02 00 00 lea 0x2c0(%edx),%ebx
    15aa: e8 fc ff ff ff call 15ab
    15af: 83 f8 01 cmp $0x1,%eax
    15b2: 74 03 je 15b7
    15b4: 5b pop %ebx
    15b5: 5d pop %ebp
    15b6: c3 ret
    15b7: 31 d2 xor %edx,%edx
    15b9: 89 93 c0 00 00 00 mov %edx,0xc0(%ebx)
    15bf: eb f3 jmp 15b4
    15c1: eb 0d jmp 15d0
    15c3: 90 nop
    15c4: 90 nop
    15c5: 90 nop
    15c6: 90 nop
    15c7: 90 nop
    15c8: 90 nop
    15c9: 90 nop
    15ca: 90 nop
    15cb: 90 nop
    15cc: 90 nop
    15cd: 90 nop
    15ce: 90 nop
    15cf: 90 nop

    000015d0 :

    new asm result:

    000015a0 :
    15a0: 55 push %ebp
    15a1: 89 e5 mov %esp,%ebp
    15a3: 53 push %ebx
    15a4: 89 d3 mov %edx,%ebx
    15a6: e8 fc ff ff ff call 15a7
    15ab: 83 f8 01 cmp $0x1,%eax
    15ae: 74 03 je 15b3
    15b0: 5b pop %ebx
    15b1: 5d pop %ebp
    15b2: c3 ret
    15b3: 31 d2 xor %edx,%edx
    15b5: 89 93 80 03 00 00 mov %edx,0x380(%ebx)
    15bb: eb f3 jmp 15b0
    15bd: 8d 76 00 lea 0x0(%esi),%esi

    000015c0 :

    Signed-off-by: Andrew Morton

    Andreas Mohr
     

16 May, 2005

1 commit


17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds