07 Dec, 2006

1 commit


05 Dec, 2006

1 commit


04 Dec, 2006

4 commits


02 Dec, 2006

1 commit


30 Nov, 2006

1 commit

  • This changes the type of variable "i" in rtl8169_init_one()
    from "unsigned int" to "int". "i" is checked for < 0 later,
    which can never happen for "unsigned". This results in broken
    error handling.

    Signed-off-by: Michael Buesch
    Signed-off-by: Francois Romieu
    Signed-off-by: Linus Torvalds

    Francois Romieu
     

22 Nov, 2006

1 commit


30 Oct, 2006

1 commit

  • This reverts commit a2b98a697fa4e7564f78905b83db122824916cf9.

    As per Guennadi Liakhovetski, the mac address change support code breaks
    some normal uses (_without_ any address changes), and until it's all
    sorted out, we're better off without it.

    Says Francois:

    "Go revert it.

    Despite what I claimed, I can not find a third-party confirmation by
    email that it works elsewhere.

    It would probably be enough to remove the call to
    __rtl8169_set_mac_addr() in rtl8169_hw_start() though."

    See also

    http://bugzilla.kernel.org/show_bug.cgi?id=6032

    Cc: Guennadi Liakhovetski
    Acked-by: Francois Romieu
    Signed-off-by: Linus Torvalds

    Linus Torvalds
     

22 Oct, 2006

1 commit


13 Oct, 2006

1 commit


10 Oct, 2006

1 commit


05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

25 Sep, 2006

1 commit

  • * 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6: (217 commits)
    net/ieee80211: fix more crypto-related build breakage
    [PATCH] Spidernet: add ethtool -S (show statistics)
    [NET] GT96100: Delete bitrotting ethernet driver
    [PATCH] mv643xx_eth: restrict to 32-bit PPC_MULTIPLATFORM
    [PATCH] Cirrus Logic ep93xx ethernet driver
    r8169: the MMIO region of the 8167 stands behin BAR#1
    e1000, ixgb: Remove pointless wrappers
    [PATCH] Remove powerpc specific parts of 3c509 driver
    [PATCH] s2io: Switch to pci_get_device
    [PATCH] gt96100: move to pci_get_device API
    [PATCH] ehea: bugfix for register access functions
    [PATCH] e1000 disable device on PCI error
    drivers/net/phy/fixed: #if 0 some incomplete code
    drivers/net: const-ify ethtool_ops declarations
    [PATCH] ethtool: allow const ethtool_ops
    [PATCH] sky2: big endian
    [PATCH] sky2: fiber support
    [PATCH] sky2: tx pause bug fix
    drivers/net: Trim trailing whitespace
    [PATCH] ehea: IBM eHEA Ethernet Device Driver
    ...

    Manually resolved conflicts in drivers/net/ixgb/ixgb_main.c and
    drivers/net/sky2.c related to CHECKSUM_HW/CHECKSUM_PARTIAL changes by
    commit 84fa7933a33f806bbbaae6775e87459b1ec584c0 that just happened to be
    next to unrelated changes in this update.

    Linus Torvalds
     

23 Sep, 2006

2 commits


21 Sep, 2006

1 commit


14 Sep, 2006

1 commit


13 Sep, 2006

1 commit


12 Sep, 2006

1 commit

  • Inverting the write ordering of the TxDescAddr{High/Low} registers
    suffices to trigger a sabbat of PCI errors which make the device
    completely dysfunctional. The issue has not been reported on a
    different platform.

    Switching from MMIO accesses to I/O ones as done in Realtek's
    own driver fixes (papers over ?) the bug as well but I am not
    thrilled to see everyone pay the I/O price for an obscure bug.

    This is the minimal change to handle the issue.

    Signed-off-by: Francois Romieu
    Reported-by: Lennert Buytenhek

    Francois Romieu
     

01 Sep, 2006

6 commits


20 Aug, 2006

1 commit


27 Jul, 2006

5 commits

  • - add several PCI ID for the PCI-E adapters ;
    - new identification strings ;
    - the RTL_GIGA_MAC_VER_ defines have been renamed to closely match the
    out-of-tree driver. It makes the comparison less hairy ;
    - various magic ;
    - the PCI region for the device with PCI ID 0x8136 is guessed.
    Explanation: the in-kernel Linux driver is written to allow MM register
    accesses and avoid the IO tax. The relevant BAR register was found at
    base address 1 for the plain-old PCI 8169. User reported lspci show that
    it is found at base address 2 for the new Gigabit PCI-E 816{8/9}.
    Typically:
    01:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd.: Unknown device 8168 (rev 01)
    Subsystem: Unknown device 1631:e015
    Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
    Status: Cap+ 66Mhz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR-

    Francois Romieu
     
  • Rationale:
    - its signature is not exactly pretty;
    - it has no knowledge of pci_device_id;
    - kiss 23 lines good bye.

    Signed-off-by: Francois Romieu

    Francois Romieu
     
  • The datasheet suggests that the device handles the hardware flow
    control almost automagically. User report a different story, so
    let's try to twiddle the mii registers.

    Signed-off-by: Francois Romieu

    Francois Romieu
     
  • Signed-off-by: Francois Romieu

    Francois Romieu
     
  • Fix for http://bugzilla.kernel.org/show_bug.cgi?id=6032.

    Cc: Tim Mattox
    Signed-off-by: Francois Romieu

    Francois Romieu
     

06 Jul, 2006

2 commits


03 Jul, 2006

1 commit


23 Jun, 2006

2 commits

  • Having separate fields in sk_buff for TSO/UFO (tso_size/ufo_size) is not
    going to scale if we add any more segmentation methods (e.g., DCCP). So
    let's merge them.

    They were used to tell the protocol of a packet. This function has been
    subsumed by the new gso_type field. This is essentially a set of netdev
    feature bits (shifted by 16 bits) that are required to process a specific
    skb. As such it's easy to tell whether a given device can process a GSO
    skb: you just have to and the gso_type field and the netdev's features
    field.

    I've made gso_type a conjunction. The idea is that you have a base type
    (e.g., SKB_GSO_TCPV4) that can be modified further to support new features.
    For example, if we add a hardware TSO type that supports ECN, they would
    declare NETIF_F_TSO | NETIF_F_TSO_ECN. All TSO packets with CWR set would
    have a gso_type of SKB_GSO_TCPV4 | SKB_GSO_TCPV4_ECN while all other TSO
    packets would be SKB_GSO_TCPV4. This means that only the CWR packets need
    to be emulated in software.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     
  • First of all it is unnecessary to allocate a new skb in skb_pad since
    the existing one is not shared. More importantly, our hard_start_xmit
    interface does not allow a new skb to be allocated since that breaks
    requeueing.

    This patch uses pskb_expand_head to expand the existing skb and linearize
    it if needed. Actually, someone should sift through every instance of
    skb_pad on a non-linear skb as they do not fit the reasons why this was
    originally created.

    Incidentally, this fixes a minor bug when the skb is cloned (tcpdump,
    TCP, etc.). As it is skb_pad will simply write over a cloned skb. Because
    of the position of the write it is unlikely to cause problems but still
    it's best if we don't do it.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     

27 May, 2006

1 commit


04 Mar, 2006

1 commit