Eric Lee / smarc-fsl-linux-kernel

25 Mar, 2019

1 commit

  • 0d5f20c42   batman-adv: Drop license boilerplate ... Browse Code »

    All files got a SPDX-License-Identifier with commit 7db7d9f369a4
    ("batman-adv: Add SPDX license identifier above copyright header"). All the
    required information about the license conditions can be found in
    LICENSES/.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     

04 Jan, 2019

1 commit

27 Feb, 2018

1 commit

16 Dec, 2017

3 commits

  • e57acf8e9   batman-adv: Add kernel-doc to functions in headers ... Browse Code »

    Externally visible functions should be documented with kernel-doc. This
    usually refers to non-static functions but also static inline files in
    headers are visible in other files and should therefore be documented.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     
  • 7e9a8c2ce   batman-adv: Use parentheses in function kernel-doc ... Browse Code »

    The documentation describing kernel-doc comments for functions ("How to
    format kernel-doc comments") uses parentheses at the end of the function
    name. Using this format allows to use a consistent style when adding
    documentation to a function and when referencing this function in a
    different kernel-doc section.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     
  • 7db7d9f36   batman-adv: Add SPDX license identifier above copyright header ... Browse Code »

    The "Linux kernel licensing rules" require that each file has a SPDX
    license identifier as first line (and sometimes as second line).

    The FSFE REUSE practices [1] would also require the same tags but have no
    restrictions on the placement in the source file. Using the "Linux kernel
    licensing rules" is therefore also fulfilling the FSFE REUSE practices
    requirements at the same time.

    [1] https://reuse.software/practices/

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     

26 Jan, 2017

1 commit

10 May, 2016

1 commit

  • 4b426b108   batman-adv: Use bool as return type for boolean functions ... Browse Code »

    It is easier to understand that the returned value of a specific function
    doesn't have to be 0 when the functions was successful when the actual
    return type is bool. This is especially true when all surrounding functions
    with return type int use negative values to return the error code.

    Reported-by: Nicholas Krause
    Signed-off-by: Sven Eckelmann
    Signed-off-by: Marek Lindner
    Signed-off-by: Antonio Quartulli

    Sven Eckelmann
     

02 Feb, 2016

3 commits

25 Aug, 2015

1 commit

07 Jun, 2015

1 commit

  • 1e2c2a4fe   batman-adv: Add required includes to all files ... Browse Code »

    The header files could not be build indepdent from each other. This is
    happened because headers didn't include the files for things they've used.
    This was problematic because the success of a build depended on the
    knowledge about the right order of local includes.

    Also source files were not including everything they've used explicitly.
    Instead they required that transitive includes are always stable. This is
    problematic because some transitive includes are not obvious, depend on
    config settings and may not be stable in the future.

    The order for include blocks are:

    * primary headers (main.h and the *.h file of a *.c file)
    * global linux headers
    * required local headers
    * extra forward declarations for pointers in function/struct declarations

    The only exceptions are linux/bitops.h and linux/if_ether.h in packet.h.
    This header file is shared with userspace applications like batctl and must
    therefore build together with userspace applications. The header
    linux/bitops.h is not part of the uapi headers and linux/if_ether.h
    conflicts with the musl implementation of netinet/if_ether.h. The
    maintainers rejected the use of __KERNEL__ preprocessor checks and thus
    these two headers are only in main.h. All files using packet.h first have
    to include main.h to work correctly.

    Reported-by: Markus Pargmann
    Signed-off-by: Sven Eckelmann
    Signed-off-by: Marek Lindner

    Sven Eckelmann
     

29 May, 2015

1 commit

08 Jan, 2015

1 commit

12 Jan, 2014

1 commit

09 Jan, 2014

1 commit

19 Jan, 2013

1 commit

20 Sep, 2012

1 commit

  • dbd6b11e1   batman-adv: make batadv_test_bit() return 0 or 1 only ... Browse Code »

    On some architectures test_bit() can return other values than 0 or 1:

    With a generic x86 OpenWrt image in a kvm setup (batadv_)test_bit()
    frequently returns -1 for me, leading to batadv_iv_ogm_update_seqnos()
    wrongly signaling a protected seqno window.

    This patch tries to fix this issue by making batadv_test_bit() return 0
    or 1 only.

    Signed-off-by: Linus Lüssing
    Acked-by: Sven Eckelmann
    Signed-off-by: Antonio Quartulli
    Signed-off-by: David S. Miller

    Linus Lüssing
     

28 Jun, 2012

1 commit

25 Jun, 2012

1 commit

21 Jun, 2012

2 commits

11 Apr, 2012

1 commit

17 Feb, 2012

1 commit

20 Jun, 2011

2 commits

  • b4e170541   batman-adv: Reduce usage of char ... Browse Code »

    char was used in different places to store information without really
    using the characteristics of that data type or by ignoring the fact that
    char has not a well defined signedness.

    Signed-off-by: Sven Eckelmann

    Sven Eckelmann
     
  • b2c44a538   batman-adv: count_real_packets() in batman-adv assumes char is signed ... Browse Code »

    count_real_packets() in batman-adv assumes char is signed, and returns -1
    through it:

    net/batman-adv/routing.c: In function 'receive_bat_packet':
    net/batman-adv/routing.c:739: warning: comparison is always false due to limited range of data type

    Use int instead.

    Signed-off-by: David Howells
    [sven@narfation.org: Rebase on top of current version]
    Signed-off-by: Sven Eckelmann

    David Howells
     

30 May, 2011

1 commit

31 Jan, 2011

1 commit

17 Dec, 2010

1 commit

  • c6c8fea29   net: Add batman-adv meshing protocol ... Browse Code »

    B.A.T.M.A.N. (better approach to mobile ad-hoc networking) is a routing
    protocol for multi-hop ad-hoc mesh networks. The networks may be wired or
    wireless. See http://www.open-mesh.org/ for more information and user space
    tools.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: David S. Miller

    Sven Eckelmann